[edk2] [patch] NetworkPkg: Fix issue in dns driver when building DHCP packet.

2017-05-04 Thread Zhang Lubo
-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/DnsDxe/DnsDhcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/DnsDxe/DnsDhcp.c b/Net

[edk2] [patch] NetworkPkg: Fix issue the iSCSI client can not send reset packet.

2017-04-28 Thread Zhang Lubo
of sock lock which lead the iSCSI can not reset the connection correctly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com>

[edk2] [patch] NetworkPkg: Fix bug in iSCSI mode ipv6 when enabling target DHCP.

2017-04-28 Thread Zhang Lubo
if the server name expressed as a site local address begain with FEC0 when retrieving from dhcpv6 option 59 boot file url, it incorrectly process it as a dns name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Wu Jiaxin &

[edk2] [patch] MdeModulePkg: Fix issue the iSCSI client can not send reset packet correctly.

2017-04-28 Thread Zhang Lubo
of sock lock which lead the iSCSI can not reset the connection correctly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.c

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList

2017-04-16 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Monday, April 17, 2017 11:34 AM To: edk2-devel@lists.01.org Cc: Subramanian Sriram <srira...@hpe.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com&g

[edk2] [patch] NetworkPkg: Add check logic for iSCSI driver.

2017-04-06 Thread Zhang Lubo
Need to check variable of mPrivate whether is null before used and redefine the array length of target address for keyword. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ti

[edk2] [patch] NetworkPkg: Fix bug related DAD issue in IP6 driver.

2017-04-06 Thread Zhang Lubo
it is not needed to perform DAD call back function which is invoked by Ip6ConfigSetMaunualAddress. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan &l

Re: [edk2] ASSERT with PXE IPv6 boot.

2017-04-05 Thread Zhang, Lubo
: Monday, April 03, 2017 2:43 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] ASSERT with PXE IPv6 boot. Hi Lubo, The issue can be reproduced when we set the PXE IPv6 as first boot option and let the

Re: [edk2] [Patch] MdeModulePkg/DxeHttpLib: Avoid the pointless comparison of UINTN with zero

2017-03-31 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Saturday, April 01, 2017 8:22 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan <dandan...@intel.com>; Zhang, Lubo <lubo.zh...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, Siy

Re: [edk2] [Patch] NetworkPkg/DnsDxe: Fix zero StationIp configuration failure of DNSv6

2017-03-29 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Friday, March 24, 2017 2:00 PM To: edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo.zh...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jia

Re: [edk2] [Patch] MdeModulePkg/DxeHttpLib: Fix the incorrect return status if URI port is invalid

2017-03-28 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Monday, March 27, 2017 2:48 PM To: edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo.zh...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jia

[edk2] [patch] NetworkPkg: Fix some bugs related to iSCSI keyword configuration.

2017-03-24 Thread Zhang Lubo
Add check logic and error message for some keywords validity. show target address in URL format and MAC address correctly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyu

Re: [edk2] ASSERT with PXE IPv6 boot.

2017-03-23 Thread Zhang, Lubo
Hi Naveen I have made a quick test on Denlow platform following the steps to install windows 10, but cannot reproduce. Thanks Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting Sent: Thursday, March 23, 2017 1:18 PM To:

Re: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect error handling in DriverEntryPoint

2017-03-21 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin > Wu > Sent: Wednesday, March 22, 2017 9:33 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel

[edk2] [patch] Nt32Pkg: Add NETWORK_IP6_ENABLE to use Max variableSize Pcd on Nt32.

2017-03-17 Thread Zhang Lubo
Update Nt32 platform to use the PcdMaxVariableSize when enabling Ipv6 network stack. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- Nt32Pkg/Nt3

[edk2] [patch] MdeModulePkg: Fix bug in DxeHttplib when converting port number.

2017-03-16 Thread Zhang Lubo
Http boot on X64 platform is faild, this is caused by the incorrect type conversion when getting port number from Url. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan..

Re: [edk2] [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4 dxe.

2017-03-15 Thread Zhang, Lubo
Go it, thanks for your comments Best Regards Lubo -Original Message- From: Ye, Ting Sent: Thursday, March 16, 2017 1:31 PM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Wu, Jiaxin <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com> Subj

[edk2] [PATCH V2] NetworkPkg: Fix service binding issue in TCP dxe.

2017-03-14 Thread Zhang Lubo
. But currently, we free the socket data (Socket ConfigureState) before removing the protocol form the childhandle. So if the up layer perform the driverbing stop to abort tcp session and send the tcp reset packet, it will failed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang

[edk2] [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4 dxe.

2017-03-14 Thread Zhang Lubo
. But currently, we free the socket data (Socket ConfigureState) before removing the protocol form the childhandle. So if the up layer want to send the tcp reset packet in it's driver binding stop function, it will failed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo

Re: [edk2] ISCSI says "Session Doesn't Exist"

2017-03-13 Thread Zhang, Lubo
Hi Naveen I mean that the patch will fix reconnect -r command but not reset command for next boot iSCSI connection. Thanks Lubo > -Original Message- > From: Santhapur Naveen [mailto:nave...@amiindia.co.in] > Sent: Tuesday, March 14, 2017 1:01 PM > To: Zhang, L

Re: [edk2] [patch] NetworkPkg: Fix driver binding issue in TCP dxe.

2017-03-13 Thread Zhang, Lubo
Thanks for your comments, will send another patch to update this. Best regards Lubo -Original Message- From: Wu, Jiaxin Sent: Monday, March 13, 2017 3:44 PM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyu

Re: [edk2] ISCSI says "Session Doesn't Exist"

2017-03-13 Thread Zhang, Lubo
Hi Naveen For this issue you mentioned, I have found the root cause. After we established the iSCSI connection between initiator and target server, if we use the following command immediately Reset command (system power off, will not perform driver binding stop, from my debug log) : we

[edk2] [patch] NetworkPkg: Fix driver binding issue in TCP dxe.

2017-03-10 Thread Zhang Lubo
removing the protocol form the childhandle. So if the up layer want to send the tcp reset packet in it's driver binding stop function, it will failed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.co

[edk2] [patch] MdeModulePkg: Fix driver binding issue in TCP4 and Ip4 dxe.

2017-03-10 Thread Zhang Lubo
removing the protocol form the childhandle. So if the up layer want to send the tcp reset packet in it's driver binding stop function, it will failed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.co

[edk2] [patch] NetworkPkg: Fix potential bug if the iSCSI use dns protocol.

2017-03-09 Thread Zhang Lubo
Since we use the Attempt and index as the attempt variable name instead of the MAC address plus index, we need to update this to check the whether the Controller handle is configured to use DNS protocol Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo

Re: [edk2] ISCSI says "Session Doesn't Exist"

2017-02-28 Thread Zhang, Lubo
Hi Naveen For the issue summary you mentioned, I take a test on iscsi target which deployed on Debian operating system, it works even if we do an immediate reset within 20 seconds after the first correct connection. But I am not quite sure it is a target server issue. Will investigate

[edk2] [PATCH V2] NetworkPkg: Add check logic for some variable in iSCSI driver.

2017-02-27 Thread Zhang Lubo
v2: need to check the global variable mPrivate before using it in the Convert AttemptConfigData To IfrNvData by Keyword function. Add check logic for some attempt variable to enhance code in iSCSI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo

[edk2] [patch] NetworkPkg: Define the prompt and help information for new PCD.

2017-02-27 Thread Zhang Lubo
Define the prompt and help information for PcdMaxIScsiAttemptNumber. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel

[edk2] [patch] NetworkPkg: Add check logic for some variable in iSCSI driver.

2017-02-23 Thread Zhang Lubo
Add check logic for some attempt variable to enhance code in iSCSI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel

[edk2] [patch] MdeModulePkg: Update the Ethernet interface name.

2017-02-22 Thread Zhang Lubo
Update the interface name from ethA ethB to eth10, eth11 etc if port number more than 9. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Sriram Subramanian <srira...@hpe.com> Cc: Ye Ting <ting...@intel.com> Cc:

[edk2] [patch] NetworkPkg: Update the Ethernet interface name.

2017-02-22 Thread Zhang Lubo
Update the interface name from ethA ethB to eth10, eth11 etc if port number more than 9. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Sriram Subramanian <srira...@hpe.com> Cc: Ye Ting <ting...@intel.com> Cc:

[edk2] [PATCH v2] SecurityPkg: Fix potential bug in Security Boot dxe.

2017-02-22 Thread Zhang Lubo
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Chao Zhang <chao.b.zh...@intel.com> Cc: Long Qin <qin.l...@intel.com> Cc: Yao Jiewen <jiewen@intel.com> --- .../SecureBootConfigDxe/SecureBootConfig.

Re: [edk2] [patch] SecurityPkg: Fix potential bug in Security Boot dxe.

2017-02-22 Thread Zhang, Lubo
Thanks , I will update the HASH value definition in VFR to keep them consistent with macro definition . > -Original Message- > From: Zhang, Chao B > Sent: Wednesday, February 22, 2017 4:31 PM > To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org > Cc

[edk2] [patch] SecurityPkg: Fix potential bug in Security Boot dxe.

2017-02-20 Thread Zhang Lubo
since we removed the sha-1 definition in Hash table and related macro, but the macro definition HashAlg index may be value 4 which is exceed the range of the Hash table array. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Chao

[edk2] [patch] SecurityPkg: enhance secure boot Config Dxe & Time Based AuthVariable.

2017-02-16 Thread Zhang Lubo
V3: code clean up prohibit Image SHA-1 hash option in SecureBootConfigDxe. Timebased Auth Variable driver should ensure AuthAlgorithm is SHA256 before further verification Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Chao

[edk2] [PATCH v2] NetworkPkg:Add scriptable configuration to iSCSI driver by

2017-02-16 Thread Zhang Lubo
invoke KEYWORD HANDLER Protocol to configure the related keywords. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com>

Re: [edk2] [patch] SecurityPkg: enhance secure boot Config Dxe & Time Based AuthVariable. 1. prohibit Image SHA-1 hash option in SecureBootConfigDxe. 2. Timebased Auth Variable driver should ensure Au

2017-02-15 Thread Zhang, Lubo
Thanks for your comments, I will update the patch. Lubo -Original Message- From: Zhang, Chao B Sent: Thursday, February 16, 2017 1:12 PM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Long, Qin <qin.l...@intel.com>; Yao, Jiewen <jiewen@intel.c

[edk2] [PATCH V2] SecurityPkg: enhance secure boot Config Dxe & Time Based AuthVariable.

2017-02-13 Thread Zhang Lubo
V2: Update commit log. prohibit Image SHA-1 hash option in SecureBootConfigDxe. Timebased Auth Variable driver should ensure AuthAlgorithm is SHA256 before further verification Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc

[edk2] [patch] SecurityPkg: enhance secure boot Config Dxe & Time Based AuthVariable. 1. prohibit Image SHA-1 hash option in SecureBootConfigDxe. 2. Timebased Auth Variable driver should ensure AuthAl

2017-02-13 Thread Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Chao Zhang <chao.b.zh...@intel.com> Cc: Long Qin <qin.l...@intel.com> Cc: Yao Jiewen <jiewen@intel.com> --- SecurityPkg/Library/AuthVariabl

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

2017-02-13 Thread Zhang, Lubo
Series Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: hegdenag [mailto:nagaraj-p.he...@hpe.com] Sent: Monday, February 13, 2017 3:20 PM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin <jiaxin...@intel.com>; Ye, Ting <ting...@intel.com>; Zha

Re: [edk2] [patch] NetworkPkg:Generate the correct operational state of the interface.

2017-02-09 Thread Zhang, Lubo
Yes, I just find the typo error. Thanks Lubo -Original Message- From: Wu, Jiaxin Sent: Friday, February 10, 2017 11:33 AM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Santhapur Naveen <nave...@amiindia.co.in>; Ye, Ting <ting...@intel.com>;

[edk2] [patch] MdeModulePkg:Generate the correct operational state of the interface.

2017-02-09 Thread Zhang Lubo
Currently, When there are more than 9 Ethernet ports available, 'ifconfig -l' is not listing all the ports, only show the ports 0 to 9. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Santhapur Naveen <nave...@amiindia.co.i

[edk2] [patch] NetworkPkg:Generate the correct operational state of the interface.

2017-02-09 Thread Zhang Lubo
Currently, When there are more than 9 Ethernet ports available, 'ifconfig -l' is not listing all the ports, only show the ports 0 to 9. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Santhapur Naveen <nave...@amiindia.co.i

[edk2] [patch] NetworkPkg: Fix protocol handler service in HttpDxe.

2017-01-21 Thread Zhang Lubo
-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Sriram Subramanian <srira...@hpe.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/HttpDxe/HttpDns.c| 18 Networ

[edk2] [patch] MdePkg: Update FTP4 command token structure in Ftp4.h

2017-01-19 Thread Zhang Lubo
Replace FTP4 data callback pointer-to-function-pointer with regular function pointer, This definition keep consistent with other function pointer usage Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.co

Re: [edk2] [PATCH v1 1/1] ShellPkg/Ifconfig6: Address ASSERT because of a missing NULL check

2017-01-11 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> > -Original Message- > From: hegdenag [mailto:nagaraj-p.he...@hpe.com] > Sent: Thursday, January 12, 2017 11:40 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin <jiaxin...@intel.com>; Carsey, Jaben <jaben.

[edk2] [PATCH V2] NetworkPkg: Add dns support for target URL configuration in ISCSI.

2017-01-11 Thread Zhang Lubo
in the format domainname[:port][,portal-group-tag] required by RFC 3720. Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.z

[edk2] [patch] ShellPkg: Add check logic for the gateway validity.

2017-01-06 Thread Zhang Lubo
the ifconfig -s command more consistent. Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Santhapur Naveen <nave...@amiindia.co.in> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- .../Library/UefiShellNetwork

[edk2] [patch] NetworkPkg: Add dns support for target URL configuration in ISCSI.

2016-12-18 Thread Zhang Lubo
th an target redirection status, in which contains the Target Address in the format domainname[:port][,portal-group-tag] required by RFC 3720. Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Contributed-under: TianoCore Contri

Re: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus

2016-12-06 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, December 07, 2016 11:41 AM To: edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo.zh...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan <siy

[edk2] [patch] MdeModulePkg: Fix assert in iSCSI.

2016-11-30 Thread Zhang Lubo
ain in IScsiFormExtractConfig. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- MdeModulePkg/Universal/Network/IScsiDxe/

[edk2] [patch] NetworkPkg: Correct one typo error in PXE driver.

2016-11-30 Thread Zhang Lubo
Correct the typo from Private->Icmp6Token.Status = EFI_NOT_READY to Private->IcmpToken.Status = EFI_NOT_READY when start the PXE over IPv4. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com

Re: [edk2] [Patch] NetworkPkg/IpSecDxe: correct one comment and remove the unused buf

2016-11-29 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Wednesday, November 30, 2016 10:26 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Zhang, Lubo <lubo.zh...@intel.com> Sub

Re: [edk2] [PATCH v2] ShellPkg: Add error prompt message in Ifconfig6 command.

2016-11-28 Thread Zhang, Lubo
Thank you for reminding. Lubo -Original Message- From: Hegde, Nagaraj P [mailto:nagaraj-p.he...@hpe.com] Sent: Tuesday, November 29, 2016 11:59 AM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...

[edk2] [PATCH v2] ShellPkg: Add error prompt message in Ifconfig6 command.

2016-11-28 Thread Zhang Lubo
v2: update the prompt message more readable. It should display error prompt message when Ifconfig6 can not configure correctly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Si

Re: [edk2] [patch] ShellPkg: Add error prompt message in Ifconfig6 command.

2016-11-27 Thread Zhang, Lubo
Yes, it seems more readable. I will send updated patch later Thanks Lubo > -Original Message- > From: Ye, Ting > Sent: Monday, November 28, 2016 3:03 PM > To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org > Cc: Fu, Siyuan <siyuan...@intel.

[edk2] [patch] ShellPkg: Add error prompt message in Ifconfig6 command.

2016-11-27 Thread Zhang Lubo
It should display error prompt message when Ifconfig6 can not configure correctly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin &l

Re: [edk2] [Patch] MdeModulePkg/NetLib: Handle an invalid IPv6 address case

2016-11-25 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Friday, November 25, 2016 2:16 PM To: edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo.zh...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com> Subje

[edk2] [patch] NetworkPkg:Add scriptable configuration to iSCSI driver by leveraging x-UEFI.

2016-11-25 Thread Zhang Lubo
keywords. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/IScsiDxe/IScsiCo

[edk2] [patch] ShellPkg: update ping6 to use timer service instead of timer arch protocol .

2016-11-08 Thread Zhang Lubo
This patch update the shell ping command to use timer service to calculate the RTT time, instead of using the timer arch protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ni Ruiyu <ruiyu...@intel.com> Cc: Y

[edk2] [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool

2016-10-27 Thread Zhang Lubo
Add error handling logic if failed to apply new memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c |

Re: [edk2] [Patch] NetworkPkg: Record user configured TargetIP/Port in iBFT

2016-10-14 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Ye, Ting Sent: Thursday, September 29, 2016 1:59 PM To: edk2-devel@lists.01.org Cc: Subramanian; Sriram <srira...@hpe.com>; Fu, Siyuan <siyuan...@intel.com>; Zhang, Lubo <lubo.zh...@intel

[edk2] [patch] NetworkPkg: Add dns support for pxe boot based on IPv6.

2016-10-14 Thread Zhang Lubo
this case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 18 ++- Ne

[edk2] [patch] NetworkPkg: Support bracketed IPv6 address during a redirection in iSCSI

2016-10-14 Thread Zhang Lubo
supporting dual stack. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/IS

[edk2] [patch 3/3] MdePkg:Correct the comment for the DEBUG_NET.

2016-09-22 Thread Zhang Lubo
Generalize the comment for the DEBUG_NET #define DEBUG_NET 0x4000 // SNP Driver to Network IO Driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Hegde Nagaraj P <nagaraj-p.he...@hpe.com> Cc: Subramanian S

[edk2] [patch 2/3] MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage.

2016-09-22 Thread Zhang Lubo
Tcp driver need to use EFI_D_NET to log DEBUG message, So it becomes easy to separate/filter out debug messages from network stack versus generic EFI_D_INFO debugs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Hegde Nag

[edk2] [patch 1/3] NetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage.

2016-09-22 Thread Zhang Lubo
Tcp driver need to use EFI_D_NET to log DEBUG message, So it becomes easy to separate/filter out debug messages from network stack versus generic EFI_D_INFO debugs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Hegde Nag

[edk2] [patch 0/3] TcpDriver use EFI_D_NET for DEBUG maessage

2016-09-22 Thread Zhang Lubo
Zhang Lubo (3): NetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage. MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage. MdePkg:Correct the comment for the DEBUG_NET. MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c | 46 +++--- .../Universal/Network

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-29 Thread Zhang, Lubo
Naveen [mailto:nave...@amiindia.co.in] Sent: Monday, August 29, 2016 2:27 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729 Hi Lubo, I've taken the source from the location you have spe

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-25 Thread Zhang, Lubo
...@amiindia.co.in] Sent: Thursday, August 25, 2016 5:09 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729 Hi Lubo, I believe the way we refer the version numbers seem different. I use to

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
://github.com/tianocore/edk2, it is latest edk2 code. Best Regards Lubo -Original Message- From: Santhapur Naveen [mailto:nave...@amiindia.co.in] Sent: Wednesday, August 24, 2016 7:10 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [edk2] 2nd HttpBoot fail

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
...@lists.01.org] On Behalf Of Santhapur Naveen Sent: Wednesday, August 24, 2016 4:53 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc: edk2-devel@lists.01.org Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729 Hi Lubo, Please find the following details that ma

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
Thanks Naveen. I will check it first and any progress I will inform you. Best Regards Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent: Wednesday, August 24, 2016 4:53 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
Hi Naveen Could you list the patch name or Git SHA value which fixed the 2nd HttpBootfail issue. On my side, the SVN version 24729 is not exist. Thanks Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent:

[edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

2016-08-19 Thread Zhang Lubo
If a FQDN contains 3 dots '.' like "a.b.c.com", the AsciiStrToIp4 will return success as the HostName has a valid IP address. So we need to check if it is a decimal character before using AsciiStrDecimalToUintn. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

2016-08-11 Thread Zhang, Lubo
Hi Eric Do you have any comments for this patch. Best regards Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, August 11, 2016 10:28 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu,

Re: [edk2] [patch] NetworkPkg: Refine codes of iSCSI driver

2016-08-11 Thread Zhang, Lubo
Ok, I will update the log. Thanks Lubo -Original Message- From: Ye, Ting Sent: Thursday, August 11, 2016 3:11 PM To: Zhang, Lubo <lubo.zh...@intel.com>; Dong, Eric <eric.d...@intel.com> Cc: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Subject: RE:

[edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

2016-08-10 Thread Zhang Lubo
The RSDT is only used when the bios need to support ACPI 1.0 version. When change PcdAcpiExposedTableVersions to 0x3C, it will not support ACPI 1.0. The default is 0x3E. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Eric Dong &

[edk2] [patch] NetworkPkg: Refine codes of iSCSI driver

2016-08-10 Thread Zhang Lubo
The RSDT is only used when the bios need to support ACPI 1.0 version. When change PcdAcpiExposedTableVersions to 0x3C, it will not support ACPI 1.0. The default is 0x3E. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Eric Dong &

[edk2] [patch] NetworkPkg: Fix assert issue in iSCSI driver

2016-08-01 Thread Zhang Lubo
ted-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/IScsiDxe/IScsiMisc.c | 2 ++ 1 file changed, 2 insertions(

Re: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data

2016-07-21 Thread Zhang, Lubo
If no other comments, I will ask jiaxin to help you check in your patch. Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> Thanks Lubo > -Original Message- > From: Michael Chang [mailto:mch...@suse.com] > Sent: Thursday, July 21, 2016 4:20 PM > To: Zhang, Lubo <lubo.

Re: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data

2016-07-20 Thread Zhang, Lubo
Yes, the wrong length definition of the ClassIdentifier lead to a wrong location CopyMem for system architecture when we build the vendor class option. Thanks for your correction. Do you have access to check in the code? Best Regards Lubo -Original Message- From: edk2-devel

[edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

2016-07-08 Thread Zhang Lubo
axin <jiaxin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- NetworkPkg/IScsiDxe/IScsiConfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPk

Re: [edk2] [Patch] MdeModulePkg: Fix IPv4 stack potential disappeared issue

2016-07-05 Thread Zhang, Lubo
The patch is good to me, already tested. Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Thursday, June 30, 2016 3:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@

[edk2] [patch] ShellPkg: Update the error prompt for ping6 command.

2016-07-01 Thread Zhang Lubo
ent 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c | 2 +- .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [edk2] [Patch 1/2] MdeModulePkg: Update PXE driver to follow edk2 coding standards.

2016-06-29 Thread Zhang, Lubo
Series Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Fu, Siyuan Sent: Thursday, June 30, 2016 10:08 AM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin <jiaxin...@intel.com>; Zhang, Lubo <lubo.zh...@intel.com> Subject: [Patch 1/2] MdeModulePkg:

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-21 Thread Zhang, Lubo
ira...@hpe.com>; Fu, Siyuan <siyuan...@intel.com>; Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Gao, Liming <liming@intel.com> Subject: Re: [edk2] [patch 3/3] MdePkg: Refine

Re: [edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in DnsDxe

2016-06-21 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo <lubo.zh...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Monday, June 20, 2016 9:46 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Zhang, Lubo <lubo.zh...@intel.com> Subjec

Re: [edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-20 Thread Zhang, Lubo
Got it , I will update it when to check in. Thanks lubo -Original Message- From: Ye, Ting Sent: Tuesday, June 21, 2016 9:29 AM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subj

Re: [edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-20 Thread Zhang, Lubo
should return error status. Thanks lubo -Original Message- From: Ye, Ting Sent: Monday, June 20, 2016 5:01 PM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: RE: [PATCH v2] N

[edk2] [PATCH v2 2/2] NetworkPkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-20 Thread Zhang Lubo
Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h| 128 +--

[edk2] [PATCH v2 1/2] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-20 Thread Zhang Lubo
lt;liming@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- MdePkg/I

[edk2] [PATCH v2 0/2] Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-20 Thread Zhang Lubo
v2: *add some new arch types for PXE boot. refine the definition of arch types for http boot Add a new head file Dhcp.h in Mde/Include/IndustryStandard, normalize the universal Dhcp option numbers and other network number tags. Zhang Lubo (2): MdePkg: Refine codes related to Dhcpv4 and Dhcpv6

[edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-19 Thread Zhang Lubo
reement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- NetworkPkg/HttpBootDxe/HttpBootConfig.c | 5 +++-- NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 5 - NetworkPkg/IScsiDxe/IScsiConfig.c | 8 ++-- NetworkPkg/IScsiDxe/IScsiDriver.c | 1 + NetworkPkg/IScsiDxe/

Re: [edk2] [patch] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-19 Thread Zhang, Lubo
Yes , you are right, thanks for your comments. Lubo -Original Message- From: Wu, Jiaxin Sent: Monday, June 20, 2016 11:48 AM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com> Subject:

[edk2] [patch] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-17 Thread Zhang Lubo
This patch is used to replace ASSERT with error handling in Http boot Driver and IScsi driver. Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Cc: Wu Jiaxin <jiaxin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Z

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-17 Thread Zhang, Lubo
. thanks lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Subramanian, Sriram (EG Servers Platform SW) Sent: Friday, June 17, 2016 11:57 AM To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-16 Thread Zhang, Lubo
Thanks for your comments, I will update relevant information. Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Subramanian, Sriram (EG Servers Platform SW) Sent: Friday, June 17, 2016 11:57 AM To: Zhang, Lubo <lubo.zh...@intel.com>

[edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-16 Thread Zhang Lubo
om> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- MdePkg/Include/IndustryStandard/Dhcp.h | 273 + 1 file changed, 273 insertions(+) create mode 100644 MdePkg/Include/IndustryStandard/Dhcp.

[edk2] [patch 2/3] MdeModulePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-16 Thread Zhang Lubo
reement 1.0 Signed-off-by: Zhang Lubo <lubo.zh...@intel.com> --- .../Universal/Network/Dhcp4Dxe/Dhcp4Impl.h | 4 +- MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c | 16 +- .../Universal/Network/Dhcp4Dxe/Dhcp4Option.c | 200 ++--- .../Universal/Networ

  1   2   >