: Zhang Lubo
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Fu Siyuan
---
NetworkPkg/DnsDxe/DnsDhcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg/DnsDxe/DnsDhcp.c b/NetworkPkg/DnsDxe/DnsDhcp.c
index c4add70..93779be 100644
--- a/NetworkPkg/DnsDxe/DnsDhcp.c
+++ b/NetworkPkg
sock lock which lead the iSCSI can not reset the connection correctly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Fu Siyuan
---
NetworkPkg/TcpDxe/SockInterface.c | 25 +
1 file changed, 13 insertions
if the server name expressed as a site local address begain with FEC0
when retrieving from dhcpv6 option 59 boot file url, it incorrectly process it
as a dns name.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Fu Siyuan
sock lock which lead the iSCSI can not reset the connection correctly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Fu Siyuan
---
MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c | 18 +-
1 file changed, 9
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, April 17, 2017 11:34 AM
To: edk2-devel@lists.01.org
Cc: Subramanian Sriram ; Ye, Ting ; Fu,
Siyuan ; Zhang, Lubo ; Wu, Jiaxin
Subject: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList
Cc
Need to check variable of mPrivate whether is
null before used and redefine the array length
of target address for keyword.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Fu Siyuan
---
NetworkPkg/IScsiDxe/IScsiConfig.c
needed to perform DAD call
back function which is invoked by Ip6ConfigSetMaunualAddress.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Fu Siyuan
---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 4
1 file changed, 4 insertions
: Monday, April 03, 2017 2:43 PM
To: Zhang, Lubo
Cc: Ye, Ting ; edk2-devel@lists.01.org
Subject: Re: [edk2] ASSERT with PXE IPv6 boot.
Hi Lubo,
The issue can be reproduced when we set the PXE IPv6 as first boot
option and let the system boot to it. Cancel when you get the windows Login
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Saturday, April 01, 2017 8:22 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zhang, Lubo ; Ye,
Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [Patch] MdeModulePkg/DxeHttpLib: Avoid the pointless comparison of
UINTN with
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Friday, March 24, 2017 2:00 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Lubo ; Ye, Ting ; Fu,
Siyuan ; Wu, Jiaxin
Subject: [Patch] NetworkPkg/DnsDxe: Fix zero StationIp configuration failure of
DNSv6
According UEFI Spec
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, March 27, 2017 2:48 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Lubo ; Ye, Ting ; Fu,
Siyuan ; Wu, Jiaxin
Subject: [Patch] MdeModulePkg/DxeHttpLib: Fix the incorrect return status if
URI port is invalid
Cc
Add check logic and error message for some keywords validity.
show target address in URL format and MAC address correctly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 78
Hi Naveen
I have made a quick test on Denlow platform following the steps to install
windows 10, but cannot reproduce.
Thanks
Lubo
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting
Sent: Thursday, March 23, 2017 1:18 PM
To: Santhap
Reviewed-by: Zhang Lubo
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin
> Wu
> Sent: Wednesday, March 22, 2017 9:33 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Zhang, Lubo ; Fu,
> Siyuan ; Wu, Jiaxin
>
Update Nt32 platform to use the PcdMaxVariableSize when enabling
Ipv6 network stack.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ruiyu Ni
Cc: Wu Jiaxin
---
Nt32Pkg/Nt32Pkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Nt32Pkg
Http boot on X64 platform is faild, this is caused by the incorrect
type conversion when getting port number from Url.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
Go it, thanks for your comments
Best Regards
Lubo
-Original Message-
From: Ye, Ting
Sent: Thursday, March 16, 2017 1:31 PM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Wu, Jiaxin ; Fu, Siyuan
Subject: RE: [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4
dxe.
Hi
currently, we free the socket data (Socket ConfigureState)
before removing the protocol form the childhandle. So if the up layer
perform the driverbing stop to abort tcp session and send the tcp reset
packet, it will failed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang
currently, we free the socket data
(Socket ConfigureState) before removing the protocol
form the childhandle. So if the up layer want to send the
tcp reset packet in it's driver binding stop function, it will failed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lub
Hi Naveen
I mean that the patch will fix reconnect -r command but not reset command
for next boot iSCSI connection.
Thanks
Lubo
> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Tuesday, March 14, 2017 1:01 PM
> To: Zhang, Lubo
&g
Thanks for your comments, will send another patch to update this.
Best regards
Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, March 13, 2017 3:44 PM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan
Subject: RE: [edk2] [patch] NetworkPkg: Fix driver binding
Hi Naveen
For this issue you mentioned, I have found the root cause. After we
established the iSCSI connection between initiator and target server, if we use
the following command immediately
Reset command (system power off, will not perform driver binding stop, from my
debug log) : we c
removing the protocol form the childhandle. So if the up layer
want to send the tcp reset packet in it's driver binding stop
function, it will failed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
---
NetworkPkg/TcpDxe/SockI
removing the protocol
form the childhandle. So if the up layer want to send the
tcp reset packet in it's driver binding stop function, it will failed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
---
MdeModulePkg/Universal/Ne
Since we use the Attempt and index as the attempt variable name instead of
the MAC address plus index, we need to update this to check the whether
the Controller handle is configured to use DNS protocol
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Hi Naveen
For the issue summary you mentioned, I take a test on iscsi target which
deployed on Debian operating system, it works even if we do an immediate reset
within 20 seconds after the first correct connection. But I am not quite sure
it is a target server issue.
Will investigate
v2: need to check the global variable mPrivate before using it in
the Convert AttemptConfigData To IfrNvData by Keyword function.
Add check logic for some attempt variable to enhance code in iSCSI.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc
Define the prompt and help information for PcdMaxIScsiAttemptNumber.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/NetworkPkg.uni | 3 +++
1 file changed, 3 insertions(+)
diff --git a/NetworkPkg
Add check logic for some attempt variable to enhance code in iSCSI.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 75 +--
1 file changed, 41
Update the interface name from ethA ethB to
eth10, eth11 etc if port number more than 9.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Sriram Subramanian
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
MdeModulePkg/Universal/Network/Ip4Dxe
Update the interface name from ethA ethB to
eth10, eth11 etc if port number more than 9.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Sriram Subramanian
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 2 +-
1 file
.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Chao Zhang
Cc: Long Qin
Cc: Yao Jiewen
---
.../SecureBootConfigDxe/SecureBootConfig.vfr | 10 +-
.../SecureBootConfigDxe/SecureBootConfigImpl.h | 12 ++--
2 files
Thanks , I will update the HASH value definition in VFR to keep them
consistent with macro definition .
> -Original Message-
> From: Zhang, Chao B
> Sent: Wednesday, February 22, 2017 4:31 PM
> To: Zhang, Lubo ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Long, Qin
since we removed the sha-1 definition in Hash table
and related macro, but the macro definition HashAlg index
may be value 4 which is exceed the range of the Hash
table array.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Chao Zhang
Cc: Long Qin
Cc: Yao
V3: code clean up
prohibit Image SHA-1 hash option in SecureBootConfigDxe.
Timebased Auth Variable driver should ensure AuthAlgorithm
is SHA256 before further verification
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Chao Zhang
Cc: Long Qin
Cc: Yao
invoke KEYWORD HANDLER Protocol to configure
the related keywords.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c| 1744 +-
NetworkPkg/IScsiDxe
Thanks for your comments, I will update the patch.
Lubo
-Original Message-
From: Zhang, Chao B
Sent: Thursday, February 16, 2017 1:12 PM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Long, Qin ; Yao, Jiewen
Subject: RE: [patch] SecurityPkg: enhance secure boot Config Dxe & Time B
V2: Update commit log.
prohibit Image SHA-1 hash option in SecureBootConfigDxe.
Timebased Auth Variable driver should ensure AuthAlgorithm is SHA256 before
further verification
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Chao Zhang
Cc: Long Qin
Cc
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Chao Zhang
Cc: Long Qin
Cc: Yao Jiewen
---
SecurityPkg/Library/AuthVariableLib/AuthService.c | 27 +-
.../Library/AuthVariableLib/AuthServiceInternal.h | 5
Series Reviewed-by: Zhang Lubo
-Original Message-
From: hegdenag [mailto:nagaraj-p.he...@hpe.com]
Sent: Monday, February 13, 2017 3:20 PM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin ; Ye, Ting ; Zhang, Lubo
; Fu, Siyuan ; srira...@hpe.com
Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe
Yes, I just find the typo error.
Thanks
Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Friday, February 10, 2017 11:33 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Santhapur Naveen ; Ye, Ting ;
Fu, Siyuan
Subject: RE: [patch] NetworkPkg:Generate the correct operational state of
Currently, When there are more than 9 Ethernet ports available,
'ifconfig -l' is not listing all the ports, only show the ports 0 to 9.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Santhapur Naveen
Cc: Ye Ting
Cc: Fu Siyuan
Cc:
Currently, When there are more than 9 Ethernet ports available,
'ifconfig -l' is not listing all the ports, only show the ports 0 to 9.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Santhapur Naveen
Cc: Ye Ting
Cc: Fu Siyuan
Cc:
-off-by: Zhang Lubo
Cc: Sriram Subramanian
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/HttpDxe/HttpDns.c| 18
NetworkPkg/HttpDxe/HttpDriver.c | 21 +-
NetworkPkg/HttpDxe/HttpImpl.c | 11 --
NetworkPkg/HttpDxe/HttpProto.c | 48
Replace FTP4 data callback pointer-to-function-pointer with
regular function pointer, This definition keep consistent with
other function pointer usage
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
MdePkg/Include
Reviewed-by: Zhang Lubo
> -Original Message-
> From: hegdenag [mailto:nagaraj-p.he...@hpe.com]
> Sent: Thursday, January 12, 2017 11:40 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Carsey, Jaben ;
> Ni, Ruiyu ; Zhang, Lubo ; sriram-
> s...@hpe.com
>
in the format
domainname[:port][,portal-group-tag] required by RFC 3720.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/IScsiDxe/IScsiConfig.c| 78 +++--
NetworkPkg/IScsiDxe/IScs
ing manual
address to keep the ifconfig -s command more consistent.
Signed-off-by: Zhang Lubo
Cc: Santhapur Naveen
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
.../Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 19 ++-
.../UefiShellNetwork1CommandsLib.uni
Looks good to me.
Reviewed-by: Zhang Lubo
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, December 08, 2016 8:55 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Zhang,
> Lubo ; Wu, Jiaxin
> Subject: [Patch] NetworkPkg/DnsDxe: Fixed the a
th an target redirection status,
in which contains the Target Address in the format
domainname[:port][,portal-group-tag] required by RFC 3720.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/IScsiDxe/IScsiCo
Reviewed-by: Zhang Lubo
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, December 07, 2016 11:41 AM
To: edk2-devel@lists.01.org
Cc: Zhang, Lubo ; Ye, Ting ; Fu,
Siyuan ; Wu, Jiaxin
Subject: [PATCH] ShellPkg: Assign the correct value to ShellStatus
Since the
used again in IScsiFormExtractConfig.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Universal/Net
Correct the typo
from Private->Icmp6Token.Status = EFI_NOT_READY to
Private->IcmpToken.Status = EFI_NOT_READY
when start the PXE over IPv4.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/UefiPx
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, November 30, 2016 10:26 AM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Ye, Ting ; Zhang, Lubo
Subject: [Patch] NetworkPkg/IpSecDxe: correct one comment and remove the unused
buf
Cc: Fu Siyuan
Cc: Ye Ting
Thank you for reminding.
Lubo
-Original Message-
From: Hegde, Nagaraj P [mailto:nagaraj-p.he...@hpe.com]
Sent: Tuesday, November 29, 2016 11:59 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [edk2] [PATCH v2] ShellPkg: Add error prompt
v2: update the prompt message more readable.
It should display error prompt message when Ifconfig6 can
not configure correctly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
ShellPkg/Library
Yes, it seems more readable. I will send updated patch later
Thanks
Lubo
> -Original Message-
> From: Ye, Ting
> Sent: Monday, November 28, 2016 3:03 PM
> To: Zhang, Lubo ; edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: RE: [edk2] [patch] ShellPkg
It should display error prompt message when Ifconfig6 can
not configure correctly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 15
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Friday, November 25, 2016 2:16 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Lubo ; Fu, Siyuan ; Ye,
Ting
Subject: [Patch] MdeModulePkg/NetLib: Handle an invalid IPv6 address case
Handle an invalid IPv6 address in
keywords.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c| 1769 +-
NetworkPkg/IScsiDxe/IScsiConfig.h| 78 +-
NetworkPkg/IScsiDxe
This patch update the shell ping command to use timer service to calculate the
RTT time, instead of using the timer arch protocol.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ni Ruiyu
Cc: Ye Ting
Cc: Fu Siyuan
---
.../Library
Add error handling logic if failed to apply new memory.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg
Reviewed-by: Zhang Lubo
-Original Message-
From: Ye, Ting
Sent: Thursday, September 29, 2016 1:59 PM
To: edk2-devel@lists.01.org
Cc: Subramanian; Sriram ; Fu, Siyuan ;
Zhang, Lubo
Subject: [Patch] NetworkPkg: Record user configured TargetIP/Port in iBFT
Current ISCSI driver records
this case.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 18 ++-
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 269 +++
NetworkPkg/UefiPxeBcDxe/Px
.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/DnsDxe/DnsProtocol.c | 4
1 file changed, 4 insertions(+)
diff --git a/NetworkPkg/DnsDxe/DnsProtocol.c b/NetworkPkg/DnsDxe/DnsProtocol.c
index 64fca6a
supporting dual stack.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiProto.c | 51 ++--
NetworkPkg/IScsiDxe/IScsiProto.h | 5 +++-
2 files changed, 43
Generalize the comment for the DEBUG_NET
#define DEBUG_NET 0x4000 // SNP Driver
to Network IO Driver.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Hegde Nagaraj P
Cc: Subramanian Sriram
Cc: Fu Siyuan
Cc: Ye Ting
---
MdePkg/Include/Library
Tcp driver need to use EFI_D_NET to log DEBUG message,
So it becomes easy to separate/filter out debug messages
from network stack versus generic EFI_D_INFO debugs.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Hegde Nagaraj P
Cc: Subramanian Sriram
Cc
Zhang Lubo (3):
NetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage.
MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage.
MdePkg:Correct the comment for the DEBUG_NET.
MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c | 46 +++---
.../Universal/Network
Tcp driver need to use EFI_D_NET to log DEBUG message,
So it becomes easy to separate/filter out debug messages
from network stack versus generic EFI_D_INFO debugs.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Hegde Nagaraj P
Cc: Subramanian Sriram
Cc
Naveen [mailto:nave...@amiindia.co.in]
Sent: Monday, August 29, 2016 2:27 PM
To: Zhang, Lubo
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729
Hi Lubo,
I've taken the source from the location you have specified and checked.
But I
...@amiindia.co.in]
Sent: Thursday, August 25, 2016 5:09 PM
To: Zhang, Lubo
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729
Hi Lubo,
I believe the way we refer the version numbers seem different. I use
tortoise SVN to get the
://github.com/tianocore/edk2, it
is latest edk2 code.
Best Regards
Lubo
-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
Sent: Wednesday, August 24, 2016 7:10 PM
To: Zhang, Lubo
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to
...@lists.01.org] On Behalf Of
Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729
Hi Lubo,
Please find the following details that may help.
NetworkPkg:Fix a bug
Thanks Naveen. I will check it first and any progress I will inform you.
Best Regards
Lubo
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo
Cc: edk2-devel@lists.01.org
Hi Naveen
Could you list the patch name or Git SHA value which fixed the 2nd
HttpBootfail issue. On my side, the SVN version 24729 is not exist.
Thanks
Lubo
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Santhapur Naveen
Sent: Wednesday,
If a FQDN contains 3 dots '.' like "a.b.c.com", the AsciiStrToIp4
will return success as the HostName has a valid IP address. So we
need to check if it is a decimal character before using AsciiStrDecimalToUintn.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-of
Hi Eric
Do you have any comments for this patch.
Best regards
Lubo
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Thursday, August 11, 2016 10:28 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Dong, Eric
Ok, I will update the log.
Thanks
Lubo
-Original Message-
From: Ye, Ting
Sent: Thursday, August 11, 2016 3:11 PM
To: Zhang, Lubo ; Dong, Eric
Cc: Fu, Siyuan ; edk2-devel@lists.01.org
Subject: RE: [patch] NetworkPkg: Refine codes of iSCSI driver
So how about adding your below
instead of Rsdp->RsdtAddress.
Best Regards
Lubo
-Original Message-
From: Ye, Ting
Sent: Thursday, August 11, 2016 2:14 PM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Fu, Siyuan
Subject: RE: [patch] NetworkPkg: Refine codes of iSCSI driver
Hi Lubo,
Could you please d
The RSDT is only used when the bios need to support ACPI 1.0
version. When change PcdAcpiExposedTableVersions to 0x3C, it
will not support ACPI 1.0. The default is 0x3E.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Eric Dong
Cc: Ye Ting
Cc: Fu Siyuan
The RSDT is only used when the bios need to support ACPI 1.0
version. When change PcdAcpiExposedTableVersions to 0x3C, it
will not support ACPI 1.0. The default is 0x3E.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Eric Dong
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiMisc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index deebf5d..a
If no other comments, I will ask jiaxin to help you check in your patch.
Reviewed-by: Zhang Lubo
Thanks
Lubo
> -Original Message-
> From: Michael Chang [mailto:mch...@suse.com]
> Sent: Thursday, July 21, 2016 4:20 PM
> To: Zhang, Lubo
> Cc: edk2-devel@lists.01.org
>
Yes, the wrong length definition of the ClassIdentifier lead to a wrong
location CopyMem for system architecture when we build the vendor class option.
Thanks for your correction.
Do you have access to check in the code?
Best Regards
Lubo
-Original Message-
From: edk2-devel [mailto:ed
Follow the Shell Spec, when the interface name is Specified,
we need to refresh the Ipv6 configuration.
Cc: Hegde Nagaraj P
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
.../UefiShellNetwork2CommandsLib
Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c
b/NetworkPkg/IScsiDxe/IScsiConfig.c
index 8015e3d..3631e72 100644
--- a/NetworkPkg/IScsiDxe/IScsiConfig.c
+++ b/NetworkPkg
The patch is good to me, already tested.
Reviewed-by: Zhang Lubo
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Thursday, June 30, 2016 3:59 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Zhang, Lubo ; Fu,
Siyuan
Subject: [edk2
when we use the ping6 command without configuring the network
interface, it should give correct prompt to users.
Cc: Hegde Nagaraj P
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
ShellPkg/Library/UefiShellNetwork2CommandsLib
Series Reviewed-by: Zhang Lubo
-Original Message-
From: Fu, Siyuan
Sent: Thursday, June 30, 2016 10:08 AM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin ; Zhang, Lubo
Subject: [Patch 1/2] MdeModulePkg: Update PXE driver to follow edk2 coding
standards.
Cc: Wu Jiaxin
Cc: Zhang Lubo
; Zhang, Lubo ;
edk2-devel@lists.01.org
Cc: Ye, Ting ; Wu, Jiaxin ; Gao, Liming
Subject: Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and
Dhcpv6 configuration.
Hi Lubo,
I see this patch is not committed yet. Can you please add the following #define
into IndustryStandard
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, June 20, 2016 9:46 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo
Subject: [PATCH v2] NetworkPkg: Replace ASSERT with error handling in DnsDxe
v2:
*Use goto to simplify code logic.
This
Got it , I will update it when to check in.
Thanks
lubo
-Original Message-
From: Ye, Ting
Sent: Tuesday, June 21, 2016 9:29 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http
boot and
should return error
status.
Thanks
lubo
-Original Message-
From: Ye, Ting
Sent: Monday, June 20, 2016 5:01 PM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http
boot and IScsi
Hi Lubo,
I
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h| 128 +
NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 82 ++---
NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 51
: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
MdePkg/Include/IndustryStandard/Dhcp.h | 281 +
1 file changed, 281 insertions(+)
create mode 100644 MdePkg/Include/IndustryStandard/Dhcp.h
diff --git a/MdePkg/Include
v2:
*add some new arch types for PXE boot.
refine the definition of arch types for http boot
Add a new head file Dhcp.h in Mde/Include/IndustryStandard, normalize the
universal Dhcp option numbers and other network number tags.
Zhang Lubo (2):
MdePkg: Refine codes related to Dhcpv4 and Dhcpv6
v2:
*Fix some memory leak issue.
This patch is used to replace ASSERT with error handling in Http boot
Driver and IScsi driver.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/HttpBootDxe
Yes , you are right, thanks for your comments.
Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, June 20, 2016 11:48 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan
Subject: RE: [edk2] [patch] NetworkPkg: Replace ASSERT with error handling in
Http boot and
This patch is used to replace ASSERT with error handling in Http boot
Driver and IScsi driver.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/HttpBootDxe/HttpBootConfig.c | 5 +++--
NetworkPkg
1 - 100 of 211 matches
Mail list logo