Re: [edk2] [PATCH] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Zhu, Yonghong
-Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Marvin > Häuser > Sent: Saturday, May 19, 2018 12:43 AM > To: edk2-devel@lists.01.org > Cc: jaben.car...@intel.com; liming@intel.com > Subject: [edk2] [PATCH] BaseTo

Re: [edk2] [PATCH] BaseTools/Workspace: Fix ValueChain set

2018-05-19 Thread Marvin Häuser
2:43 AM > To: edk2-devel@lists.01.org > Cc: jaben.car...@intel.com; liming....@intel.com > Subject: [edk2] [PATCH] BaseTools/Workspace: Fix ValueChain set > > Commit 88252a90d1ca7846731cd2e4e8e860454f7d97a3 changed ValueChain > from a dict to a set, but also changed the (for

[edk2] [PATCH] BaseTools/Workspace: Fix ValueChain set

2018-05-18 Thread Marvin Häuser
Commit 88252a90d1ca7846731cd2e4e8e860454f7d97a3 changed ValueChain from a dict to a set, but also changed the (former) key type from a touple to two separate values, which was probably unintended and also breaks build for packages involving Structured PCDs, because add() only takes one argument.