Re: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Long, Qin
...@redhat.com>; edk2-de...@ml01.01.org; Zhang, > Chao B <chao.b.zh...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: Re: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to > install protocols twice. > > Reviewed-by: Michael Kinney

Re: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Kinney, Michael D
jo...@redhat.com> > Subject: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install > protocols > twice. > > This patch makes Pkcs7VerifyDxe check that it has not already been > installed before installing its protocols. This prevents the case where > loading

[edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Peter Jones
This patch makes Pkcs7VerifyDxe check that it has not already been installed before installing its protocols. This prevents the case where loading it as an external driver (either manually, through Driver variables, etc.) will refuse to add a second provider of the API. v2 - return

Re: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Peter Jones
On Thu, Sep 29, 2016 at 06:38:17PM +, Kinney, Michael D wrote: > Peter, > > Please use this form in your patch. The UEFI Spec does allow other error > codes than > those listed in the API to be returned. Using !EFI_ERROR (Status) is safer. > EDK II > Coding Style also requires {} for if

Re: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Kinney, Michael D
at.com> > Subject: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install > protocols > twice. > > This patch makes Pkcs7VerifyDxe check that it has not already been > installed before installing its protocols. This prevents the case where > loading it as an

Re: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Kinney, Michael D
01.org > Cc: Peter Jones <pjo...@redhat.com> > Subject: [edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install > protocols > twice. > > This patch makes Pkcs7VerifyDxe check that it has not already been > installed before installing its protocols. This preven

[edk2] [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.

2016-09-29 Thread Peter Jones
This patch makes Pkcs7VerifyDxe check that it has not already been installed before installing its protocols. This prevents the case where loading it as an external driver (either manually, through Driver variables, etc.) will refuse to add a second provider of the API. Contributed-under: