Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-31 Thread Wang, Jian J
Jian J Sent: Friday, September 01, 2017 10:27 AM To: Yao, Jiewen <jiewen@intel.com>; Johnson, Brian (EXL - Eagan) <brian.john...@hpe.com>; af...@apple.com Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Let me summarize the ch

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-31 Thread Wang, Jian J
iewen <jiewen@intel.com> Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Jiewen, Certainly PEI could be done later. There's no need to get all the code in at once, and you have the DXE/SMM part pretty much ready to go. I'm willing

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Yao, Jiewen
01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Jiewen, Certainly PEI could be done later. There's no need to get all the code in at once, and you have the DXE/SMM part pretty much ready to go. I'm willing to go with a single PCD with a bitmap, or multipl

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Yao, Jiewen
com> Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > On Aug 30, 2017, at 7:55 AM, Yao, Jiewen > <jiewen@intel.com<mailto:jiewen@intel.com>> wrote: > > Hi Brian > Good feedback. > Comment in line. &

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Johnson, Brian (EXL - Eagan)
To: Yao, Jiewen <jiewen@intel.com> Cc: Johnson, Brian (EXL - Eagan) <brian.john...@hpe.com>; Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > On Aug 30, 2017, at 7:55 AM, Yao, Jiewen

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Andrew Fish
;jiewen@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > > Thank you for implementing this feature! It is very helpful for catching > pointer-related problems. We have u

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Yao, Jiewen
, August 27, 2017 10:39 PM To: Wang, Jian J <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Comment in line. From: Wang, Jian J Sent: Monday, Augu

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Tim Lewis
om>; Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature It makes no difference to me. But it sounds more flexible and less cumbersome to use 4 PCDs. That way you don't have to define the meanings o

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Johnson, Brian (EXL - Eagan)
hnson, Brian (EXL - Eagan) > Sent: Tuesday, August 29, 2017 8:17 AM > To: Yao, Jiewen <jiewen@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer > detection feature > > Thank you

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Kinney, Michael D
AM > To: Yao, Jiewen <jiewen@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer > detection feature > > Thank you for implementing this feature! It is very helpful > for cat

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Johnson, Brian (EXL - Eagan)
[edk2] [PATCH 0/2] Implement NULL pointer detection feature Comment in line. From: Wang, Jian J Sent: Monday, August 28, 2017 11:24 AM To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature 1) I think

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Yao, Jiewen
Comment in line. From: Wang, Jian J Sent: Monday, August 28, 2017 11:24 AM To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature 1) I think this feature should be 'FALSE' by default. I forgot to rese

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Wang, Jian J
of feature will be limited in such case. From: Yao, Jiewen Sent: Monday, August 28, 2017 11:10 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Thank you to enable this feature. I have 2 comments,

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Yao, Jiewen
; Subject: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > > This patch is the implementation of NULL pointer detection feature, > which is one of the small features of Special Pool. > > Wang, Jian J (2): > Implement NULL pointer detection for EDK-II Core > Imp

[edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Wang, Jian J
This patch is the implementation of NULL pointer detection feature, which is one of the small features of Special Pool. Wang, Jian J (2): Implement NULL pointer detection for EDK-II Core Implement NULL pointer detection for EDK-II SMM Core and driver MdeModulePkg/Core/Dxe/DxeMain.inf