Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-09 Thread Palmer, Thomas
er, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI I've submitted a tracker for this: https://bugzilla.tianocore.org/show_bug.cgi?id=664

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-09 Thread Palmer, Thomas
, August 7, 2017 12:57 AM To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI Because an internal function doesn't need to

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-07 Thread Palmer, Thomas
01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI Because an internal function doesn't need to have EFIAPI prefix. I think a proper fix is to change both BaseLib and UefiShellLevel2CommandsLib to

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-06 Thread Ni, Ruiyu
r, Thomas > Sent: Friday, August 4, 2017 3:07 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: > Remove unnecessary EFIAPI > > Ruiyu, > Sorry for replying to old patch, I was clea

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-03 Thread Palmer, Thomas
r 30, 2016 3:18 AM To: edk2-devel@lists.01.org Cc: Ruiyu Ni <ruiyu...@intel.com>; Jaben Carsey <jaben.car...@intel.com>; Chen A Chen <chen.a.c...@intel.com> Subject: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI From: Ruiyu Ni <ruiyu..

[edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2016-09-30 Thread Ruiyu Ni
From: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen A Chen Cc: Jaben Carsey Cc: Ruiyu Ni --- ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 4