On 31 July 2015 at 20:40, Laszlo Ersek <ler...@redhat.com> wrote:
> This reverts git commit d2733aa9 (SVN r18042), because it is empty now.
> The original problem:
>
>   Many universal DXE drivers in edk2 can be controlled by setting dynamic
>   PCDs. Such a PCD must be set before the consumer DXE driver is
>   dispatched.
>
> should be hereafter solved similarly to how
> OvmfPkg/Library/SmbiosVersionLib is plugged into
> MdeModulePkg/Universal/SmbiosDxe now (originally suggested by Jordan
> Justen <jordan.l.jus...@intel.com>).
>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Cc: Wei Huang <w...@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>

> ---
>  ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf | 42 --------------------
>  ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c   | 33 ---------------
>  ArmVirtPkg/ArmVirtQemu.dsc                      |  1 -
>  ArmVirtPkg/ArmVirtQemu.fdf                      |  2 -
>  4 files changed, 78 deletions(-)
>
> diff --git a/ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf 
> b/ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf
> deleted file mode 100644
> index a9983be..0000000
> --- a/ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -## @file
> -#  An "early" DXE driver that parses well-known fw-cfg files into dynamic 
> PCDs
> -#  that control other (universal) DXE drivers.
> -#
> -#  Copyright (C) 2015, Red Hat, Inc.
> -#  Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> -#
> -#  This program and the accompanying materials are licensed and made 
> available
> -#  under the terms and conditions of the BSD License which accompanies this
> -#  distribution.  The full text of the license may be found at
> -#  http://opensource.org/licenses/bsd-license.php
> -#
> -#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> -#  IMPLIED.
> -#
> -##
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010005
> -  BASE_NAME                      = QemuFwCfgToPcdDxe
> -  FILE_GUID                      = 5bb7cc92-1a36-4833-84cf-db7f8258e48d
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -  ENTRY_POINT                    = ParseQemuFwCfgToPcd
> -
> -[Sources]
> -  QemuFwCfgToPcd.c
> -
> -[Packages]
> -  MdePkg/MdePkg.dec
> -  OvmfPkg/OvmfPkg.dec
> -
> -[LibraryClasses]
> -  PcdLib
> -  QemuFwCfgLib
> -  UefiDriverEntryPoint
> -
> -[Pcd]
> -
> -[Depex]
> -  TRUE
> diff --git a/ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c 
> b/ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c
> deleted file mode 100644
> index 8f60e21..0000000
> --- a/ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -/** @file
> -*  An "early" DXE driver that parses well-known fw-cfg files into dynamic 
> PCDs
> -*  that control other (universal) DXE drivers.
> -*
> -*  Copyright (C) 2015, Red Hat, Inc.
> -*  Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> -*
> -*  This program and the accompanying materials are licensed and made 
> available
> -*  under the terms and conditions of the BSD License which accompanies this
> -*  distribution.  The full text of the license may be found at
> -*  http://opensource.org/licenses/bsd-license.php
> -*
> -*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> -*  IMPLIED.
> -*
> -**/
> -
> -#include <Uefi/UefiBaseType.h>
> -#include <Uefi/UefiSpec.h>
> -
> -#include <Library/PcdLib.h>
> -#include <Library/QemuFwCfgLib.h>
> -
> -EFI_STATUS
> -EFIAPI
> -ParseQemuFwCfgToPcd (
> -  IN EFI_HANDLE       ImageHandle,
> -  IN EFI_SYSTEM_TABLE *SystemTable
> -  )
> -{
> -  return EFI_SUCCESS;
> -}
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 00571d4..618a158 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -316,7 +316,6 @@ [Components.common]
>    # Platform Driver
>    #
>    ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
> -  ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf
>    OvmfPkg/VirtioBlkDxe/VirtioBlk.inf
>    OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
>    OvmfPkg/VirtioNetDxe/VirtioNet.inf
> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf
> index 3c0487c..f378da5 100644
> --- a/ArmVirtPkg/ArmVirtQemu.fdf
> +++ b/ArmVirtPkg/ArmVirtQemu.fdf
> @@ -104,12 +104,10 @@ [FV.FvMain]
>    APRIORI DXE {
>      INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
>      INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
> -    INF ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf
>    }
>    INF MdeModulePkg/Core/Dxe/DxeMain.inf
>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
>    INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf
> -  INF ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf
>
>    #
>    # PI DXE Drivers producing Architectural Protocols (EFI Services)
> --
> 1.8.3.1
>
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to