Re: [edk2] [PATCH 52/52] BaseTools/VfrCompile/Pccts: Make assignment operator not returning void

2016-10-17 Thread Dong, Eric
Hi Hao, I have below comments: Case 1: In order to keep consistence, can you also change other cases which still initialized with '\0' mOptions.VfrFileName[0]= '\0'; mOptions.RecordListFile= NULL; mOptions.CreateRecordListFile = FALSE;

[edk2] [PATCH 52/52] BaseTools/VfrCompile/Pccts: Make assignment operator not returning void

2016-10-12 Thread Hao Wu
The assignment operators for class ANTLRTokenPtr return void in current code. This commit makes them return the reference to the object just like primitive types do. Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi