Re: [edk2] [PATCH V2] SecurityPkg\Tcg2Pei: FV measure performance enhancement

2017-10-13 Thread Zhang, Chao B
Hi Jiewen & Qin: Thank you very much for all the comments. I will update PPI comments with clear wording. Here are all the information of white box test. The test matrix covered different algorithms combinations for Pre-hash data & Hash required for TPM. All the results were expec

Re: [edk2] [PATCH V2] SecurityPkg\Tcg2Pei: FV measure performance enhancement

2017-10-13 Thread Yao, Jiewen
Thank you Chao! I have 2 minor suggestion. 1) I know you did lots of unit test. Would you please share the information to all of us? 2) I found the pre-hash/tpm-mask mismatch case might be misunderstood. Would you please add some comment in the ppi header file to describe the expectation clearly

Re: [edk2] [PATCH V2] SecurityPkg\Tcg2Pei: FV measure performance enhancement

2017-10-13 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Friday, October 13, 2017 3:26 PM To: edk2-devel@lists.01.org Cc: Long, Qin ; Yao, Jiewen ; sean.bro...@microsoft.com; Zhang, Chao B Subject: [PATCH V2] SecurityPkg\Tcg2Pei: FV measure

[edk2] [PATCH V2] SecurityPkg\Tcg2Pei: FV measure performance enhancement

2017-10-13 Thread Zhang, Chao B
1. Leverage Pre-Hashed FV PPI to reduce duplicated hash 2. Only measure BFV at the beginning. Other FVs are measured in FVinfo callback with nested FV check. https://bugzilla.tianocore.org/show_bug.cgi?id=662 Cc: Long Qin Cc: Yao Jiewen Cc: Sean Brogan Contributed-under: TianoCore Contribut