Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-31 Thread Gao, Zhichao
> Andrew Fish via edk2-devel ; Kinney, Michael D > ; Gao, Zhichao > Cc: Wu, Hao A ; edk2-devel de...@lists.01.org>; Bret Barkelew ; > Michael Turner ; Zeng, Star > ; Ard Biesheuvel ; Laszlo > Ersek > Subject: Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to >

Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-31 Thread Jordan Justen
Whoops. It looks like this was specifically addressed in v3 of the series. I just didn't see a follow up email discussion to Andrew's email. Please disregard. -Jordan On 2019-03-31 23:17:12, Jordan Justen wrote: > On 2019-03-14 22:54:24, Andrew Fish via edk2-devel wrote: > > I understand the mot

Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-31 Thread Jordan Justen
On 2019-03-14 22:54:24, Andrew Fish via edk2-devel wrote: > I understand the motivation for this change as I've done something > much less portable that looks a lot like this to save the PEI XIP > space > > I seem to remember a long time ago we add a public VA_LIST to an API > and we ran into

Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-14 Thread Andrew Fish via edk2-devel
I understand the motivation for this change as I've done something much less portable that looks a lot like this to save the PEI XIP space I seem to remember a long time ago we add a public VA_LIST to an API and we ran into an issue due to the marker format being compiler specific. You don't

[edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-14 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add the new PEIM DebugServicePei and library instance PeiDebugLibDebugPpi to dsc file to verify it can build correctly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Jian J Wang Cc: Hao Wu Cc: Ray