Re: [edk2] [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options

2019-01-30 Thread Ryszard Knop
Just one note for this: We have separate defines for EFI32 (IA32), EFI64 (IPF) and EFIX64 (X64) to sprinkle some workarounds where needed. It seems ARM doesn't need that for now, but I'll add similar defines for it as well so that we have that available in the future. Reviewed-by: Ryszard Knop

[edk2] [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options

2018-11-06 Thread Ard Biesheuvel
Prefix the existing MSFT only build option overrides with MSFT: and create the GCC: counterparts so we can build this code with GCC as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 16 1