Re: [edk2] [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle

2019-01-30 Thread Andrew Fish via edk2-devel
> On Jan 30, 2019, at 8:05 AM, Ryszard Knop > wrote: > > Hmm, is there a list/something I can generate to see which globals > build tools emit? There are some more variables I'd happily get rid > of, eg if I could drop gSystemTable and others. > Ryszard, You need to use libs by including

Re: [edk2] [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle

2019-01-30 Thread Ryszard Knop
Ah, thanks! On Wed, 2019-01-30 at 17:06 +0100, Ard Biesheuvel wrote: > On Wed, 30 Jan 2019 at 17:05, Ryszard Knop < > ryszard.k...@linux.intel.com> wrote: > > Hmm, is there a list/something I can generate to see which globals > > build tools emit? There are some more variables I'd happily get rid

Re: [edk2] [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle

2019-01-30 Thread Ard Biesheuvel
On Wed, 30 Jan 2019 at 17:05, Ryszard Knop wrote: > > Hmm, is there a list/something I can generate to see which globals > build tools emit? There are some more variables I'd happily get rid > of, eg if I could drop gSystemTable and others. > You can look at the contents of the various AutoGen.h

Re: [edk2] [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle

2019-01-30 Thread Ryszard Knop
Hmm, is there a list/something I can generate to see which globals build tools emit? There are some more variables I'd happily get rid of, eg if I could drop gSystemTable and others. Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > Remove duplicate

[edk2] [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle

2018-11-14 Thread Ard Biesheuvel
Remove duplicate definition of gImageHandle, which is emitted by the build tools as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/XGigUndiDxe/Init.c | 2 -- 1 file changed, 2 deletions(-) diff --git