I agree to use debug message. No need to interrupt boot process.
Thanks,
Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, February 12, 2019 8:48 AM
To: Fu, Siyuan
Cc: edk2-devel@lists.01.org; Mike Turner ; Ye,
Ting
Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid
Looks it's enough to add the warning debug message. I have sent the version 2
patch to do that.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, February 12, 2019 8:28 AM
> To: Wu, Jiaxin
> Cc: edk2-devel@lists.01.org; Mike Turner ;
> Ye, Ting
> Subject: RE:
Yes, Jiaxin. You should not use popup messages unless you 100 percent sure the
code is running in setup browser.
BestRegards
Fu Siyuan
> -Original Message-
> From: Mike Turner [mailto:michael.tur...@microsoft.com]
> Sent: Monday, February 11, 2019 11:10 PM
> To: Wu, Jiaxin ; Ye, Ting ;
Agree, thanks the comment. I will update the patch.
> -Original Message-
> From: Ye, Ting
> Sent: Monday, February 11, 2019 11:09 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Michael Turner ; Fu, Siyuan
>
> Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
>
Hi Jiaxin,
I agree we need start IPv6 stack no matter the configuration is valid or not.
However I would suggest to add more comments and pop up warning messages to let
user know we continue to start IPv6 stack without using previously saved
configuration.
Thanks,
Ting
-Original
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1448
This patch is to clean the invalid data and continue to start IP6 driver.
Cc: Michael Turner
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Signed-off-by: Michael Turner
---
6 matches
Mail list logo
