Re: [edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

Zhu, I see what you meant. Please ignore this patch. -Jaben > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, March 28, 2018 7:58 AM > To: Zhu, Yonghong ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: RE: [PATCH v1 1/4]

Re: [edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

Zhu, Given that the statement ~1 line above "PcdValue = PcdValue.strip()" will raise exception with a PcdValue that is a list, I don't see how this code could execute. I agree that it is likely that we think we want this, but something is wrong with it and I assumed that the current behavior

Re: [edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

Hi Jaben, Current we support flexible PCD value format, example: UINT64 type PCD can use {0x1, 2, 'A', UINT16(10), "B"} as its value, so the block can't be removed since it maybe a list after SplitPcdValueString function. https://bugzilla.tianocore.org/show_bug.cgi?id=541 is the feature

[edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

Since PcdValue is a string, no need to test it's type() for string Also remove the block used if it's a list (which is never is) Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey