Re: [edk2] [PATCH v1 13/27] BaseTools: replace string constants used for module types

Hi Jaben, two comments on this patch, please check it. thanks. 1. Check.py: it should use DT.SUP_MODULE_BASE 2. DataSection.py: need import DataType file, and update copyright year. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM

[edk2] [PATCH v1 13/27] BaseTools: replace string constants used for module types

replace raw strings in the code (note: except UPT) with constants. SUP_MODULE_BASE was 'BASE' SUP_MODULE_SEC was 'SEC' SUP_MODULE_PEI_CORE was 'PEI_CORE' SUP_MODULE_PEIM was 'PEIM' SUP_MODULE_DXE_CORE was 'DXE_CORE' SUP_MODULE_DXE_DRIVER was 'DXE_DRIVER' SUP_MODULE_DXE_RUNTIME_DRIVER was