subject:"\[edk2\] \[PATCH v1 2\/2\] BaseTools\: refactor and remove un\-needed use of .keys\(\) on dictionaries"

Re: [edk2] [PATCH v1 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

2018-04-17 Thread Zhu, Yonghong

Hi Jaben, In the misc.py file, it can't do below change. Otherwise it would cause build failure for: GlobalData.gSkuids = (self.SkuIdSet) GlobalData.gSkuids.remove('COMMON') AttributeError: 'OrderedDict' object has no attribute 'remove' -self.SkuIdSet = SkuIds.keys() +

[edk2] [PATCH v1 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

2018-04-12 Thread Jaben

sometimes just delete it. sometimes the loop needed .values() instead Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---