Re: [edk2] [PATCH v1 2/3] BaseTools: use predefined constants instead of local strings

2018-04-15 Thread Zhu, Yonghong
Hi Jaben, One comment on this patch, in InfBuildData.py, MetaFileParser.py and MetaFileTable.py add "from Common.DataType import TAB_ARCH_COMMON,TAB_ARCH_COMMON", the " TAB_ARCH_COMMON" was wrote twice, but in the code it use TAB_ARCH_COMMON and TAB_COMMON. Current it still build pass because

[edk2] [PATCH v1 2/3] BaseTools: use predefined constants instead of local strings

2018-04-10 Thread Jaben Carsey
Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 24 +--