Re: [edk2] [PATCH v2] NetworkPkg: Fix IpSec run into infinite loop issue

2015-08-27 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Friday, August 28, 2015 2:42 PM To: Fu, Siyuan; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [PATCH v2] NetworkPkg: Fix IpSec run into infinite loop issue Thanks Siyuan, I will revise the description before check in.

Re: [edk2] [PATCH v2] NetworkPkg: Fix IpSec run into infinite loop issue

2015-08-27 Thread Wu, Jiaxin
Thanks Siyuan, I will revise the description before check in. -Original Message- From: Fu, Siyuan Sent: Friday, August 28, 2015 2:37 PM To: Wu, Jiaxin; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [PATCH v2] NetworkPkg: Fix IpSec run into infinite loop issue Jiaxin The patch is goo

Re: [edk2] [PATCH v2] NetworkPkg: Fix IpSec run into infinite loop issue

2015-08-27 Thread Fu, Siyuan
Jiaxin The patch is good to me, but I suggest you do not use "-e" in the patch comments since it's just a flag of the IpsecConfig tool, not for the IpSec driver. You'd better describe what happened in IpSec when user use "-e" more clearly. Reviewed-by: Fu Siyuan -Original Message-

[edk2] [PATCH v2] NetworkPkg: Fix IpSec run into infinite loop issue

2015-08-27 Thread Jiaxin Wu
v2: * Update the copyright year and conditional judgment for removing. When use "-e" to edit SPD database, the corresponding SA entry will be updated to the sas list of the new SPD entry. But before that, all of them should be removed from the original sas list. If not, the list will be broken int