Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-10 Thread Jordan Justen
gt; Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> > Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 > > On 2015-12-09 20:20:31, Ni, Ruiyu wrote: > > r19177 check in breaks the build. Seems like the &quo

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-10 Thread Jordan Justen
car...@intel.com>; > edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> > Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 > > On 2015-12-09 22:47:42, Ni, Ruiyu wrote: > > more than

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-09 Thread Jordan Justen
As requested by Jaben, I committed these two ShellPkg patches before the rest of the series: r19176 | ShellPkg: Convert all .uni files to utf-8 r19177 | ShellPkg: Make 'dh' support showing all spec defined protocols. On 2015-12-04 14:14:46, Carsey, Jaben wrote: > Agreed. that works fine too...

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-09 Thread Ni, Ruiyu
an Justen Sent: Thursday, December 10, 2015 7:12 AM To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin@intel.com> Subject: Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-09 Thread Jordan Justen
c: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin@intel.com> > Subject: Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 > > As requested by Jaben, I committed these two ShellPkg patches before > the rest of the series: > > r191

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-09 Thread Ni, Ruiyu
ts.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin@intel.com> Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 On 2015-12-09 20:20:31, Ni, Ruiyu wrote: > r19177 check in breaks the build. Seems like the "#include"

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-06 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Justen, Jordan L Sent: Saturday, December 05, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Carsey, Jaben; Qiu, Shumin Subject: [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 To convert

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-04 Thread Carsey, Jaben
Agreed. that works fine too... > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 2:14 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > > Subject: RE:

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-04 Thread Jordan Justen
On 2015-12-04 13:16:34, Carsey, Jaben wrote: > There is a large change outstanding that was reviewed, but not yet > committed for updating DH to display additional protocols. Can you > commit that before this change? How about we do the opposite? Commit this one first, and then rebase that patch.