Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Brian J. Johnson
:59 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Hi Ruiyu, I had seen the other comments and

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Ni, Ruiyu
, 2016 10:52 AM To: Heyi Guo <heyi@linaro.org>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Heyi, I was not able to r

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Ard Biesheuvel
On 29 March 2016 at 08:26, Kinney, Michael D wrote: > Ard, > > Many handlers running at the same TPL are ok as long as each of the handlers > run for very short periods of time. Any event handlers that execute as > raised TPL for extended periods of time will impact

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Kinney, Michael D
gt; > Cc: Heyi Guo <heyi@linaro.org>; Ni, Ruiyu <ruiyu...@intel.com>; edk2- > de...@lists.01.org; Tian, Feng <feng.t...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate > b

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Ard Biesheuvel
gt;> >> Thanks and regards. >> >> Heyi >> >> >> >> >> 3. I forget about the FIFO depth change. The FIFO depth change >> >> doesn't cause >> the device >> >> >> >> path reinstallation. I agree we n

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Kinney, Michael D
gt;; Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate > by serial > IO mode > > > > On 03/25/2016

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Heyi Guo
inaro.org><mailto:heyi@linaro.org>; Tian, Feng <feng.t...@intel.com><mailto:feng.t...@intel.com>; Zeng, Star <star.z...@intel.com><mailto:star.z...@intel.com> Subject: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Calculate seri

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Ard Biesheuvel
he interval. > > > Regards, > Ray > > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Thursday, March 24, 2016 10:59 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Ni, Ruiyu
Guo [mailto:heyi@linaro.org] Sent: Thursday, March 24, 2016 10:59 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Heyi Guo
.@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> >Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode > >Hi Ruiyu, > >Many thanks for your review. > >For questions 2#, I tested equation #1 with copy-paste on

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Ni, Ruiyu
<feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; >Kinney, Michael D <michael.d.kin...@intel.com> >Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate >by serial IO mode > >Hi Ruiyu, > >Many thanks for your review. > &g

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Heyi Guo
-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Thursday, March 17, 2016 10:37 PM To: edk2-devel@lists.01.org Cc: Heyi Guo <heyi@linaro.org>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Ni, Ruiyu
<feng.t...@intel.com>; Zeng, >Star <star.z...@intel.com> >Subject: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by >serial IO mode > >Calculate serial input polling rate according to parameters from >serial IO mode as below, to fix potential

[edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-20 Thread Heyi Guo
Calculate serial input polling rate according to parameters from serial IO mode as below, to fix potential input truncation with fixed polling interval 0.02s. Polling interval (100ns) = FifoDepth * (ParityBits + StopBits + DataBits) * 10,000,000 / BaudRate However, as UEFI events will probably