On 2015/10/14 20:30, Laszlo Ersek wrote:
The "success" messages in FtwRestart(), FtwAbort(), and FtwGetLastWrite()
should be logged on EFI_D_INFO level. We can also unify their format with
the __FUNCTION__ macro.

Cc: Star Zeng <star.z...@intel.com>
Cc: Liming Gao <liming....@intel.com>
Cc: Drew Jones <drjo...@redhat.com>
Suggested-by: Star Zeng <star.z...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
---

Notes:
     v2:
     - new in v2; modify three more DEBUGs [Star]

  MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Star Zeng <star.z...@intel.com>

Thanks to do that.
Star


diff --git a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.c 
b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.c
index 7a6c377..2e3e8c7 100644
--- a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.c
+++ b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.c
@@ -720,7 +720,7 @@ FtwRestart (
      return EFI_ABORTED;
    }

-  DEBUG ((EFI_D_ERROR, "Ftw: Restart() success \n"));
+  DEBUG ((EFI_D_INFO, "%a(): success\n", __FUNCTION__));
    return EFI_SUCCESS;
  }

@@ -775,7 +775,7 @@ FtwAbort (

    FtwDevice->FtwLastWriteHeader->Complete = FTW_VALID_STATE;

-  DEBUG ((EFI_D_ERROR, "Ftw: Abort() success \n"));
+  DEBUG ((EFI_D_INFO, "%a(): success\n", __FUNCTION__));
    return EFI_SUCCESS;
  }

@@ -886,7 +886,7 @@ FtwGetLastWrite (
      Status = EFI_SUCCESS;
    }

-  DEBUG ((EFI_D_ERROR, "Ftw: GetLasetWrite() success\n"));
+  DEBUG ((EFI_D_INFO, "%a(): success\n", __FUNCTION__));

    return Status;
  }


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to