Re: [edk2] [PATCH v3 4/5] MdeModulePkg/DxeNetLib: Fix negative value left shift

2017-09-28 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Hao A Sent: Thursday, September 28, 2017 12:32 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Shi, Steven ; Fu, Siyuan ; Ye, Ting ;

Re: [edk2] [PATCH v3 4/5] MdeModulePkg/DxeNetLib: Fix negative value left shift

2017-09-28 Thread Fu, Siyuan
Looks good to me. Reviewed-by: Fu Siyuan -Original Message- From: Wu, Hao A Sent: Thursday, September 28, 2017 12:32 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Shi, Steven ; Fu, Siyuan ; Ye, Ting

Re: [edk2] [PATCH v3 4/5] MdeModulePkg/DxeNetLib: Fix negative value left shift

2017-09-27 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Wu, Hao A > Sent: Thursday, September 28, 2017 12:32 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Shi, Steven ; > Fu, Siyuan ; Ye, Ting

[edk2] [PATCH v3 4/5] MdeModulePkg/DxeNetLib: Fix negative value left shift

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=698 Within function NetRandomInitSeed(), left shift a negative value is used in: "~Time.Hour << 24" which involves undefined behavior. Since Time.Hour is of type UINT8 (range from 0 to 23), hence ~Time.Hour will be a negative value (of type