Re: [edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

2018-07-12 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, July 11, 2018 5:46 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Carsey, Jaben > Subject: RE: [Patch] ShellPkg/TftpDynamicCommand: Fix the potential > assertion and memory leak issue. >

Re: [edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

2018-07-11 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, July 12, 2018 8:44 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan ; Carsey, Jaben > Subject: [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion > and memory leak

[edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

2018-07-11 Thread Jiaxin Wu
From: Jiaxin Wu This patch is to fix the issue reported from https://bugzilla.tianocore.org/show_bug.cgi?id=925. DataSize variable was not assigned the value if ShellOpenFileByName returns error. In the such a case, it should not be used to FreePages. Instead, DataSize can be used to record the

[edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

2018-04-25 Thread Jiaxin Wu
This patch is to fix the issue reported from https://bugzilla.tianocore.org/show_bug.cgi?id=925. DataSize variable was not assigned the value if ShellOpenFileByName returns error. In the such a case, it should not be used to FreePages. Instead, DataSize can be used to record the file size once Do