Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Siyuan, I'm not prefer to handle the link local src address selecting automatically to make things more complexity. Just follow the guide that src address is required when pinging a link-local address no matter multiple or single interface in platform. But, I will update the patch to add a

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Hi, Jiaxin A interface with only link local address should be allowed as the src if the dest is also an link local address, right? And the 2 if conditions in line 1052 is better to change to a "if (UnspecifiedSrc) else ..." so it's more readable. If (UnspecifiedSrc &&

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Hello Jiaxin, Sorry for the delay in reply - I was on holidays. I will check this patch at my end and will soon get back with the results. Regards, Bhupesh > -Original Message- > From: Wu, Jiaxin [mailto:jiaxin...@intel.com] > Sent: Thursday, April 21, 2016 7:35 AM > To: Bhupesh Sharma

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Hello Bhupesh, Any test result or feedback for this patch? Thanks. Jiaxin > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, April 20, 2016 1:10 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: David Van Arnem ; Bhupesh Sharma >

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Jiaxin > Sent: Monday, April 18, 2016 6:52 PM > To: edk2-devel@lists.01.org > Cc: David Van Arnem ; Bhupesh Sharma > ; Carsey, Jaben ;

[edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

This patch is used to support no source IP specified case while multiple NICs existed in the platform. The command will select the first both connected and configured interface automatically. Cc: David Van Arnem Cc: Bhupesh Sharma Cc: Jaben Carsey