Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-03 Thread Ni, Ruiyu
hers look good to me > > > > Reviewed-by: Feng Tian <feng.t...@intel.com> > > > > Thanks > > Feng > > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > > Ruiyu > > Sent: Mo

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-03 Thread Kinney, Michael D
] On Behalf Of Ni, > Ruiyu > Sent: Monday, November 30, 2015 10:12 > To: Kinney, Michael D > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver > > Mike, > Could you please review whether the PCD structure defined as below

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-03 Thread Kinney, Michael D
for Offset field to be consistent with PciIo protocol > > definition. > > > > Others look good to me > > > > Reviewed-by: Feng Tian <feng.t...@intel.com> > > > > Thanks > > Feng > > > > -Original Message- > > From: ed

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-02 Thread Tian, Feng
Monday, November 30, 2015 10:12 To: Kinney, Michael D Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver Mike, Could you please review whether the PCD structure defined as below is good? +#pragma pack(1) +/// +/// PcdPciSerialParameters contains zero o