subject:"\[edk2\] \[Patch 2\/2\] UefiCpuPkg\/SmmFeatureLib\: Check SmmFeatureControl by Code_Access_Chk"

Re: [edk2] [Patch 2/2] UefiCpuPkg/SmmFeatureLib: Check SmmFeatureControl by Code_Access_Chk

2015-11-18 Thread Kinney, Michael D

Reviewed-by: Michael Kinney Mike -Original Message- From: Fan, Jeff Sent: Tuesday, November 17, 2015 10:45 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Yao, Jiewen Subject: [Patch 2/2]

Re: [edk2] [Patch 2/2] UefiCpuPkg/SmmFeatureLib: Check SmmFeatureControl by Code_Access_Chk

2015-11-18 Thread Yao, Jiewen

Reviewed by: jiewen@intel.com -Original Message- From: Fan, Jeff Sent: Wednesday, November 18, 2015 2:45 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Yao, Jiewen Subject: [Patch 2/2] UefiCpuPkg/SmmFeatureLib: Check SmmFeatureControl by Code_Access_Chk Bit

[edk2] [Patch 2/2] UefiCpuPkg/SmmFeatureLib: Check SmmFeatureControl by Code_Access_Chk

2015-11-17 Thread Jeff Fan

Bit SMM_Code_Access_Chk (SMM-RO) in MSR_SMM_MCA_CAP is defined in SDM. If set to 1 indicates that the SMM code access restriction is supported and the MSR_SMM_FEATURE_CONTROL is supported. If this bit is not set, we needn't to access register SmmFetureControl. Otherwise, #GP exception may happen.