After talked with Siyuan, we agree to use the int 0-1 value instead of Boolean
type so as to keep the same coding style in TcpInput.c.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, December 27, 2017 11:03 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, December 26, 2017 2:50 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wang, Fan
; Wu, Jiaxin
Subject: [Patch 3/3] NetworkPkg/TcpDxe: Check TCP payload for release version.
TCP payload check is implem
Hi, Jiaxin
I think it's better to return a Boolean type than int 0-1 value in
TcpTrimSegment().
Other part of good to me.
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, December 26, 2017 2:50 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyu
TCP payload check is implemented by TcpVerifySegment(), but all the function
calls of TcpVerifySegment() are placed in ASSERT(), which is only valid for
debug version:
ASSERT (TcpVerifySegment (Nbuf) != 0);
This patch is to enable the check for release version.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: W
4 matches
Mail list logo
