Re: [edk2] [Patch V2] BaseTools: Clean up not used code in BuildClassObject

2018-08-14 Thread Carsey, Jaben
I believe that we should try to move more towards specific imports rather than import * or entire modules. I would therefore prefer we do the OrderedDict change in the other direction and remove the collections.OrderedDict items. That being said, opinions... The code is still better with this

[edk2] [Patch V2] BaseTools: Clean up not used code in BuildClassObject

2018-08-13 Thread Yonghong Zhu
V2: Add back "from Common.DataType import *" 1. Remove some import statement that are not used. 2. Remove the Type value in the LibraryClassObject because we don't actually use it. Cc: Liming Gao Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong