Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-13 Thread Guo Heyi
, Eric <eric.d...@intel.com>; edk2- > > de...@lists.01.org; Wu, Jiaxin <jiaxin...@intel.com>; Fu, Siyuan > > <siyuan...@intel.com>; Zeng, Star <star.z...@intel.com> > > Subject: Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about > > IcmpErrorList

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-12 Thread Wu, Jiaxin
nks, > > > > Gary (Heyi Guo) > > > > > >Thanks, > > >Jiaxin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >>-Original Message- >

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-11 Thread Wu, Jiaxin
m> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; edk2- > de...@lists.01.org; Wu, Jiaxin <jiaxin...@intel.com>; Fu, Siyuan > <siyuan...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: Re: [edk2] MdeModulePkg/UefiPxeBcDxe:

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-11 Thread Guo Heyi
boun...@lists.01.org] On Behalf Of > >>Heyi Guo > >>Sent: Thursday, December 7, 2017 4:18 PM > >>To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org > >>Cc: Ni, Ruiyu <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>;

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-07 Thread Heyi Guo
rsday, December 7, 2017 4:18 PM To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] MdeModule

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-07 Thread Wu, Jiaxin
t;; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Dong, > Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about > IcmpErrorListenHandler in PxeBcI

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-07 Thread Heyi Guo
Hi Jiaxin, Thanks for your reply. You say "IcmpErrorRcvToken is only used to get ICMP error from IP layer", does that mean only ICMP error packets will go to IcmpErrorListenHandler? If it is the case, how do we make it? I can only find a simple Ip4->Receive is called to receive IP4

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

2017-12-06 Thread Wu, Jiaxin
Hi Gary, IcmpErrorRcvToken is only used to get ICMP error from IP layer, and the data will be copied to Mode->IcmpError. So, I think the RxData should be recycled. Besides, EFI_IP_PROTO_ICMP should be also checked in the call function but currently it's not: if (!EFI_IP4_EQUAL