Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

day, November 23, 2017 2:44 PM > > To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > > <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > > Subject: Re: [edk2] [PATCH v2 7

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

;star.z...@intel.com> > Subject: Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add > stack switch support > > 1.1) Got your point. I'll add dummy function in this patch. > 1.2) Yep, we're on the same page. > 1.3) Here's my opinion: > > Actually almost all M

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

rg<mailto:edk2-devel@lists.01.org> Cc: Kinney, Michael D; Dong, Eric; Zeng, Star Subject: Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support 1.1) Got your point. I'll add dummy function in this patch. 1.2) Yep, we're on the same page. 1.3) Here's my opini

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

to the platform whose CPU driver does not have > such > > > InitializeCpuExceptionStackSwitchHandlers() call? > > > Have you tested that condition? > > > > > > Thank you > > > Yao Jiewen > > > > > > > -Original Message- > >

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

1.1) Got your point. I'll add dummy function in this patch. 1.2) Yep, we're on the same page. 1.3) Here's my opinion: Actually almost all MP code has such assumption: any AP configuration will copy from BSP. If we allow AP to call InitializeCpuExceptionHandlers(), we have to do a lot of other

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

gt; > > Jiewen > > > Sent: Thursday, November 23, 2017 1:50 PM > > > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > > > <eric.d...@intel.com>; Zeng,

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Here is my thought for 1) 1.1) We must provide the InitializeCpuExceptionStackSwitchHandlers() implementation in Pei instance and Smm instance. The basic requirement is a library instance must provide symbol for functions declared in header file. It is ok to return unsupported. But we MUST

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

3, 2017 1:50 PM > > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > > <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > > Subject: Re: [edk2] [PATCH v2 7/

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

> -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 1:50 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric ; > Kinney, Michael D > Subject:

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

<eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add > stack switch support > > Some thought: > > 1) I found InitializeCpuExceptionStackSwitchHandlers() is only implemented in > Dx

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Some thought: 1) I found InitializeCpuExceptionStackSwitchHandlers() is only implemented in DxeException.c. What about Pei/Smm instance? I think it is OK to not implement it at this moment. But we need make sure no architecture issue if we want to enable it some time later. 2) #define