[edk2] [Patch 4/5] NetworkPkg: Add assert for buffer pointer from DHCP driver.

The PxeBcDhcp4CallBack() is provided for DHCP driver to invoke packet check during DHCP process, the DHCP driver should make sure Packet and NewPacket has meaningful value. This patch adds assert for this. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan

[edk2] [Patch 2/5] NetworkPkg: Check allocated buffer pointer before use.

Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 5 - 1 file changed, 4 insertions(+), 1

[edk2] [Patch 0/5] Refine PXE driver code logic

See each patch file for details. Fu Siyuan (5): NetworkPkg: Abort the PXE process if DHCP has been started by other instance. NetworkPkg: Check allocated buffer pointer before use. NetworkPkg: Fix memory leak problem in PXE driver. NetworkPkg: Add assert for buffer pointer from DHCP

[edk2] [Patch 5/5] NetworkPkg: Update PXE driver to check for NULL pointer before use it.

This patch is to fix the issue that dereferencing of "This" (EFI_LOAD_FILE_PROTOCOL) in EfiPxeLoadFile() is happening before the NULL check. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch 1/5] NetworkPkg: Abort the PXE process if DHCP has been started by other instance.

PXE need to use extended DHCP options and check received offers in callback function, so there is no need to continue the PXE process if DHCP driver has been started by other instance but not PXE driver itself. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan

[edk2] [Patch 3/5] NetworkPkg: Fix memory leak problem in PXE driver.

Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 27 +--

Re: [edk2] [Patch 0/5] Refine PXE driver code logic

Patch Series Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Tuesday, January 2, 2018 10:58 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/5] Refine PXE driver code logic

Re: [edk2] [Patch 0/5] Refine PXE driver code logic

Hi Siyuan, Some of these problems also exist in the MdeModulePkg/Universal/Network/UefiPxeBcDxe/. Is there a plan to fix them there as well, or will the MdeModulePkg copy of the drivers be removed sometime in the near future? Thanks, Sriram. -Original Message- From: Subramanian,

[edk2] [Patch 2/2] NetworkPkg/IScsiDxe: Remove unnecessary close for ExitBootServiceEvent.

The close for ExitBootServiceEvent in IScsiOnExitBootService callback function is unnecessary since it will be closed in ISCSI driver stop() function, which is invoked when the transition from BS to RT. This issue is recorded at https://bugzilla.tianocore.org/show_bug.cgi?id=742. Cc: Ye Ting

[edk2] [Patch 0/2] IScsiDxe: Remove unnecessary close for ExitBootServiceEvent.

The close for ExitBootServiceEvent in IScsiOnExitBootService callback function is unnecessary since it will be closed in ISCSI driver stop() function, which is invoked when the transition from BS to RT. This issue is recorded at https://bugzilla.tianocore.org/show_bug.cgi?id=742. Cc: Ye Ting

[edk2] [Patch 1/2] MdeModulePkg/IScsiDxe: Remove unnecessary close for ExitBootServiceEvent.

The close for ExitBootServiceEvent in IScsiOnExitBootService callback function is unnecessary since it will be closed in ISCSI driver stop() function, which is invoked when the transition from BS to RT. This issue is recorded at https://bugzilla.tianocore.org/show_bug.cgi?id=742. Cc: Ye Ting

Re: [edk2] [Patch 5/5] NetworkPkg: Update PXE driver to check for NULL pointer before use it.

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Tuesday, January 2, 2018 10:58 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Wang Fan ; Wu

Re: [edk2] [Patch] [Patch] MdeModulePkg: Add error handling when IP address is Class E

Reviewed-by: Jiaxin Wu Please update the copyright before commit the patch. Thanks, Jiaxin > -Original Message- > From: Wang, Fan > Sent: Tuesday, January 2, 2018 10:45 AM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Wu, Jiaxin

Re: [edk2] [Patch 2/5] NetworkPkg: Check allocated buffer pointer before use.

On Tue, Jan 02, 2018 at 01:27:41PM +0800, Fu Siyuan wrote: > Cc: Ye Ting > Cc: Wu Jiaxin > Cc: Wang Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Fu Siyuan > --- >

Re: [edk2] [Patch 0/5] Refine PXE driver code logic

Series Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Tuesday, January 2, 2018 1:28 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/5] Refine PXE driver code logic

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

On 12/26/2017 2:50 PM, Guo Heyi wrote: Hi Ard, Ray, Have we come to the final conclusion? Or are we still waiting for more comments on this? Heyi, I think you can send out a draft version of changes for better understanding. Thanks, Gary On Thu, Dec 21, 2017 at 10:07:51AM +, Ard

[edk2] [Patch] DSC Spec: Fix a typo error "enty" to "entry"

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_dsc_overview/23_[defines]_section_processing.md | 2 +-

[edk2] [Patch] [Patch] MdeModulePkg: Add error handling when IP address is Class E

From: Wang Fan The Dhcp4.TransmitReceive() API should be able to use at any time according to UEFI spec. While in classless addressing network, the netmask must be explicitly provided together with the station address. But if the DHCP instance haven't be configured with a