We'd better have a bugzilla to track this change.
And since it will require platform change in platform dsc to add the new
library mapping, we need add notes in
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes.
Thanks,
Star
On 2019/1/4 2:28, Ard Biesheuvel wrote:
On 2019/1/10 15:33, Ard Biesheuvel wrote:
On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote:
Hi Ard,
Another minor feedback.
On 2019/1/10 14:47, Zeng, Star wrote:
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
Implement a new version of the fault tolerant
On 01/10/19 07:03, karunakarpoosapa...@dell.com wrote:
> Hi All,
>
> I agree with providing the support like "FixedAtBuild PCD in INF". And we
> need to modify or provide support in BaseTools to support this feature.
>
> There are more use cases or flexibility to developer if we support
>
On 01/10/19 08:59, Zeng, Star wrote:
> On 2019/1/10 15:33, Ard Biesheuvel wrote:
>> On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote:
>>>
>>> Hi Ard,
>>>
>>> Another minor feedback.
>>>
>>> On 2019/1/10 14:47, Zeng, Star wrote:
Hi Ard,
Some minor feedback added inline.
On
Star,
I think moving it to MdePkg would be better, just like UefiDriverEntryPoint. A
dummy
one may be not necessary.
Regards,
Jian
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng,
> Star
> Sent: Thursday, January 10, 2019 4:00 PM
>
On 01/10/19 05:51, Ni, Ray wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Wednesday, January 9, 2019 6:35 PM
>> To: Dong, Eric
>> Cc: Brian J. Johnson ; Yao, Jiewen
>> ; Ni, Ray ; edk2-
>> de...@lists.01.org; Kinney, Michael D
>> Subject: Re: [edk2] [Patch 1/3]
Introduce public functions Base64Encode and Base64Decode.
https://bugzilla.tianocore.org/show_bug.cgi?id=1370
v2:1.Remove some white space.
2.Add unit test with test vectors in RFC 4648.
https://github.com/shenglei10/edk2/tree/encode_test
On 2019-01-07 20:27, Laszlo Ersek wrote:
On 01/04/19 15:02, Karin Willers wrote:
G'Day!
I'm trying to get networking under edk2 up and running. I tried
AppPkg/Applications/Sockets/RawIp4Tx
under OVMF. The raw packet is sent out on the network, but the
application never returns from the
socket
Pushed them at 0290fca..15666b
> -Original Message-
> From: Ashish Singhal [mailto:ashishsin...@nvidia.com]
> Sent: Thursday, January 10, 2019 11:33 PM
> To: Gao, Liming ; Kinney, Michael D
> ; edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: RE: [PATCH v4 0/2] Provide
I have same question. What flexibility is expected in INF? I see one request in
[Depex] section. So, PCD support in [Depex] is added.
Edk2 INF is used to describe the source code behavior. If the source uses
Ppi/Protocol/Guid/Pcd, these information are always required to be described in
INF
There is one additional constraint for adding conditionals
to INF files.
The UEFI Distribution Packaging Specification defines a
format to share package and module content in a standard
format and uses an XML schema for the metadata. We need to
be able to convert between INF <--> XML and DEC
Thanks Liming. I have files BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=1444 to update UEFI drivers to
use new APIs. I have not assigned it to anyone as there are many drivers across
packages that need to be looked at. I would try to fix the ones I hit an issue
with.
Over the weekend
Thanks everyone.
-Original Message-
From: Gao, Liming
Sent: Thursday, January 10, 2019 8:39 AM
To: Ashish Singhal ; Kinney, Michael D
; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol
uninstallation
Pushed them
Is this in a script file? I don't remember how "comments" work on raw command
lines where the user types them.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> krishnaLee
> Sent: Wednesday, January 09, 2019 10:13 PM
> To:
On Thu, 10 Jan 2019 at 14:03, Laszlo Ersek wrote:
>
> On 01/10/19 08:59, Zeng, Star wrote:
> > On 2019/1/10 15:33, Ard Biesheuvel wrote:
> >> On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote:
> >>>
> >>> Hi Ard,
> >>>
> >>> Another minor feedback.
> >>>
> >>> On 2019/1/10 14:47, Zeng, Star wrote:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Li, Songpeng
> Sent: Wednesday, January 09, 2019 6:54 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Wu, Jiaxin
> Subject: [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing
> method in tftp
>
Ashish:
The MdePkg change is good to me. Reviewed-by: Liming Gao
Please help submit another BZ to update UefiDriver to uninstall protocol when
failure with new APIs.
If Siyuan/Jiaxin has no other comments, I will help push this patch set.
Thanks
Liming
> -Original Message-
>
Move IsFieldValuieAnArray from Common.Misc to this file.
There were no other consumers of the function.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py| 18 +--
Move PackRegistryFormatGuid logic from Common.Misc to this file.
There were no other consumers of the function.
As it is one line, just replace the logic without the separate function.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben
Use UEFILib provided protocol uninstallation abstraction
instead of direct API for a proper cleanup.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1444
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
NetworkPkg/DnsDxe/DnsDriver.c | 30
Move SplitOption and ConvertStringToByteArray from Common.Misc to this file.
There were no other consumers of the functions.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 77
Move DataDump and DataRestore from Common.Misc to this file.
There were no other consumers of these 2 functions.
Import threading since that module is used in build.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=42
Many shared functions are not used by more than one consumer.
Move them local to consumer until the use arises for sharing.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
Move ProtocolValue and PpiValue from Common.Misc to this file.
There were no other consumers of these 2 functions.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py| 38
On 11/14/18 19:34, stephano wrote:
> We are currently researching several different options to help make
> contributing to TianoCore easier for the community. A big part of this
> effort will be enabling pull requests and allowing for a more
> customizable code review process.
>
> I am looking
Hi All,
Thank you very much for your valuable thoughts.
Below are my concerns/thoughts, Could you please help on
1. Is there any module or INF already using FeatureFlagExpression feature
support in current edk2 source?
2. If not, could you please help in providing more detailed spec/Doc to
((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
In above code, Facs->OspmFlags should be used instead.
EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
Control Structure Flags field, not in Firmware Control Structure
Feature Flags.
BZ:
((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
In above code, Facs->OspmFlags should be used instead.
EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
Control Structure Flags field, not in Firmware Control Structure
Feature Flags.
BZ:
((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
In above code, Facs->OspmFlags should be used instead.
EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
Control Structure Flags field, not in Firmware Control Structure
Feature Flags.
Update all related code to use correct
Agreed. That seems like a bug that needs a Bugzilla filed.
My question is if the comment character is valid on a command line typed in
versus in a script file.
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Thursday, January 10, 2019 3:34 PM
>
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, January 02, 2019 4:44 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTools: Report Error if use SET in Dsc
>
>Build tool do not support SET syntax in DSC.
>
>If the SET
On 2019/1/11 0:23, Ard Biesheuvel wrote:
On Thu, 10 Jan 2019 at 14:03, Laszlo Ersek wrote:
On 01/10/19 08:59, Zeng, Star wrote:
On 2019/1/10 15:33, Ard Biesheuvel wrote:
On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote:
Hi Ard,
Another minor feedback.
On 2019/1/10 14:47, Zeng, Star
https://bugzilla.tianocore.org/show_bug.cgi?id=1449
This patch enable build tools to recognize that
when two given files have the same GUID, file path and ARCH in Dsc,
The later one's definition will be used.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc:
Jaben,
The shell does not parse properly (my opinion) in some instances.
That is one of the reasons I wrote a separate parser for the shell I
maintain here at Dell.
One of the areas I feel the parsing is wrong is when an unescaped "#"
is inside a quoted string:
FS0:\> echo "This should #
Looks good to me.
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: Ashish Singhal [mailto:ashishsin...@nvidia.com]
> Sent: Friday, January 11, 2019 3:27 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin ;
> Ashish Singhal
> Subject: [PATCH] NetworkPkg:
Jaben,
>My question is if the comment character is valid on a command line typed in
>versus in a script file.
Maybe when parsing a script file,it should record a in-script-file-status,
and this command [ testapp.efi #abc ] in command line(not in a script file)
maybe looked as two argument
Reviewed-by: Wu Jiaxin
> -Original Message-
> From: Li, Songpeng
> Sent: Thursday, January 10, 2019 10:54 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Wu, Jiaxin
> Subject: [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing
> method in tftp
>
> REF:
37 matches
Mail list logo
