Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread Laszlo Ersek
On 08/04/15 05:16, Ni, Ruiyu wrote: No. I forgot to emphasize that I only tested the QEMU boot timeout feature after changing the QemuBootOrderLib. I don't know how to test the boot order feature. This series, on the surface, seems intrusive and to have potential to cause many

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread Laszlo Ersek
On 08/04/15 12:53, Laszlo Ersek wrote: No matter how carefully we review and test the new code, something will inevitably break, This wasn't meant as lack of trust in your code; it's just that there are many cases and corner cases in the related OVMF code, and it's quite hard to test them all.

Re: [edk2] BaseTools features: multiple workspaces

2015-08-04 Thread Laszlo Ersek
On 08/03/15 19:35, Jordan Justen wrote: On 2015-08-03 02:08:14, Gao, Liming wrote: Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. I know you originally suggested to use WORKSPACE,

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread David Woodhouse
On Tue, 2015-08-04 at 03:16 +, Ni, Ruiyu wrote: I forgot to emphasize that I only tested the QEMU boot timeout feature after changing the QemuBootOrderLib. I don't know how to test the boot order feature. For the SeaBIOS CSM, can you tell me how to test or test it for me if it's very

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread Laszlo Ersek
On 08/04/15 12:42, David Woodhouse wrote: On Tue, 2015-08-04 at 03:16 +, Ni, Ruiyu wrote: I forgot to emphasize that I only tested the QEMU boot timeout feature after changing the QemuBootOrderLib. I don't know how to test the boot order feature. For the SeaBIOS CSM, can you tell me how

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread David Woodhouse
On Tue, 2015-08-04 at 13:07 +0200, Laszlo Ersek wrote: On 08/04/15 12:42, David Woodhouse wrote: Then (if the BDS gets it right) you should be able to boot legacy targets as well as native UEFI targets. Okay, if you don't have your guests any longer, I guess I can add this to the end of

[edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Ard Biesheuvel
ARM BDS support in ArmVirtQemu has been broken since SVN r17969 (ArmPkg/BdsLib: Remove Linux loader from BdsLib) dated July 14th. Instead of fixing this, let's get rid of the ARM BDS and LinuxLoader altogether: they violate both the UEFI spec and the arm64 Linux boot protocol, and lack the level

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Sharma Bhupesh
-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 04, 2015 2:36 PM On 08/04/15 10:38, Sharma Bhupesh wrote: -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, August 04, 2015 2:01 PM On 4

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Ard Biesheuvel
On 4 August 2015 at 11:21, Sharma Bhupesh bhupesh.sha...@freescale.com wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 04, 2015 2:36 PM On 08/04/15 10:38, Sharma Bhupesh wrote: -Original Message- From: Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
On 08/04/15 11:44, Zeng, Star wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, August 4, 2015 5:25 PM To: Zeng, Star; Justen, Jordan L Cc: Paolo Bonzini; edk2-de...@ml01.01.org; Yao, Jiewen Subject: Re:

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
Star, On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is FALSE by default. diff --git a/MdeModulePkg/MdeModulePkg.dec

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Laszlo Ersek
On 08/04/15 10:38, Sharma Bhupesh wrote: -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, August 04, 2015 2:01 PM On 4 August 2015 at 10:07, Sharma Bhupesh bhupesh.sha...@freescale.com wrote: With the EFI_STUB becoming more or less mandatory

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
On 08/04/15 10:59, Zeng, Star wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 4:34 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Ard Biesheuvel
On 4 August 2015 at 10:54, Laszlo Ersek ler...@redhat.com wrote: On 08/04/15 09:57, Ard Biesheuvel wrote: LinuxLoader has been split off from the ARM BDS into a separate EFI application. Because we never included this application into the ArmVirtPkg platforms, its ARM BDS builds have

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Ard Biesheuvel
On 4 August 2015 at 10:07, Sharma Bhupesh bhupesh.sha...@freescale.com wrote: I have a related question. The EFI stub documentation (see [1]), seems to suggest that we have the support to boot the kernel Image, DTB and Rootfs when supplied as separate images to the EFI stub. However, other

[edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build

2015-08-04 Thread Ard Biesheuvel
The ARM build still needs an intermediate loader to boot Linux, since ARM/Linux has no builtin UEFI boot stub (yet). So add the LinuxLoader UEFI application to the FV, and enable the FvSimpleFileSystemDxe driver so that we can invoke the Linux loader from the shell, e.g., Shell linuxloader

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Laszlo Ersek
On 08/04/15 14:40, Ard Biesheuvel wrote: ARM BDS support in ArmVirtQemu has been broken since SVN r17969 (ArmPkg/BdsLib: Remove Linux loader from BdsLib) dated July 14th. Instead of fixing this, let's get rid of the ARM BDS and LinuxLoader altogether: they violate both the UEFI spec and the

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Ard Biesheuvel
On 4 August 2015 at 16:50, Laszlo Ersek ler...@redhat.com wrote: On 08/04/15 16:34, Ard Biesheuvel wrote: On 4 August 2015 at 15:35, Laszlo Ersek ler...@redhat.com wrote: [...] I propose the following: - The Xen hit should be removed as a separate patch, as it has never been useful. (The

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Sharma Bhupesh
-Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, August 04, 2015 2:01 PM On 4 August 2015 at 10:07, Sharma Bhupesh bhupesh.sha...@freescale.com wrote: I have a related question. The EFI stub documentation (see [1]), seems to suggest that

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Zeng, Star
-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 4:34 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support Star, On 07/31/15 14:22, Star Zeng

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Zeng, Star
-Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, August 4, 2015 5:25 PM To: Zeng, Star; Justen, Jordan L Cc: Paolo Bonzini; edk2-de...@ml01.01.org; Yao, Jiewen Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Laszlo Ersek
On 08/04/15 11:21, Sharma Bhupesh wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 04, 2015 2:36 PM On 08/04/15 10:38, Sharma Bhupesh wrote: -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday,

[edk2] [PATCH 3/3] ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build

2015-08-04 Thread Ard Biesheuvel
The ARM build still needs an intermediate loader to boot Linux, since ARM/Linux has no builtin UEFI boot stub (yet). So add the LinuxLoader UEFI application to the FV, and enable the FvSimpleFileSystemDxe driver so that we can invoke the Linux loader from the shell, e.g., Shell linuxloader

[edk2] [PATCH 0/3] ArmVirtPkg: drop support for the ARM BDS

2015-08-04 Thread Ard Biesheuvel
This series is a followup to the patches 'ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default' and 'ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build' that I sent out earlier today. (The former was itself a replacement for 'ArmVirtPkg: align ARM BDS build with

[edk2] [PATCH 1/3] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Ard Biesheuvel
ARM BDS support in ArmVirtQemu has been broken since SVN r17969 (ArmPkg/BdsLib: Remove Linux loader from BdsLib) dated July 14th. Instead of fixing this, let's get rid of the ARM BDS and LinuxLoader altogether: they violate both the UEFI spec and the arm64 Linux boot protocol, and lack the level

[edk2] [PATCH 2/3] ArmVirtPkg/ArmVirtXen: remove unused PcdFirmwareVendor PCD

2015-08-04 Thread Ard Biesheuvel
The PcdFirmwareVendor PCD was never used on this platform, since it has never supported the ARM BDS. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- ArmVirtPkg/ArmVirtXen.dsc | 1 - 1 file changed, 1 deletion(-)

Re: [edk2] [PATCH 4/9] ArmVirtPkg: revert ArmVirtPkg: add QemuFwCfgToPcdDxe

2015-08-04 Thread Ard Biesheuvel
On 31 July 2015 at 20:40, Laszlo Ersek ler...@redhat.com wrote: This reverts git commit d2733aa9 (SVN r18042), because it is empty now. The original problem: Many universal DXE drivers in edk2 can be controlled by setting dynamic PCDs. Such a PCD must be set before the consumer DXE driver

Re: [edk2] [PATCH 6/9] ArmVirtPkg/ArmVirtQemu.dsc: set default for PcdQemuSmbiosValidated

2015-08-04 Thread Ard Biesheuvel
On 31 July 2015 at 20:40, Laszlo Ersek ler...@redhat.com wrote: The upcoming OvmfPkg patches will implicitly affect the ArmVirtQemu.dsc build, necessitating a default value for the new dynamic PcdQemuSmbiosValidated. Add it. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Cc: Wei Huang

Re: [edk2] HID descriptor parsing

2015-08-04 Thread Tian, Feng
UsbKbDxe driver in MdeModulePkg/Bus/Usb handles usb key board devices. Note we don’t parse its HID descriptor in this driver, we only use SET_REPORT request to enable Keyboard’s LED. If you need to parse HID items, you can refer to the logic in usb mouse driver and write a new one. PS:

[edk2] [patch] NetworkPkg: Fix assert caused by wrong parameter in AsciiStrCpyS()

2015-08-04 Thread Zhang Lubo
The 2nd parameter in AsciiStrCpyS() should be the max available memory of the destination. Cc: Fu Siyuansiyuan...@intel.com Cc: Ye Tingting...@intel.com CC: Wu Jiaxin jiaxin...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo lubo.zh...@intel.com ---

Re: [edk2] How to update an App Lib dependency ?

2015-08-04 Thread Tian, Feng
Why do you need to do the copy operation? EDKII Build system could ensure this dependency. Please read EDKII module writer's guide at first (https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-User-Documentation) Thanks Feng -Original Message- From: edk2-devel

Re: [edk2] [PATCH] Check arguments for PrintLib format format string

2015-08-04 Thread Scott Duplichan
Laszlo Ersek [mailto:ler...@redhat.com] wrote: ]Sent: Tuesday, August 04, 2015 09:01 AM ]To: Scott Duplichan sc...@notabs.org ]Cc: 'edk2-devel@lists.01.org' edk2-de...@ml01.01.org; 'Andrew Fish' af...@apple.com ]Subject: Re: [edk2] [PATCH] Check arguments for PrintLib format format string ] ]On

[edk2] How to update an App Lib dependency ?

2015-08-04 Thread Shubha Ramani
Hello there. I have built a lib under C:\edk2\MyWorkspace\MdeModulePkg\Library and an Application which consumes that library under   C:\edk2\MyWorkspace\MdeModulePkg\Application. If I change code in the lib, how can I make sure that the rebuilt App gets the latest lib ? I usually manuallycopy

Re: [edk2] [PATCH 3/3] ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build

2015-08-04 Thread Ard Biesheuvel
On 4 August 2015 at 17:21, Ard Biesheuvel ard.biesheu...@linaro.org wrote: The ARM build still needs an intermediate loader to boot Linux, since ARM/Linux has no builtin UEFI boot stub (yet). So add the LinuxLoader UEFI application to the FV, and enable the FvSimpleFileSystemDxe driver so

Re: [edk2] [PATCH 0/3] ArmVirtPkg: drop support for the ARM BDS

2015-08-04 Thread Ard Biesheuvel
On 4 August 2015 at 17:21, Ard Biesheuvel ard.biesheu...@linaro.org wrote: This series is a followup to the patches 'ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default' and 'ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build' that I sent out earlier today. (The

[edk2] [PATCH] ArmVirtPkg/ArmVirtXen: add missing BdsLib instance

2015-08-04 Thread Ard Biesheuvel
Now that the ARM BDS has been removed, there is a remaining BdsLib dependency in ArmVirtXen that has now become unresolved. So re-add the BdsLib resolution that we removed from ArmVirt.dsc.inc to ArmVirtXen.dsc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] ShellPkg: Fix 'drivers' assert issue for a driver name longer than 35 characters

2015-08-04 Thread Shah, Tapan
Jaben / Shumin, Can you review this one-line fix? Thanks, Tapan ShellPkg: Fix 'drivers' assert issue for a driver name longer than 35 characters Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Tapan Shah

Re: [edk2] [PATCH 1/3] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Laszlo Ersek
On 08/04/15 17:21, Ard Biesheuvel wrote: ARM BDS support in ArmVirtQemu has been broken since SVN r17969 (ArmPkg/BdsLib: Remove Linux loader from BdsLib) dated July 14th. Instead of fixing this, let's get rid of the ARM BDS and LinuxLoader altogether: they violate both the UEFI spec and the

Re: [edk2] [PATCH 2/3] ArmVirtPkg/ArmVirtXen: remove unused PcdFirmwareVendor PCD

2015-08-04 Thread Laszlo Ersek
On 08/04/15 17:21, Ard Biesheuvel wrote: The PcdFirmwareVendor PCD was never used on this platform, since it has never supported the ARM BDS. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org ---

Re: [edk2] [patch] NetworkPkg: Fix assert caused by wrong parameter in AsciiStrCpyS()

2015-08-04 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu jiaxin...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Wednesday, August 5, 2015 10:04 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: [edk2] [patch] NetworkPkg: