Re: [edk2] [Patch 3/6] BaseTools: Update SetPcdPtr in AutoGen Code

2015-08-20 Thread Zeng, Star
On 2015/8/18 17:25, Liming Gao wrote: For patchable PCD, map SetPcdPtr() to LibPatchPcdSetPtrAndSize(), then the size of the updated VOID* value can be cached. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com Reviewed-by: Star Zeng

Re: [edk2] [PATCH v3 1/2] NetworkPkg: Remove the hostname from the http request URL

2015-08-20 Thread Gary Ching-Pang Lin
On Thu, Aug 20, 2015 at 05:04:38AM +, Fu, Siyuan wrote: The patch is good, do you have access authority of edk2? Or I can help to commit this patch. Reviewed-by: Fu Siyuan siyuan...@intel.com I don't have the access right. That would be great if you can help me. Thanks, Gary Lin

Re: [edk2] [Patch 5/6] MdePkg: Add two PcdApi for Patch VOID* PCD set operation.

2015-08-20 Thread Zeng, Star
Liming, Minor comments inline below. Reviewed-by: Star Zeng star.z...@intel.com On 2015/8/18 17:25, Liming Gao wrote: Two new APIs LibPatchPcdSetPtrAndSize() and LibPatchPcdSetPtrAndSizeS() are added to catch the size of the updated VOID* PCD value buffer, then PcdGetSize() API can return the

[edk2] [patch 4/4] CryptoPkg: Add a missed include file to fix the possible build issue.

2015-08-20 Thread Qin Long
Add a missed include file (UefiBaseType.h) into BaseCryptLib.h, since EFI_TIME was introduced in the new crypto API (ImageTimestampVerify). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long qin.l...@intel.com --- CryptoPkg/Include/Library/BaseCryptLib.h | 2 ++ 1

Re: [edk2] [Patch 1/6] BaseTools: Generate macro for the size of PCD value

2015-08-20 Thread Zeng, Star
Another minor below inline. On 2015/8/20 15:35, Zeng, Star wrote: Liming Bob, Comments inline. On 2015/8/18 17:25, Liming Gao wrote: PcdLib introduces new APIs to get the size of PCD value. BaseTools generates those macros in AutoGen code. Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 6/6] SecurityPkg: Use PcdGetSize to get the size of VOID* PCD value.

2015-08-20 Thread Zeng, Star
On 2015/8/18 17:25, Liming Gao wrote: PcdLib introduces generic API to get the size of VOID* PCD value. Update Pei and Dxe RsaGuidedLib to use generic PCD API instead of GetEx API. This change can remove PCD type limitation in these two libraries. Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 4/6] MdePkg: Add four PcdGetSize() API in PcdLib

2015-08-20 Thread Zeng, Star
Liming, Minor comments inline below. Reviewed-by: Star Zeng star.z...@intel.com On 2015/8/18 17:25, Liming Gao wrote: Add below four PcdGetSize() API in PcdLib header file. They can be used to get the size of PCD value. FixedPcdGetSize() PatchPcdGetSize() PcdGetSize() PcdGetExSize()

Re: [edk2] [Patch 3/3] Nt32Pkg: Add HttpUtilitiesDxe module

2015-08-20 Thread Ye, Ting
Reviewed-by: Ye Ting ting...@intel.com -Original Message- From: Wu, Jiaxin Sent: Friday, August 21, 2015 9:37 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Ni, Ruiyu Subject: [Patch 3/3] Nt32Pkg: Add HttpUtilitiesDxe module This patch is used to add HttpUtilitiesDxe module.

Re: [edk2] [Patch 2/3] NetworkPkg: Add HTTP utilities driver

2015-08-20 Thread Ye, Ting
I think the below protocol attribute is incorrect. Should be updated to PRODUCES. gEfiHttpUtilitiesProtocolGuid ## BY_START Also, I expect a following patch to update HttpDxe driver to remove internal functions and consume this protocol. Other parts are good to me. Reviewed-by:

[edk2] Adding a new BoardPkg to edk2 tree: Licensing

2015-08-20 Thread Sharma Bhupesh
Hi Experts, We are considering adding the support for a Freescale ARM64 based platform in the EDK2 tree and upstreaming the same. Since EDK2 is compliant with the BSD - Clause 2 licensing terms (see reference : http://opensource.org/licenses/bsd-license.php), we are contemplating the licensing

Re: [edk2] Adding a new BoardPkg to edk2 tree: Licensing

2015-08-20 Thread Leif Lindholm
Hi Bhupesh, On Thu, Aug 20, 2015 at 11:03:07AM +, Sharma Bhupesh wrote: We are considering adding the support for a Freescale ARM64 based platform in the EDK2 tree and upstreaming the same. As much as I would like to see more open source platform code, I really want to get some structure

[edk2] [Patch 0/3] Add header file and driver module for HTTP utilities

2015-08-20 Thread Jiaxin Wu
Those patches are used to add header file and driver module for HTTP utilities Jiaxin Wu (3): MdePkg: Add header files for HTTP utilities protocol. NetworkPkg: Add HTTP utilities driver. Nt32Pkg: Add HttpUtilitiesDxe module. MdePkg/Include/Protocol/HttpUtilities.h| 124 +++

Re: [edk2] [Patch] BaseTools: Add NULL pointer check in AutoGen code

2015-08-20 Thread Zeng, Star
On 2015/8/19 16:12, Liming Gao wrote: For DynamicEx PCD, if NULL pointer is specified as token space GUID, it will directly be used to compare GUID value in AutoGen code. To avoid access NULL pointer, NULL pointer will be checked first. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch 1/3] MdePkg: Add header file for HTTP utilities protocol

2015-08-20 Thread Ye, Ting
Reviewed-by: Ye Ting ting...@intel.com -Original Message- From: Wu, Jiaxin Sent: Friday, August 21, 2015 9:37 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Gao, Liming Subject: [Patch 1/3] MdePkg: Add header file for HTTP utilities protocol This patch is used to add header