Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: Qiu, Shumin Sent: Tuesday, August 25, 2015 7:46 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin shumin@intel.com; Carsey, Jaben jaben.car...@intel.com Subject: [PATCH] ShellPkg: Fix the ASSERT issue in

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Leif Lindholm
Hi, On Wed, Aug 26, 2015 at 10:45:35AM +0800, Qiu Shumin wrote: Initialize the local pointer to avoid to free a dangling pointer. Cc: Jaben Carsey jaben.car...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com ---

[edk2] [Patch] SourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated

2015-08-26 Thread Jeff Fan
Actually, TimerCycle is APIC timer's initial count. Timer count value 0 is missed when calculating Delta value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan jeff@intel.com CC: Ruiyu Ni ruiyu...@intel.com ---

[edk2] [Patch] SourceLevelDebugPkg/DebugTimer: Fix the issue if CurrentTimer = Timer

2015-08-26 Thread Jeff Fan
If CPU runs fast and timer runs slow, two GetApicTimerCurrentCount() may return the same timer count value. We need to consider timer roll-over not happened. Otherwise, one false timeout flag will be set. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan

Re: [edk2] [PATCH] fix unaligned access in SerializeVariablesLib

2015-08-26 Thread Laszlo Ersek
On 08/21/15 20:28, Michael Zimmermann wrote: I'm using this lib on ARM and it generates unaligned access in it's current state due to the heavy use of pointer casts. This changes the binary format so all previously saved data will be lost. diff --git

Re: [edk2] [PATCH] fix unaligned access in SerializeVariablesLib

2015-08-26 Thread Laszlo Ersek
On 08/26/15 11:02, Michael Zimmermann wrote: 1/2: sry, I'll correct that(if we'll proceed) 3: I've ported EDK2 to a Smartphone. such devices don't have NOR/Flash at all. They just have a MMC device. Since I hate duplicate code I just included the OVMF packages in my DSC. If you say it's

[edk2] [PATCH v2 3/5] ArmPlatformPkg/PlatformIntelBdsLib: add splash screen support

2015-08-26 Thread Ard Biesheuvel
Add a call to EnableQuietBoot () to BdsPlatformPolicyBehavior(), so that a splash screen is shown in case one is present under the correct GUID in the FV, and we have graphics support. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org

[edk2] [PATCH v2 2/5] ArmPlatformPkg/PlatformIntelBdsLib: fix error handling

2015-08-26 Thread Ard Biesheuvel
In InitializeConsolePipe (), we clobber the Status variable in the error handling path that reports Status in its output. Instead, use a NULL check on the LocateProtocol () output argument. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v2 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-08-26 Thread Ard Biesheuvel
The Intel BDS platform library still depends on the ARM BDS specific BdsLib. So replace its invocations with GenericBdsLib counterparts, and fix up where needed, so that we can drop the dependency. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 4/10] MdeModulePkg: Support format string argument checking

2015-08-26 Thread Gao, Liming
Scott: I find this change will impact the check result of ECC tool. This tool is in BaseTools directory that is used to check the coding style in source file. I think we need to investigate how to enhance ECC to support EFIFORMAT. Thanks Liming -Original Message- From: edk2-devel

[edk2] [PATCH v2 5/5] ArmPlatformPkg/ArmVExpress-FVP: enable UEFI Secure Boot

2015-08-26 Thread Ard Biesheuvel
This allows the FVP target to be built with UEFI Secure Boot enabled, by passing -D SECURE_BOOT_ENABLE to the build command line. Note that you will need to disable the ARM BDS (-D USE_ARM_BDS=FALSE) or you will not be able to enroll certificates, since the ARM BDS does not provide a GUI to do so.

[edk2] [PATCH v2 0/5] secure boot support for ARM FVP Base and Foundation models

2015-08-26 Thread Ard Biesheuvel
This series adds support for using the Intel BDS with ArmVExpress-FVP, and for building it with UEFI Secure Boot enabled. Note that the former is a prerequisite of the latter, since the ARM BDS has no GUI for enrolling certificates and enabling secure boot. Patch #1 removes the

Re: [edk2] [PATCH 11/15] OvmfPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-26 Thread Laszlo Ersek
Star, On 08/17/15 10:24, Star Zeng wrote: Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com --- OvmfPkg/OvmfPkgIa32.dsc| 5 -

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-26 Thread Laszlo Ersek
On 08/24/15 08:15, Ni, Ruiyu wrote: Jordan, The mail is too long so let me summarize in below: (I changed all API name to remove Lib) 1. Have four or six BLT APIs? four: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo six: BltVideoFill BltVideoToVideo BltVideoToBuffer

Re: [edk2] [PATCH] fix unaligned access in SerializeVariablesLib

2015-08-26 Thread Michael Zimmermann
1/2: sry, I'll correct that(if we'll proceed) 3: I've ported EDK2 to a Smartphone. such devices don't have NOR/Flash at all. They just have a MMC device. Since I hate duplicate code I just included the OVMF packages in my DSC. If you say it's obsolete I probably should copy this code to my

Re: [edk2] [PATCH] fix unaligned access in SerializeVariablesLib

2015-08-26 Thread Michael Zimmermann
sry for the double message but I accidentally replied to Laszlo only. Well my port is not private but I think it's too hard to submit because it uses a precompiled binary for hardware abstraction in combination with a build system that compiles this binary and generates a FDF include:

[edk2] [Patch] Fix 32 bits arch build fail when disable optimize.

2015-08-26 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: eric Dong eric.d...@intel.com Cc: Feng Tian Feng, t...@intel.com --- IntelFrameworkModulePkg/Csm/BiosThunk/BlockIoDxe/BiosInt13.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg FaultTolerantWrite: Error handling for erase operation failure

2015-08-26 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Wednesday, August 26, 2015 11:36 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] MdeModulePkg FaultTolerantWrite:

[edk2] [patch 1/2] BaseTools:To generate string default type correctly in VfrCompiler

2015-08-26 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan...@intel.com --- BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 1 + BaseTools/Source/C/VfrCompile/VfrSyntax.g | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [PATCH v2] NetworkPkg: Update HttpDxe to consume EFI_HTTP_UTILITIES_PROTOCOL

2015-08-26 Thread Ye, Ting
Reviewed-by: Ye Ting ting...@intel.com -Original Message- From: Fu, Siyuan Sent: Wednesday, August 26, 2015 1:05 PM To: Wu, Jiaxin; edk2-devel@lists.01.org Cc: Ye, Ting; Samer El-Haj-Mahmoud Subject: RE: [PATCH v2] NetworkPkg: Update HttpDxe to consume EFI_HTTP_UTILITIES_PROTOCOL I

Re: [edk2] [PATCH 11/15] OvmfPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-26 Thread Laszlo Ersek
On 08/26/15 12:27, Laszlo Ersek wrote: Star, On 08/17/15 10:24, Star Zeng wrote: Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com ---

Re: [edk2] [patch 1/2] BaseTools:To generate string default type correctly in VfrCompiler

2015-08-26 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 26, 2015 4:46 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch 1/2] BaseTools:To generate

Re: [edk2] [patch 2/2] MdeModulePkg:Set default string value

2015-08-26 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 26, 2015 4:46 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch 2/2] MdeModulePkg:Set

Re: [edk2] [Patch] Fix 32 bits arch build fail when disable optimize.

2015-08-26 Thread Tian, Feng
Suggest correct your comment log as below IntelFrameworkModulePkg/BiosThunk: Fix 32 bits arch build failure when disable optimization. Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent:

Re: [edk2] [PATCH 1/10] BaseTools: Add GCC patch for EDK2 format string argument checking

2015-08-26 Thread Gao, Liming
Scott: Sorry for late response. For GCC source patch, I concern in its license. As you know, EDKII project is BSD license. GCC source code is GPL license. It may not be good to place GCC source patch into EDKII project. I will consult our team member for it. Thanks Liming -Original

Re: [edk2] [PATCH] ArmVirtPkg: revert unintended change to ArmVirt.dsc.inc

2015-08-26 Thread Laszlo Ersek
On 08/25/15 15:23, Ard Biesheuvel wrote: The recent changes to ArmVExpress-FVP-AArch64 in SVN r18309 contained a hunk to ArmVirt.dsc.inc which was included in error. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-26 Thread Benjamin Herrenschmidt
On Wed, 2015-08-26 at 15:31 +, Gao, Liming wrote: Ben: CoreInitializeMemoryServices() API tries to find the highest free memory range to initialize the DXE core. MINIMUM_INITIAL_MEMORY_SIZE specifies the minimum memory size. It first searches the resource HOB that includes PHIT and use

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Qiu, Shumin
Good comment. -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, August 27, 2015 6:58 AM To: Qiu, Shumin Cc: edk2-devel@lists.01.org; Carsey, Jaben Subject: Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command. Hi, On Wed, Aug 26,

Re: [edk2] [PATCH] MdePkg: Modify string expression of BMC device path to follow UEFI spec

2015-08-26 Thread Tian, Feng
Good to me Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: Wu, Hao A Sent: Thursday, August 27, 2015 13:01 To: edk2-devel@lists.01.org; Tian, Feng; Gao, Liming Cc: Wu, Hao A Subject: [PATCH] MdePkg: Modify string expression of BMC device path to follow UEFI spec

[edk2] [PATCH 3/3] SecurityPkg: Refine the local variable name to follow EDK2 coding style.

2015-08-26 Thread Qiu Shumin
Cc: Yao Jiewen jiewen@intel.com Cc: Chao Zhang chao.b.zh...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 92 +++ 1 file changed, 46 insertions(+), 46

[edk2] [PATCH 2/3] SecurityPkg: Add missing Lib definition in DEC file.

2015-08-26 Thread Qiu Shumin
Cc: Yao Jiewen jiewen@intel.com Cc: Chao Zhang chao.b.zh...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com --- SecurityPkg/SecurityPkg.dec | 9 + 1 file changed, 9 insertions(+) diff --git a/SecurityPkg/SecurityPkg.dec

[edk2] [PATCH 0/3] Add missing information and definition in meta files. Refine varialbe name.

2015-08-26 Thread Qiu Shumin
Qiu Shumin (3): SecurityPkg: Add missing PCD usage information. SecurityPkg: Add missing Lib definition in DEC file. SecurityPkg: Refine the local variable name to follow EDK2 coding style. SecurityPkg/SecurityPkg.dec | 11 + SecurityPkg/SecurityPkg.uni | Bin 37562 -

Re: [edk2] [PATCH 3/3] SecurityPkg: Refine the local variable name to follow EDK2 coding style.

2015-08-26 Thread Yao, Jiewen
Looks good. Thanks! -Original Message- From: Qiu, Shumin Sent: Thursday, August 27, 2015 1:13 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Yao, Jiewen; Zhang, Chao B Subject: [PATCH 3/3] SecurityPkg: Refine the local variable name to follow EDK2 coding style. Cc: Yao Jiewen

Re: [edk2] [PATCH 1/3] SecurityPkg: Add missing PCD usage information.

2015-08-26 Thread Zhang, Chao B
Good to me. Reviewed-by: Chao Zhang chao.b.zh...@intel.com Thanks Best regards Chao Zhang -Original Message- From: Qiu, Shumin Sent: Thursday, August 27, 2015 1:13 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Yao, Jiewen; Zhang, Chao B Subject: [PATCH 1/3] SecurityPkg: Add

Re: [edk2] [PATCH 2/3] SecurityPkg: Add missing Lib definition in DEC file.

2015-08-26 Thread Yao, Jiewen
Looks good. Thanks! -Original Message- From: Qiu, Shumin Sent: Thursday, August 27, 2015 1:13 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Yao, Jiewen; Zhang, Chao B Subject: [PATCH 2/3] SecurityPkg: Add missing Lib definition in DEC file. Cc: Yao Jiewen jiewen@intel.com Cc: Chao

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-26 Thread Gao, Liming
Ben: CoreInitializeMemoryServices() API tries to find the highest free memory range to initialize the DXE core. MINIMUM_INITIAL_MEMORY_SIZE specifies the minimum memory size. It first searches the resource HOB that includes PHIT and use this range as the default one, then searches other

Re: [edk2] [Patch] NetworkPkg: Add Dns and HttpUtilities driver UNI files

2015-08-26 Thread Wu, Jiaxin
Thanks, I will correct it before check in the patch. UEFI DNS DXE -- UEFI HTTP UTILITIES DXE From: Fu, Siyuan Sent: Thursday, August 27, 2015 11:38 AM To: Wu, Jiaxin; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [edk2] [Patch] NetworkPkg: Add Dns and HttpUtilities driver UNI files

[edk2] [Patch 3/3] MdeModulePkg: Replace use case of deprecated function GetVariable with GetVariable2.

2015-08-26 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [Patch 0/3] Remove the use cases of deprecated functions.

2015-08-26 Thread Eric Dong
GetVariable and GetEfiGlobalVariable functions has been deprecated, and new function GetVariable2/GetEfiGlobalVariable2 created. This patch replace deprecated functions use case with new functions. Eric Dong (3): IntelFrameworkModulePkg: Replace use case of deprecated function

[edk2] [Patch 1/3] IntelFrameworkModulePkg: Replace use case of deprecated function GetEfiGlobalVariable with GetEfiGlobalVariable2.

2015-08-26 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com --- IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [Patch 0/3] Remove the use cases of deprecated functions.

2015-08-26 Thread Eric Dong
GetVariable and GetEfiGlobalVariable functions has been deprecated, and new function GetVariable2/GetEfiGlobalVariable2 created. This patch replace deprecated functions use case with new functions. Eric Dong (3): MdeModulePkg: Replace use cases of deprecated function GetEfiGlobalVariable

[edk2] [Patch 2/3] IntelFrameworkModulePkg: Replace use case of deprecated function GetEfiGlobalVariable with GetEfiGlobalVariable2.

2015-08-26 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com --- IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [Patch 1/3] MdeModulePkg: Replace use cases of deprecated function GetEfiGlobalVariable with GetEfiGlobalVariable2.

2015-08-26 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com --- .../Application/UiApp/BootMaint/ConsoleOption.c| 18 +- MdeModulePkg/Application/UiApp/BootMaint/Variable.c| 8

[edk2] [Patch 3/3] ShellPkg: Replace use case of deprecated function GetVariable with GetVariable2.

2015-08-26 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [Patch 0/3] Remove the use cases of deprecated functions.

2015-08-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Thursday, August 27, 2015 10:40 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/3] Remove the use cases of deprecated functions.

[edk2] [Patch] BaseTools: Fixed bug for single FV generating.

2015-08-26 Thread Yingke Liu
If -i is specified and this FV has no BlockSize defined, tool did not inherit FD's BlockSize. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu yingke.d@intel.com Reviewed-by: Liming Gao liming@intel.com --- BaseTools/Source/Python/GenFds/Fv.py | 29

Re: [edk2] [Patch] SourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated

2015-08-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Fan, Jeff Sent: Wednesday, August 26, 2015 3:44 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ruiyu...@intel.com Subject: [Patch] SourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated Actually, TimerCycle