Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

Andrew: Now, Build tool will report error message if Conf directory or build configuration file is not found. It can detect the wrong setting when user specifies Conf by mistake. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

[edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

Change the type of PcdMaxPeiPerformanceLogEntries from UINT8 to UINT16 to log more than 255 performance entries in PEI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- .../DxeCorePerformanceLib/DxeCorePerformanceLib.c| 5 -

[edk2] [PATCH] MdeModulePkg AcpiTableDxe: Use Rsdt to check against NULL

Some static scan tool may regard CurrentRsdtEntry to be potentially referenced to NULL pointer if CurrentRsdtEntry == NULL is used in the right above if condition judgment. CopyMem (CurrentRsdtEntry, CurrentRsdtEntry + 1, (*NumberOfTableEntries - Index) * sizeof (UINT32)); It is

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

Series: Reviewed-by: Star Zeng On 2016/3/7 11:23, Cinnamon Shia wrote: Support UEFI shell execution break. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- PerformancePkg/Dp_App/Dp.c | 36

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

Jordan: We have updated edk2\BaseTools\BuildEnv to handle PACKAGES_PATH. I think this change should be in edk2\BaseTools\BuildEnv instead of edksetup.sh. Here is my change. diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv index 7c77454..7b00bc9 100755 --- a/BaseTools/BuildEnv +++

[edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Fix hang issue when reconnecting an ISCSI device

The 'Reset' function for BlockIO(2) in ScsiDiskDxe should return EFI_SUCCESS instead of EFI_DEVICE_ERROR when a device does not support reset feature. Otherwise, a 'reconnect -r' action when an ISCSI device is attached will cause system hang. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH v4] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Monday, March 07, 2016 2:07 PM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng > Subject: [edk2] [PATCH v4] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder > protocol

Re: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Hi Cecil, We found the V2 patch still has some issues need to be fixed before checking in the code. ImageDecoder.h 1. EFI_HII_IMAGE_DECODER_PROTOCOL_GUID should be defined in ImageDecoder.h. Like EFI_HII_IMAGE_EX_PROTOCOL_GUID in HiiImageEx.h // // Global ID for the Hii Image Ex

Re: [edk2] [Patch] MdeModulePkg/Bds: Fix VS2010/VS2012 build failure.

Reviewed-by: Qiu Shumin -Original Message- From: Ni, Ruiyu Sent: Monday, March 07, 2016 1:30 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch] MdeModulePkg/Bds: Fix VS2010/VS2012 build failure. Contributed-under: TianoCore Contribution

[edk2] [Patch] MdeModulePkg/Bds: Fix VS2010/VS2012 build failure.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c

Re: [edk2] [PATCH] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData

On 5 March 2016 at 00:55, Ard Biesheuvel wrote: > On 4 March 2016 at 18:40, wrote: >> From: Sami Mujawar >> >> The UEFI specification allows the operating system (OS) to use the >> Graphics Output Protocol (GOP) in the

Re: [edk2] [PATCH] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

Hi Liming, I see. Thanks for your explanation. Will fix it in the patch v2. Thanks, Cinnamon Shia -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Monday, March 7, 2016 10:49 AM To: Shia, Cinnamon; Kinney, Michael D; edk2-devel@lists.01.org Cc: Gao, Liming

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

On 2016-03-06 06:28:26, Laszlo Ersek wrote: > On 03/05/16 00:47, Kinney, Michael D wrote: > > Jordan, > > > > Given these libs are Base type, a Dynamic PCD could not be used. Only a > > fixed > > or patchable PCD could be used, and if you go through path, you might as > > well > > pick the

[edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

Support UEFI shell execution break. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- PerformancePkg/Dp_App/Dp.c | 36 -- PerformancePkg/Dp_App/DpInternal.h | 27 -

[edk2] [PATCH v2 2/2] ShellPkg/UefiDpLib: Support execution break

Support UEFI shell execution break. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- ShellPkg/Library/UefiDpLib/Dp.c | 48 --- ShellPkg/Library/UefiDpLib/DpInternal.h | 24 ++

Re: [edk2] [PATCH 1/2] PerformancePkg/Dp_App: Support execution break

Hi Star, Thanks for your feedbacks. Will fix it in the patch v2. Thanks, Cinnamon Shia -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Monday, March 7, 2016 10:50 AM To: Shia, Cinnamon; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 1/2]

Re: [edk2] [PATCH v2] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Reviewed-by: Eric Dong Hi Feng, Please help to check in the code. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Wednesday, March 02, 2016 10:56 AM > To: edk2-devel@lists.01.org >

Re: [edk2] [PATCH 1/2] PerformancePkg/Dp_App: Support execution break

Cinnamon, Since you have updated code to replace gBS->LocateHandle with gBS->LocateHandleBuffer at previous commits. How about to update the "gBS->LocateHandle" to "gBS->LocateHandleBuffer" in the new added comments for this patch series? Other parts of this patch series are good to me.

Re: [edk2] [PATCH] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

Cinnamon: You can see PCD gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase and gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64. In source code edk2\MdeModulePkg\Universal\Variable\Pei\Variable.c line 546, the consumer code is like below. NvStorageBase =

Re: [edk2] [patch] ShellPkg: Merge Ping6 and Ifconfig6 tools to Shell command.

Thank you for the comment, I will update the copyright year when I check in. As for the Side Note, it may be easier for version sync in a patch in my opinion, need to wait for other people's Comments. Thanks Lubo -Original Message- From: Carsey, Jaben Sent: Saturday, March 05, 2016

Re: [edk2] [PATCH] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

Hi Mike, Thanks for your feedback. For solving the backward compatible problem, could you share to me what the problem is? The PCD is accessed in override c files? Regarding to introduce a new PCD, does it mean using the new PCD in c files and leaving the existing one as it is? Thanks,

Re: [edk2] allocation of PMem64 BARs

Thanks, Ray > 在 2016年3月6日，下午8:30，Laszlo Ersek 写道： > >> On 03/05/16 10:54, Ni, Ruiyu wrote: >> Laszlo, >> >> Does [0|3|0] contain option rom? (video controller?) >> >> If it contains option rom, PciBusDxe driver has a logic to >> >> convert the PMem64 to PMem32. PMem32 is

Re: [edk2] [Patch 1/2] MdeModulePkg/UefiBootManagerLib: Separate boot description functions.

Patch is good to me. Reviewed-by: Fu Siyuan > -Original Message- > From: Ni, Ruiyu > Sent: Friday, March 4, 2016 6:15 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Tian, Feng ; Fu, > Siyuan >

Re: [edk2] [Patch 2/2] MdeModulePkg/Bds: More user-friendly network boot option description

Patch is good to me. Reviewed-by: Fu Siyuan > -Original Message- > From: Ni, Ruiyu > Sent: Friday, March 4, 2016 6:15 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fu, Siyuan > Subject: [Patch 2/2] MdeModulePkg/Bds: More

Re: [edk2] [PATCH 1/2] ModulePkg/DxeHttpLib: Adding Functions to HttpLib

Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ghazi Belaam > Sent: Saturday, March 5, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Wu, Jiaxin

Re: [edk2] [PATCH 2/2] NetworkPkg: Use the New Functions from HttpLib

Reviewed-by: Fu Siyuan > -Original Message- > From: Ghazi Belaam [mailto:ghazi.bel...@hpe.com] > Sent: Saturday, March 5, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star ; Fu, > Siyuan

Re: [edk2] [PATCH v3] NetworkPkg: Add URI configuration form to HTTP boot driver.

Reviewed-by: Jiaxin Wu > -Original Message- > From: Fu, Siyuan > Sent: Friday, March 4, 2016 4:38 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting > Subject: [PATCH v3] NetworkPkg: Add URI configuration form to

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

On 03/05/16 00:47, Kinney, Michael D wrote: > Jordan, > > Given these libs are Base type, a Dynamic PCD could not be used. Only a fixed > or patchable PCD could be used, and if you go through path, you might as well > pick the right lib in the DSC at build time and get smaller size and better >

Re: [edk2] [PATCH 2/5] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

On 03/06/16 11:54, Marcel Apfelbaum wrote: > On 03/04/2016 04:46 PM, Laszlo Ersek wrote: >> The comments in the code should speak for themselves; here we note only >> two facts: >> >> - The PCI config space writes (to the PCIEXBAR register) are performed >>using the 0xCF8 / 0xCFC IO ports, by

Re: [edk2] allocation of PMem64 BARs

On 03/05/16 10:54, Ni, Ruiyu wrote: > Laszlo, > > Does [0|3|0] contain option rom? (video controller?) > > If it contains option rom, PciBusDxe driver has a logic to > > convert the PMem64 to PMem32. PMem32 is converted > > to Mem32 because COMBINE_MEM_PMEM is set. > > > > The detailed

Re: [edk2] [PATCH 2/5] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

On 03/04/2016 04:46 PM, Laszlo Ersek wrote: The comments in the code should speak for themselves; here we note only two facts: - The PCI config space writes (to the PCIEXBAR register) are performed using the 0xCF8 / 0xCFC IO ports, by virtue of PciLib being resolved to BasePciLibCf8.

Re: [edk2] [PATCH 1/5] OvmfPkg: IndustryStandard/Q35MchIch9.h: add PCIEXBAR macros

On 03/04/2016 04:46 PM, Laszlo Ersek wrote: Section 5.1.16 ("PCIEXBAR -- PCI Express Register Range Base Address") in Intel document #316966-002 (already referenced near the top of this header file) describes the Q35 DRAM Controller register that configures the memory-mapped PCI config space