[edk2] [Patch] UefiCpuPkg/Include: Add VMX MSR register structures

2016-11-29 Thread Michael Kinney
Add MSR_IA32_VMX_BASIC_REGISTER and IA32_VMX_MISC_REGISTER structures with the bit fields for these two MSRs. Also add MSEG_HEADER structure whose base address is in the MsegBase field of MSR_IA32_SMM_MONITOR_CTL_REGISTER. Cc: Jiewen Yao Cc: Jeff Fan

[edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: remove un-used mReservedVectors

2016-11-29 Thread Jeff Fan
Cc: Feng Tian Cc: Jiewen Yao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 5

[edk2] [PATCH 0/3] mReservedVectors is not set

2016-11-29 Thread Jeff Fan
mReservedVectors is used by ArchSaveExceptionContext() and ArchRestoreExceptionContext() to support HOOK_AFTER capability. But it is not set to correct pointer. This is one regression issue when we add PeiExcpetionHandlerLib.inf. The fix is to add parameter ExceptionHandlerData for thoese 2 APIs

[edk2] [PATCH 2/3] UefiCpuPkg: Add ExceptionHandlerData for ArchRestoreExceptionContext()

2016-11-29 Thread Jeff Fan
mReservedVectors is not set, we could add parameter ExceptionHandlerData for ArchRestoreExceptionContext() that could use it instead of mReservedVectors. Cc: Feng Tian Cc: Jiewen Yao Cc: Michael D Kinney Contributed-under:

[edk2] [PATCH 1/3] UefiCpuPkg: Add ExceptionHandlerData for ArchSaveExceptionContext()

2016-11-29 Thread Jeff Fan
mReservedVectors is not set, we could add parameter ExceptionHandlerData for ArchSaveExceptionContext() that could use it instead of mReservedVectors. Cc: Feng Tian Cc: Jiewen Yao Cc: Michael D Kinney Contributed-under:

[edk2] [Patch 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove MTRRs from PSD structure

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=277 All CPUs use the same MTRR settings. Move MTRR settings from a field in the PROCESSOR_SMM_DESCRIPTOR structure into a module global variable. Cc: Jiewen Yao Cc: Jeff Fan Cc: Feng Tian

[edk2] [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=277 Remove MtrrBaseMaskPtr field from PSD and move MTRR to a global variable since all CPUs use the same MTRR settings. Reduce use of PSD to allow alternate SmmCpuFeaturesLib implementations to use their own PSD layouts. Cc: Jiewen Yao

[edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove PSD layout assumptions

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=277 Remove dependency on layout of PROCESSOR_SMM_DESCRIPTOR everywhere possible. The only exception is the standard SMI entry handler template that is included with the PiSmmCpuDxeSmm module. This allows an instance of the SmmCpuFeaturesLib to

Re: [edk2] [PATCH v2] ShellPkg: Add error prompt message in Ifconfig6 command.

2016-11-29 Thread Wu, Jiaxin
Reviewed by : Wu Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang Lubo > Sent: Tuesday, November 29, 2016 10:58 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [Patch] NetworkPkg/IpSecDxe: correct one comment and remove the unused buf

2016-11-29 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, November 30, 2016 10:26 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Zhang, Lubo Subject: [Patch]

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-29 Thread Yao, Jiewen
How about this: UefiCpuPkg/PiSmmCpu: relax superpage protection on page split. PiSmmCpu driver may split page for page attribute request. Current logic not only propagates the super page attribute to the leaf page attribut, but also to the directory page

Re: [edk2] [patch] MdeModulePkg/Ehci: don't clear port status bits during init

2016-11-29 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Tian, Feng Sent: Wednesday, November 30, 2016 1:16 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Mike Turner Subject: [patch] MdeModulePkg/Ehci: don't clear port

[edk2] [patch] MdeModulePkg/Ehci: don't clear port status bits during init

2016-11-29 Thread Feng Tian
Port status bits are clear in original code, so no enumeration takes place. Changing this to prevent the status bits from being cleared allows enumeration to proceed normally. Cc: Star Zeng Cc: Mike Turner Contributed-under: TianoCore

[edk2] [Patch 2/4] Vlv2TbltDevicePkg: Fix SOURCE_DEBUG_ENABLE feature

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=276 Fix library mapping and PCD settings required to use the SOURCE_DEBUG_ENABLE feature in PEI, DXE, and SMM. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore

[edk2] [Patch 3/4] Vlv2TbltDevicePkg/PlatformBdsLib: Add DebugAgent Console

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=276 Add the UART console produced by the DebugAgent when SOURCE_DEBUG_ENABLE is TRUE. Without this change, the debugger connects but the Boot Manager and the UEFI Shell do not have an active console because the Boot Manager does not know about the

[edk2] [Patch 4/4] Vlv2TbltDevicePkg: Update PlatformPkgGccX64.dsc

2016-11-29 Thread Michael Kinney
Update PlatformPkgGccX64.dsc to align with PlatformPkgX64.dsc on library mappings and PCD settings. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney

[edk2] [Patch 1/4] Vlv2TbltDevicePkg: Make !if statement usage consistent

2016-11-29 Thread Michael Kinney
Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-

Re: [edk2] [PATCH v2] ShellPkg: Add error prompt message in Ifconfig6 command.

2016-11-29 Thread Ye, Ting
Looks good to me with the typo fixed. Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Tuesday, November 29, 2016 12:03 PM To: Hegde, Nagaraj P ; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [Patch] NetworkPkg/IpSecDxe: correct one comment and remove the unused buf

2016-11-29 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo -Original Message- From: Wu, Jiaxin Sent: Wednesday, November 30, 2016 10:26 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Zhang, Lubo Subject: [Patch]

Re: [edk2] [PATCH] SourceLevelDebugPkg: Avoid to re-init IDT table again at SMI entry

2016-11-29 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Fan, Jeff > Sent: Tuesday, November 29, 2016 3:17 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen ; > Kinney, Michael D

Re: [edk2] [Patch] NetworkPkg/IpSecDxe: correct one comment and remove the unused buf

2016-11-29 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, November 30, 2016 10:26 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Zhang, > Lubo > Subject: [Patch]

[edk2] [Patch] NetworkPkg/IpSecDxe: correct one comment and remove the unused buf

2016-11-29 Thread Jiaxin Wu
Cc: Fu Siyuan Cc: Ye Ting Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/IpSecDxe/Ikev2/Payload.c | 18 +- 1 file changed, 1

Re: [edk2] [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections

2016-11-29 Thread Kinney, Michael D
Jiewen, I agree. I have entered an additional Bugzilla issue to get the binaries fixed. https://bugzilla.tianocore.org/show_bug.cgi?id=268 Best regards, Mike > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 29, 2016 5:48 PM > To: Kinney, Michael D

Re: [edk2] [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections

2016-11-29 Thread Yao, Jiewen
HI Mike I agree on this change. But I would like to mention that the protection does not takes effect, until all VLV2 binary uses this build option, too. We should feedback to VLV2 binary provider as well. Reviewed-by: jiewen@intel.com Thank you Yao Jiewen > -Original Message- >

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-29 Thread Yao, Jiewen
Comments below: From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 30, 2016 5:54 AM To: Yao, Jiewen ; edk2-de...@ml01.01.org Cc: Kinney, Michael D ; Fan, Jeff Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Replace deprecated debug level macros

2016-11-29 Thread Tian, Feng
Reviewed-by: Feng Tian I will help push it into EDKII trunk. Thanks Feng -Original Message- From: Marcin Wojtas [mailto:m...@semihalf.com] Sent: Tuesday, November 29, 2016 9:52 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-29 Thread Fan, Jeff
Laszlo, Thanks your comments. I added my comments as below in [Jeff] Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 30, 2016 4:49 AM To: Fan, Jeff; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Yao, Jiewen; Tian, Feng Subject:

Re: [edk2] [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen

2016-11-29 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, November 29, 2016 7:41 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen > >

[edk2] [Patch 3/3] Vlv2TbltDevicePkg: Add /m flag for multi-processor build

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=274 Add support for multi-processor builds using a /m flag. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael

[edk2] [Patch 0/3] Vlv2TbltDevicePkg: Update build scripts

2016-11-29 Thread Michael Kinney
Clean up MinnowMax build scripts removing extra null output file and adding flags to enable multi-processor builds and report file generation. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution

[edk2] [Patch 1/3] Vlv2TbltDevicePkg: Fix typo in name of nul output file

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=272 Fix typo in script file. To prevent output from being shown, then output file should be 'nul', not 'null'. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore

[edk2] [Patch 2/3] Vlv2TbltDevicePkg: Add /y flag to generate report files

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=273 Update build script to generate a report file and put both the report file and the log file in the directory Vlv2TbltDevicePkg with an EDK2_Vlv2TbltDevicePkg prefix. Cc: Jiewen Yao Cc: David Wei Cc:

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-29 Thread Laszlo Ersek
On 11/29/16 08:39, Jiewen Yao wrote: > PiSmmCpu driver may split page for page attribute request. > Current logic will propagate the super page attribute attribute. > However, it might be wrong because we cannot clear protection > without touch super page attribute. > > We should always clear

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-29 Thread Laszlo Ersek
On 11/29/16 08:51, Jeff Fan wrote: > Some semaphores are not cleared on S3 boot path. For example, > mSmmMpSyncData->CpuData[CpuIndex].Present. It may still keeps the value set at > SMM runtime during S3 resume. It may causes BSP have the wrong judgement on > SMM > AP's present state. > > We

[edk2] [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections

2016-11-29 Thread Michael Kinney
Update [BuildOptions] to use of 4K aligned PE/COFF image sections to support page level protection of DXE_RUNTIME_DRIVER, SMM_CORE, and DXE_SMM_DRIVER modules. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore

Re: [edk2] [PATCH] IntelFsp2Pkg: Add PACKAGES_PATH support

2016-11-29 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Thomaiyar, Richard Marian > Sent: Friday, November 25, 2016 1:21 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P

Re: [edk2] [PATCH] IntelFsp2Pkg: Add PACKAGES_PATH support

2016-11-29 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Thomaiyar, Richard Marian > Sent: Friday, November 25, 2016 5:21 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P ; >

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Replace deprecated debug level macros

2016-11-29 Thread Marcin Wojtas
From: Jan Dąbroś EFI_D_INFO, EFI_D_VERBOSE, EFI_D_WARN and EFI_D_ERROR are replaced with currently recommended values. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jan Dabros Signed-off-by: Marcin Wojtas ---

[edk2] [PATCH] MdeModulePkg/CapsuleApp: Add Fmp->GetImage() support.

2016-11-29 Thread Jiewen Yao
We add Fmp->GetImage() support in CapsuleApp. So that user may call Fmp->GetImage() in UEFI shell environment. This is useful to do unit test for FMP which supports GetImage(), or user wants to get current image, such as Microcode. Cc: Eric Dong Cc: Jeff Fan

[edk2] [PATCH] UefiCpuPkg/MicrocodeUpdate: Fix GetImage API

2016-11-29 Thread Jiewen Yao
Current GetImage API forgets to return data to caller. Add code to fix it. Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c | 10

Re: [edk2] Which revision of PXE spec does EDK2 code conform to?

2016-11-29 Thread Zimmer, Vincent
Yes. For IPV4 TFTP-based PXE the wire protocol adheres to the PXE 2.1 specification with some errata that supercedes that frozen document found under section "E.4.20 PXE 2.1 specification wire protocol clarifications" of the UEFI 2.6 specification. For IPV6 PXE-style TFTP boot the wire

[edk2] [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen

2016-11-29 Thread Yonghong Zhu
Fix the bug to add PaletteSize info into AutoGen.c when the flag UEFI_HII_RESOURCE_SECTION is set to FALSE. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] Which revision of PXE spec does EDK2 code conform to?

2016-11-29 Thread Heyi Guo
Hi folks, Which revision of PXE spec does EDK2 code conform to? Is it PXE v2.1? Do PXE implementations in MdeModulePkg and NetworkPkg comform to the same revision? Thanks and regards, Heyi ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [Patch 0/6] Fix MinnowMax build and boot issues

2016-11-29 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, November 29, 2016 6:12 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Wei, David > ; Guo, Mang > Subject: [Patch 0/6] Fix

[edk2] [Patch 4/6] Vlv2TbltDevicePkg: Remove SMM binary modules from FDF

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=261 https://bugzilla.tianocore.org/show_bug.cgi?id=262 Remove the PowerManagement2 binary SMM module that generates an ASSERT() and the DigitalThermalSensor binary SMM module that causes an AP to be stuck in the busy state. This is a workaround

[edk2] [Patch 1/6] Vlv2TbltDevicePkg: Allow BaseTools to run from sources

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=258 Update bld_vlv.bat to run BaseTools build command with a call statement to support running the build command from python sources. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo

[edk2] [Patch 6/6] Vlv2TbltDevicePkg: Fix IA32 boot timeouts

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=264 The IA32 build gets timeouts booting to the UEFI Shell. Update the IA32 DSC file to match the X64 DSC file disabling the fTPM feature. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo

[edk2] [Patch 5/6] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Fix IA32 build issues

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=263 Fix IA32 build issues in the PlatformFlashAccessLib. Some of the UINT64 FLASH addresses values need to be typecast to UINTN. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo

[edk2] [Patch 2/6] Vlv2TbltDevicePkg: Set CAPSULE_ENABLE to TRUE

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=259 Set CAPSULE_ENABLE to TRUE so the standard Vlv2TbltDevicePkg platform builds can complete. Build_IFWI.bat assumes this flag is TRUE. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo

[edk2] [Patch 3/6] Vlv2TbltDevicePkg/PlatformInitPei: Workaround unaligned SMRAM size

2016-11-29 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=260 The PiSmmCPuDxeSmm module requires the SMRR base address and length to be aligned. The memory initialization for Vlv2TbltDevicePkg produces an SMRAM base address that is on a 16MB boundary and an SMRAM length of 12MB. The SMRAM length is

[edk2] [Patch 0/6] Fix MinnowMax build and boot issues

2016-11-29 Thread Michael Kinney
This patch series fixes a number of minor issues that prevent MinnowMax from building and booting using latest verison of edk2/master. With these updates, MinnowMax for both IA32 and X64 can boot to the UEFI Shell. A few of these changes are workarounds for issues in the binary support modules

Re: [edk2] [PATCH v3 0/2] UefiCpuPkg, OvmfPkg: set maximum (V)CPU count dynamically

2016-11-29 Thread Laszlo Ersek
On 11/28/16 14:08, Laszlo Ersek wrote: > This is the v3 update on > . > > Changes in this version [Jeff]: > - preserve original behavior for PcdCpuApInitTimeOutInMicroSeconds==0 > - use MAX_UINT32 (~71 minutes) as "infinite