Re: [edk2] [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.0

2017-01-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Tuesday, January 17, 2017 11:25 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming ; Kinney, Michael D Subject:

Re: [edk2] [PATCH 1/7] MdePkg UefiLib: Make the event empty function public

2017-01-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Tuesday, January 17, 2017 3:09 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming ; Kinney, Michael D Subject: [PATCH

Re: [edk2] [PATCH] MdePkg: Correct comments of macros FixedPcdGetX/PatchPcdXXX in PcdLib.h

2017-01-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Tuesday, January 17, 2017 11:44 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming ; Kinney, Michael D Subject:

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2017-01-17 Thread Heyi Guo
Hi Feng, Digging in the code history, I found the original value of USB_BOOT_IO_BLOCKS was 64, but it was changed to be 128 by the commit 41e8ff2. So could you help to explain my questions as below? 1. What was the exact reason to change this value? 2. And for the comment in the code, it

Re: [edk2] [Patch][edk2-platforms] Vlv2DeviceRefCodePkg: Fixed thermal issue.

2017-01-17 Thread Wei, David
Reviewed-by: David Wei Thanks, David Wei -Original Message- From: Lu, ShifeiX A Sent: Wednesday, January 18, 2017 9:08 AM To: edk2-devel@lists.01.org Cc: Wei, David Subject: [Patch][edk2-platforms]

Re: [edk2] [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the ChooseFile handler

2017-01-17 Thread Wu, Jiaxin
Commit version: https://github.com/tianocore/edk2/commit/7be6e6776253d3638f03375e346e978228af5edb Thanks, Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary > Lin > Sent: Monday, January 16, 2017 2:30 PM > To:

Re: [edk2] [PATCH V2] NetworkPkg: Add dns support for target URL configuration in ISCSI.

2017-01-17 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, January 11, 2017 4:08 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin > >

Re: [edk2] [patch 3/3] MdeModulePkg/FileExplorer: Enable functionality of creating new file/folder

2017-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming ; Yao, Jiewen Subject: [patch 3/3]

Re: [edk2] [patch 1/3] MdeModulePkg/FileExplorer: Remove the codes of searching load file protocol

2017-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming ; Yao, Jiewen Subject: [patch 1/3]

Re: [edk2] [patch 2/3] MdeModulePkg/FileExplorer: Update QuesrionId when Updating FileExplore form

2017-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming ; Yao, Jiewen Subject: [patch 2/3]

Re: [edk2] [PATCH v2 2/2] Nt32Pkg.dsc: Add flag to control HTTP connections

2017-01-17 Thread Wu, Jiaxin
> Subject: Re: [edk2] [PATCH v2 2/2] Nt32Pkg.dsc: Add flag to control HTTP > connections > > CC Jordan and Gary > > On 01/17/17 04:33, Jiaxin Wu wrote: > > v2: > > * Rename the flag. > > > > This flag is used to overwrite the PcdAllowHttpConnections > > value, then the platform can make a

[edk2] [Patch][edk2-platforms] Vlv2DeviceRefCodePkg: Fixed thermal issue.

2017-01-17 Thread lushifex
Fixed System auto shutdown when it reached minus 20 degree. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2DeviceRefCodePkg/AcpiTablesPCAT/THERMAL.ASL | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [edk2] SCT 2.3.1 v1.3

2017-01-17 Thread Daniel Samuelraj
Hi, What SCT v1.3 states for HII Config Access Protocol seems not in align with UEFI spec? For example, for extract config, when Progress or Result or Request is NULL, SCT is expecting EFI Invalid Parameter; similarly for Route Config, when progress is NULL, SCT expects EFI_INVALID_PARAMETER.

Re: [edk2] [PATCH 0/3] Enable HTTPS Boot in OVMF

2017-01-17 Thread Laszlo Ersek
On 01/17/17 09:25, Jordan Justen wrote: > On 2017-01-16 20:52:29, Gary Lin wrote: >> This series adjusts the build files of OVMF in order to support HTTPS. >> It introdues a new build option, TLS_ENABLE, and makes OpenSSL a hard >> requirement to enable IPv6 support. >> >> Gary Lin (3): >>

Re: [edk2] [RFC v2 0/6] DxeBmDmaLib (BmDmaLib class) library

2017-01-17 Thread Duran, Leo
Feng, Star, et al, Any comments, questions or concerns? Thanks, Leo. > -Original Message- > From: Duran, Leo > Sent: Friday, January 13, 2017 4:14 PM > To: edk2-devel@lists.01.org > Cc: ler...@redhat.com; jordan.l.jus...@intel.com; feng.t...@intel.com; > star.z...@intel.com;

Re: [edk2] [PATCH v2 5/5] MdeModulePkg/UfsBlockIoPei: fix initialize OCS value to 0x0F

2017-01-17 Thread Leif Lindholm
On Tue, Jan 17, 2017 at 02:06:51AM +, Tian, Feng wrote: > Agree. > > How about naming it as UFS_TRD_OCS_INIT_VALUE? > > If there is no objection, I will help make this change and push > these patches into EDKII trunk. That sounds excellent to me, thanks! / Leif > Series reviewed-by:

Re: [edk2] [PATCH v2 2/2] Nt32Pkg.dsc: Add flag to control HTTP connections

2017-01-17 Thread Gary Lin
On Tue, Jan 17, 2017 at 11:02:17AM +0100, Laszlo Ersek wrote: > CC Jordan and Gary > > On 01/17/17 04:33, Jiaxin Wu wrote: > > v2: > > * Rename the flag. > > > > This flag is used to overwrite the PcdAllowHttpConnections > > value, then the platform can make a decision whether to allow > > HTTP

Re: [edk2] [PATCH v2 2/2] Nt32Pkg.dsc: Add flag to control HTTP connections

2017-01-17 Thread Laszlo Ersek
CC Jordan and Gary On 01/17/17 04:33, Jiaxin Wu wrote: > v2: > * Rename the flag. > > This flag is used to overwrite the PcdAllowHttpConnections > value, then the platform can make a decision whether to allow > HTTP connections or not. > > Cc: Ye Ting > Cc: Fu Siyuan

Re: [edk2] [PATCH 0/3] Enable HTTPS Boot in OVMF

2017-01-17 Thread Laszlo Ersek
On 01/17/17 05:52, Gary Lin wrote: > This series adjusts the build files of OVMF in order to support HTTPS. > It introdues a new build option, TLS_ENABLE, and makes OpenSSL a hard > requirement to enable IPv6 support. > > Gary Lin (3): > OvmfPkg: always resolve OpenSslLib, IntrinsicLib and

Re: [edk2] [PATCH 7/7] ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib

2017-01-17 Thread Ard Biesheuvel
On 17 January 2017 at 07:08, Star Zeng wrote: > Use EfiEventGroupSignal from UefiLib and remove > EmptyCallbackFunction. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel

Re: [edk2] [PATCH 3/3] OvmfPkg: pull in TLS modules with -D TLS_ENABLE (also enabling HTTPS)

2017-01-17 Thread Laszlo Ersek
On 01/17/17 05:52, Gary Lin wrote: > This commit introduces a new build option, TLS_ENABLE, to pull in the > TLS-related modules. If HTTP_BOOT_ENABLE and TLS_ENABLE are enabled at > the same time, the HTTP driver locates the TLS protocols automatically > and thus HTTPS is enabled. > > To build

Re: [edk2] [PATCH 2/3] OvmfPkg: correct the set of modules included for the IPv6 stack

2017-01-17 Thread Laszlo Ersek
On 01/17/17 05:52, Gary Lin wrote: > Always use IScsiDxe from NetworkPkg when IPv6 is enabled since it provides > the complete ISCSI support. > > NOTE: This makes OpenSSL a hard requirement when NETWORK_IP6_ENABLE is > true. > > (Based on Jiaxin's suggestion) > > Cc: Laszlo Ersek

Re: [edk2] [PATCH 1/3] OvmfPkg: always resolve OpenSslLib, IntrinsicLib and BaseCryptLib

2017-01-17 Thread Laszlo Ersek
On 01/17/17 05:52, Gary Lin wrote: > This commit provides unconditional library resolutions for the OpenSslLib, > IntrinsicLib and BaseCryptLib classes, regardless of whether those classes > are actually used by any module. > > Although those libraries depends on OpenSSL, they won't be built

Re: [edk2] [PATCH v2 1/2] NetworkPkg: Add PCD to enable the HTTP connections switch

2017-01-17 Thread Laszlo Ersek
On 01/17/17 04:33, Jiaxin Wu wrote: > v2: > * Rename the PCD to PcdAllowHttpConnections. > * Refine the PCD descriptions. > > If the value of PcdAllowHttpConnections is TRUE, HTTP connections is > allowed. Both the "https://; and "http://; URI schemes are permitted. > Otherwise, HTTP connections

Re: [edk2] [PATCH 0/3] Enable HTTPS Boot in OVMF

2017-01-17 Thread Jordan Justen
On 2017-01-16 20:52:29, Gary Lin wrote: > This series adjusts the build files of OVMF in order to support HTTPS. > It introdues a new build option, TLS_ENABLE, and makes OpenSSL a hard > requirement to enable IPv6 support. > > Gary Lin (3): > OvmfPkg: always resolve OpenSslLib, IntrinsicLib and

Re: [edk2] [PATCH 0/3] Enable HTTPS Boot in OVMF

2017-01-17 Thread Long, Qin
Series reviewed by: Long Qin Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Tuesday, January 17, 2017 12:52 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH

Re: [edk2] [PATCH 3/3] OvmfPkg: pull in TLS modules with -D TLS_ENABLE (also enabling HTTPS)

2017-01-17 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, January 17, 2017 12:53 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Justen, Jordan L > ; Wu, Jiaxin

Re: [edk2] [PATCH 2/3] OvmfPkg: correct the set of modules included for the IPv6 stack

2017-01-17 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, January 17, 2017 12:53 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Justen, Jordan L > ; Wu, Jiaxin

Re: [edk2] [PATCH 1/3] OvmfPkg: always resolve OpenSslLib, IntrinsicLib and BaseCryptLib

2017-01-17 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, January 17, 2017 12:53 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Justen, Jordan L > ; Wu, Jiaxin