Re: [edk2] [Patch] BaseTools/EfiRom: Add multiple device id support

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, August 22, 2017 3:27 PM >To: edk2-devel@lists.01.org >Cc: Verkamp, Daniel ; Gao, Liming >; Tomas Pilar >Subject:

Re: [edk2] [Patch] BaseTools: Support /WHOLEARCHIVE option in VS2015 tool chain

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, August 24, 2017 12:38 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Support /WHOLEARCHIVE option in

[edk2] [patch] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Add NULL pointer check

mLegacyBootOptionPrivate pointer is initialized in Constructor function with if condition check, but it's used in Destructor function directly without any check. Now add the NULL pointer check. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore

Re: [edk2] [PATCH v4 6/6] Nt32Pkg: Enable UDF file system support

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, August 25, 2017 1:56 AM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Ni, Ruiyu ; Wu, > Hao A

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Fix Map and Unmap inconsistency

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, August 24, 2017 5:47 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Ni, Ruiyu ; Yao, > Jiewen > Subject:

Re: [edk2] [Patch] UefiCpuPkg/MpLib: fix potential overflow issue.

Reviewed-by: Michael Kinney Mike > -Original Message- > From: Dong, Eric > Sent: Wednesday, August 23, 2017 7:57 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > > Subject: [Patch]

Re: [edk2] [Patch 0/4] Enhance the implementation for Proc Trace feature.

Series Reviewed-by: Michael Kinney > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Eric Dong > Sent: Wednesday, August 23, 2017 8:03 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/4] Enhance the

Re: [edk2] [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI

On 24 August 2017 at 21:21, Ard Biesheuvel wrote: > Replace the open coded PCI 'emulation' with a simple call into > the NonDiscoverable device registration library, and fix up all > platform .DSCs/FDFs accordingly. > > Contributed-under: TianoCore Contribution

[edk2] [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI

Replace the open coded PCI 'emulation' with a simple call into the NonDiscoverable device registration library, and fix up all platform .DSCs/FDFs accordingly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- I can't test this

Re: [edk2] [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

On 24 August 2017 at 17:59, Laszlo Ersek wrote: > On 08/24/17 18:20, Leif Lindholm wrote: >> A block of settings has been copied around ARM platforms for years. >> These are consumed only by Ebl, and since none of the ArmVirtPkg >> platforms use that, drop them. >> >>

Re: [edk2] [PATCH] Platform/Silicon: clean up BeagleBoard cargo culting

On 24 August 2017 at 17:21, Leif Lindholm wrote: > A group of Pcd settings have been copied around ARM platforms from the > original BeagleBoardPkg, which > 1) Used Ebl. > 2) Was designed to minimise image size. > > None of the affected platforms _use_ Ebl, and all of

Re: [edk2] [PATCH edk2-platforms v2] Silicon/Openmoko: add driver for ChaosKey RNG USB device

On 24 August 2017 at 16:45, Leif Lindholm wrote: > On Thu, Aug 24, 2017 at 01:14:48PM +0100, Ard Biesheuvel wrote: >> This is a continuation of the work carried out by Leif Lindholm to >> implement a driver for the ChaosKey USB device. This driver uses the >> UEFI driver

Re: [edk2] [PATCH] Platform: remove ArmDmaLib references from Styx platforms

On 24 August 2017 at 16:49, Leif Lindholm wrote: > On Thu, Aug 24, 2017 at 04:47:03PM +0100, Ard Biesheuvel wrote: >> Remove the references to ArmDmaLib and UncachedMemoryAllocationLib >> from the various Styx based platforms. They are intended for non-cache >> coherent

[edk2] [PATCH v4 5/6] ArmVirtPkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara Reviewed-by: Ard Biesheuvel

[edk2] [PATCH v4 6/6] Nt32Pkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Ruiyu Ni Cc: Hao Wu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara --- Nt32Pkg/Nt32Pkg.dsc | 1 +

[edk2] [PATCH v4 4/6] OvmfPkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara Reviewed-by: Laszlo Ersek ---

[edk2] [PATCH v4 1/6] MdePkg: Add UDF volume structure definitions

This patch adds basic volume structure definitions necessary to identify a valid UDF file system on a block device, as specified by OSTA Universal Disk Format Specification 2.60. Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek

[edk2] [PATCH v4 2/6] MdeModulePkg/PartitionDxe: Add UDF file system support

Scan for UDF file systems on all block devices, as specified by OSTA Universal Disk Format Specification 2.60, and install a Vendor-Defined Media Device Path for each file system found. The Vendor-Defined Media Device Path for the UDF file system is then checked by UdfDxe to decide whether or not

[edk2] [PATCH v4 0/6] read-only UDF file system support

Hi, This series introduces read-only UDF file system support in EDK2. As Laszlo (or Red Hat) seemed to be interested in such support, I'm posting it again after ~3 years. The idea is not replacing the default FAT file system, nor breaking any existing file system support, but extending EDK2 with

Re: [edk2] [PATCH v3 0/6] read-only UDF file system support

On 24/08/2017 14:26, Laszlo Ersek wrote: Hi Paulo, On 08/24/17 19:12, Paulo Alcantara wrote: v3: - Install UDF partition child handles with a Vendor-Defined Media Device Path. - Changed UdfDxe to check for Vendor-Defined Media Device Paths with a specific UDF file system

Re: [edk2] [PATCH v3 0/6] read-only UDF file system support

Hi Paulo, On 08/24/17 19:12, Paulo Alcantara wrote: > v3: > - Install UDF partition child handles with a Vendor-Defined Media > Device Path. > - Changed UdfDxe to check for Vendor-Defined Media Device Paths with a > specific UDF file system GUID when determining to whether or not >

[edk2] [PATCH] ArmPkg/ArmDmaLib: remove dependency on UncachedMemoryAllocationLib

Now that ArmDmaLib no longer uses uncached mappings for short-lived bounce buffers used for streaming DMA, the only place we allocate uncached memory is in DmaAllocateBuffer (), which is used for static mappings shared between the host and the device, e.g., for packet descriptor rings etc. There

[edk2] [PATCH v3 5/6] ArmVirtPkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara --- ArmVirtPkg/ArmVirtQemu.dsc | 3 ++-

[edk2] [PATCH v3 4/6] OvmfPkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara --- OvmfPkg/OvmfPkgIa32.dsc| 1 +

[edk2] [PATCH v3 6/6] Nt32Pkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Ruiyu Ni Cc: Hao Wu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara --- Nt32Pkg/Nt32Pkg.dsc | 1 +

[edk2] [PATCH v3 2/6] MdeModulePkg/PartitionDxe: Add UDF file system support

Scan for UDF file systems on all block devices, as specified by OSTA Universal Disk Format Specification 2.60, and install a Vendor-Defined Media Device Path for each file system found. The Vendor-Defined Media Device Path for the UDF file system is then checked by UdfDxe to decide whether or not

[edk2] [PATCH v3 0/6] read-only UDF file system support

Hi, This series introduces read-only UDF file system support in EDK2. As Laszlo (or Red Hat) seemed to be interested in such support, I'm posting it again after ~3 years. The idea is not replacing the default FAT file system, nor breaking any existing file system support, but extending EDK2 with

[edk2] [PATCH v3 1/6] MdePkg: Add UDF volume structure definitions

This patch adds basic volume structure definitions necessary to identify a valid UDF file system on a block device, as specified by OSTA Universal Disk Format Specification 2.60. Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek

Re: [edk2] [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

On 08/24/17 18:20, Leif Lindholm wrote: > A block of settings has been copied around ARM platforms for years. > These are consumed only by Ebl, and since none of the ArmVirtPkg > platforms use that, drop them. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif

[edk2] [PATCH] Platform/Silicon: clean up BeagleBoard cargo culting

A group of Pcd settings have been copied around ARM platforms from the original BeagleBoardPkg, which 1) Used Ebl. 2) Was designed to minimise image size. None of the affected platforms _use_ Ebl, and all of them could benefit from keeping ComponentName*Protocol information around, so remove

[edk2] [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc

A block of settings has been copied around ARM platforms for years. These are consumed only by Ebl, and since none of the ArmVirtPkg platforms use that, drop them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm ---

Re: [edk2] [PATCH] Platform: remove ArmDmaLib references from Styx platforms

On Thu, Aug 24, 2017 at 04:47:03PM +0100, Ard Biesheuvel wrote: > Remove the references to ArmDmaLib and UncachedMemoryAllocationLib > from the various Styx based platforms. They are intended for non-cache > coherent DMA only, which is not used on these platforms. > > Contributed-under: TianoCore

[edk2] [PATCH] Platform: remove ArmDmaLib references from Styx platforms

Remove the references to ArmDmaLib and UncachedMemoryAllocationLib from the various Styx based platforms. They are intended for non-cache coherent DMA only, which is not used on these platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH edk2-platforms v2] Silicon/Openmoko: add driver for ChaosKey RNG USB device

On Thu, Aug 24, 2017 at 01:14:48PM +0100, Ard Biesheuvel wrote: > This is a continuation of the work carried out by Leif Lindholm to > implement a driver for the ChaosKey USB device. This driver uses the > UEFI driver model, which is a slightly awkward fit, due to the fact > that a UEFI

Re: [edk2] [PATCH] OvmfPkg/QemuVideoDxe: remove AARCH64/ARM support

On 24 August 2017 at 14:48, Laszlo Ersek wrote: > On 08/24/17 14:24, Ard Biesheuvel wrote: >> Now that we have dropped QemuVideoDxe from all QEMU targeted builds >> under ArmVirtPkg, we can revert the ARM specific changes to it. >> >> This partially reverts commits 84a75f70e903

Re: [edk2] [PATCH] OvmfPkg/QemuVideoDxe: remove AARCH64/ARM support

On 08/24/17 14:24, Ard Biesheuvel wrote: > Now that we have dropped QemuVideoDxe from all QEMU targeted builds > under ArmVirtPkg, we can revert the ARM specific changes to it. > > This partially reverts commits 84a75f70e903 (SVN 16890) and > 05a537945872. > > Contributed-under: TianoCore

Re: [edk2] [patch] BaseTools/UPT: Fix UNI file name issue

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Chen, Hesheng Sent: Wednesday, August 23, 2017 1:54 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [patch] BaseTools/UPT: Fix UNI file name issue

Re: [edk2] [Patch] BaseTools: Update tools_def to remove /Gw option in VS NOOPT target

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, August 24, 2017 11:32 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Update tools_def to remove /Gw

Re: [edk2] [Patch] BaseTools: Add the missing -pie link option in GCC tool chain

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, August 23, 2017 4:04 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Add

Re: [edk2] [PATCH] ArmVirtPkg: remove QemuVideoDxe from ArmVirtQemu and ArmVirtQemuKernel

On 24 August 2017 at 13:02, Leif Lindholm wrote: > On Wed, Aug 23, 2017 at 04:00:57PM +0100, Leif Lindholm wrote: >> On Wed, Aug 23, 2017 at 03:36:37PM +0200, Laszlo Ersek wrote: >> > On 08/23/17 15:17, Ard Biesheuvel wrote: >> > (My R-b stands; these are comments

[edk2] [PATCH] OvmfPkg/QemuVideoDxe: remove AARCH64/ARM support

Now that we have dropped QemuVideoDxe from all QEMU targeted builds under ArmVirtPkg, we can revert the ARM specific changes to it. This partially reverts commits 84a75f70e903 (SVN 16890) and 05a537945872. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH edk2-platforms v2] Silicon/Openmoko: add driver for ChaosKey RNG USB device

This is a continuation of the work carried out by Leif Lindholm to implement a driver for the ChaosKey USB device. This driver uses the UEFI driver model, which is a slightly awkward fit, due to the fact that a UEFI implementation may legally only instantiate those protocols that are needed to

Re: [edk2] [PATCH] ArmVirtPkg: remove QemuVideoDxe from ArmVirtQemu and ArmVirtQemuKernel

On Wed, Aug 23, 2017 at 04:00:57PM +0100, Leif Lindholm wrote: > On Wed, Aug 23, 2017 at 03:36:37PM +0200, Laszlo Ersek wrote: > > On 08/23/17 15:17, Ard Biesheuvel wrote: > > (My R-b stands; these are comments for a possible followup patch.) > > > > Please see: > > > > -

Re: [edk2] [PATCH edk2-platforms] Silicon/Openmoko: add driver for ChaosKey RNG USB device

On Thu, Aug 24, 2017 at 10:44:46AM +0100, Ard Biesheuvel wrote: > >> Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.c | 346 > >> Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 61 > >> Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf | 48 +++ > >>

Re: [edk2] [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro.

On 08/03/17 11:32, Eric Dong wrote: > Cc: Jeff Fan > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Include/Library/MtrrLib.h | 27 --- > 1

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix memory protection crash

I did test on OVMF for the case by myself. :) Your double confirm will be wonderful. I will wait for your test result. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, August 24, 2017 6:21 PM To: Zeng,

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix memory protection crash

Hi, On 08/24/17 05:20, Star Zeng wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=624 reports > memory protection crash in PiSmmCpuDxeSmm, Ia32 build with > RAM above 4GB (of which 2GB are placed in 64-bit address). > It is because UEFI builds identity mapping page tables, >> 4G address is

Re: [edk2] [PATCH v3 00/21] OvmfPkg/Virtio: introduce IOMMU-like member functions

On 08/24/17 04:06, Brijesh Singh wrote: > > > On 8/23/17 8:22 PM, Laszlo Ersek wrote:Okay, I will look into it - > thanks for the tip. I wanted to actually use >>> the Simple array (because we know the maximum number of buffer we can >>> queue) but was not sure about your preferences hence I

[edk2] [PATCH] MdeModulePkg XhciDxe: Fix Map and Unmap inconsistency

We found there are loops of *2* Maps and only *1* Unmap and the DMA buffer address is decreasing. It is caused by the below code flow. XhcAsyncInterruptTransfer -> XhcCreateUrb -> XhcCreateTransferTrb -> Map Urb->DataMap (1) Timer: loops of *2* Maps and only *1* Unmap

[edk2] [Patch] MdePkg: Add UEFI 2.7 defined GUID and structure for AIP network media type.

From: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan --- MdePkg/Include/Protocol/AdapterInformation.h | 21 - 1 file

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix memory protection crash

Thanks for the Reviewed-by. Sorry I did not check the whole thread at https://lists.01.org/pipermail/edk2-devel/2017-July/012283.html that has the discussion about the validity of BASE 0 + LENGTH 4G (Case1) and BASE 4G + LENGTH 0 (Case2). Current code has filtered Case2. @retval

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix memory protection crash

Reviewed-by: jiewen@intel.com From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Thursday, August 24, 2017 11:20 AM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Yao, Jiewen ; Dong, Eric ;

Re: [edk2] HiiValidateSettings issue with string item

Hi Wim Vervoorn, Thanks for reporting this issue. It's a bug of current code and your solution can fix it correctly. But when the storage is NameValueType, for string opcode, current code also calculate the string length incorrectly, the length should not include the trailing terminator and

Re: [edk2] [PATCH v2] SecurityPkg/Tcg2Dxe: Properly shutdown TPM before reset

Reviewed-by : Chao Zhang -Original Message- From: Ni, Ruiyu Sent: Thursday, August 24, 2017 3:53 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [PATCH v2] SecurityPkg/Tcg2Dxe: Properly shutdown TPM before reset

[edk2] [PATCH v2] SecurityPkg/Tcg2Dxe: Properly shutdown TPM before reset

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Chao B Zhang --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 68 + SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 + 2 files changed, 69

Re: [edk2] [PATCH] SecurityPkg/Tcg2Dxe: Properly shutdown TPM before reset

Ruiyu： 3 comments 1. Please add debug message for TPM2_SHUTDOWN command execution status 2. Please add spec info for this behavior. 3. Please use protocol notify to RegisterResetNotify -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

[edk2] HiiValidateSettings issue with string item

Hello, I am running into an issue with HiiValidateSettings (); when my VFR contains a string item that is filled with a string of maximum length. In this case the validation returns an error because it thinks the string is too long. During the validation ValidateQuestionFromVfr (); checks if

[edk2] [PATCH] SecurityPkg/Tcg2Dxe: Properly shutdown TPM before reset

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Chao B Zhang --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 43 + SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 + 2 files changed, 44

[edk2] [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option

https://bugzilla.tianocore.org/show_bug.cgi?id=581 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)