[edk2] [PATCH] ShellPkg/for: Fix potential null pointer deference

2018-02-04 Thread Ruiyu Ni
When "FOR %a %a IN A B C" is executed, CurrentScriptFile->CurrentCommand->Data is NULL. But the code assumes it's not NULL and tries to deference it. The patch fixes this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey

[edk2] [Patch] BaseTools: not specified value of MAX_CONCURRENT_THREAD_NUMBER

2018-02-04 Thread Yonghong Zhu
when MAX_CONCURRENT_THREAD_NUMBER is not specified, tool will automatically detect number of processor threads. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=775 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch] Build spec: Add description about auto detect thread number

2018-02-04 Thread Yonghong Zhu
Add description about enable auto detect thread number when MAX_CONCURRENT_THREAD_NUMBER is not specified. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=775 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw

[edk2] [PATCH] ShellPkg/map: Fix out-of-bound read when "map fsn"

2018-02-04 Thread Ruiyu Ni
The below code reads additional one CHAR16 when copying content from Specific to NewSpecific. NewSpecific = AllocateCopyPool( StrSize(Specific) + sizeof(CHAR16), Specific ); The patch fixes this issue. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2] MdePkg/SafeString: Fix potential out-of-bound memory access

2018-02-04 Thread Ruiyu Ni
Today's implementation of [Ascii]StrnCpyS/[Ascii]StrnCatS calls StrnLenS () to get the length of source string but supplies the destination buffer size as max size. It's a bug that may cause out-of-bound memory access. For example: StrnCpyS (Dest[10], 10, "hello", 6) -> StrnLenS ("hello", 10)

Re: [edk2] [PATCH] MdePkg/SafeString: Directly return when length of source string is 0

2018-02-04 Thread Yao, Jiewen
Thanks to catch this. The root-cause of the failure is below line: SourceLen = StrnLenS (Source, DestMax); We should only limit the Source string access within Length, not DestMax, if Length is smaller than DestMax. 0 is just one special case. Length might be 1, 2, or 3 and it triggers same

[edk2] [PATCH] BaseTools: Report error GUID format if incorrectly

2018-02-04 Thread Feng, YunhuaX
Flexible GUID format support like these: 1. { GUID("11E13869-1896-4A07-8B21-D8B23DD2A2B4") } 2. { GUID({ 0x11e13869, 0x1896, 0x4a07,{ 0x8b, 0x21, 0xd8, 0xb2, 0x3d, 0xd2, 0xa2, 0xb4 } }) } 3. { GUID(gEfiBlockIoProtocolGuid) } Cc: Liming Gao Cc: Yonghong Zhu

[edk2] [PATCH] BaseTools: Fix build argument --pcd for flexible format bugs

2018-02-04 Thread Feng, YunhuaX
Build argument --pcd flexible format, like as: 1. VOID* type gTokenSpaceGuid.Test=H"{flexible format}" gTokenSpaceGuid.Test=L"string" gTokenSpaceGuid.Test="string" gTokenSpaceGuid.Test=L'string' gTokenSpaceGuid.Test='string' 2. UINT8/UINT16/UINT32/UINT64 type gTokenSpaceGuid.Test=H"{flexible

Re: [edk2] setting the TLS cipher list for HTTPS booting

2018-02-04 Thread Wu, Jiaxin
Hi Laszlo, In recent days, we received the comment from Kinney about the PCD usage in UEFI driver. Kinney doesn't recommend us to use the *dynamic PCD* in *soft-loading* UEFI driver even though it's not prohibited. So, we want to confirm with you whether this is the urgent request need us to

Re: [edk2] [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile

2018-02-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 31, 2018 8:00 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2]

[edk2] [PATCH] SecurityPkg: Support PP version lower than 1.3

2018-02-04 Thread Zhang, Chao B
TCG PP 1.2 & PP 1.3 spec defined different Opcodes. Update code to support both. Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang --- .../SmmTcg2PhysicalPresenceLib.c

Re: [edk2] [PATCH] MdePkg/SafeString: Directly return when length of source string is 0

2018-02-04 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Ni, Ruiyu > Sent: Friday, February 02, 2018 6:48 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming ; > Wang, Jian J > Subject:

Re: [edk2] [PATCH] SecurityPkg: Add UNI string for 2 PCDs

2018-02-04 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Saturday, February 3, 2018 11:12 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Zhang, Chao B