Re: [edk2] [PATCH 17/37] IntelFrameworkModulePkg: Removing ipf from edk2.

2018-06-12 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Chen, Chen A >Sent: Wednesday, June 13, 2018 11:44 AM >To: edk2-devel@lists.01.org >Cc: Chen, Chen A ; Gao, Liming >; Kinney, Michael D >Subject: [PATCH 17/37] IntelFrameworkModulePkg: Removing ipf from edk2. > >Removing rules for Ipf

Re: [edk2] [PATCH 18/37] IntelFrameworkPkg: Removing ipf from edk2.

2018-06-12 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Chen, Chen A >Sent: Wednesday, June 13, 2018 11:44 AM >To: edk2-devel@lists.01.org >Cc: Chen, Chen A ; Gao, Liming >; Kinney, Michael D >Subject: [PATCH 18/37] IntelFrameworkPkg: Removing ipf from edk2. > >Removing rules for Ipf sources

Re: [edk2] [PATCH 01/37] AppPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread Jordan Justen
On 2018-06-12 20:43:03, chenc2 wrote: > Removing rules for Ipf sources file: > * Remove the source file which path with "ipf" and also listed in > [Sources.IPF] section of INF file. > * Remove the source file which listed in [Components.IPF] section > of DSC file and not listed in any other

[edk2] [PATCH v2 0/2] fix DXE memory free issue in SMM mode

2018-06-12 Thread Jian J Wang
> v2: > a. add more specific explanations in commit message > b. add more comments in code > c. remove redundant logic in code > d. fix logic hole in code > e. replace meanless constant macro with meaning ones > f. remove irrelated changes This patch series try to fix an issue caused

[edk2] [PATCH v2 2/2] MdeModulePkg/Core: remove SMM check for Heap Guard feature detection

2018-06-12 Thread Jian J Wang
CpuDxe driver is updated to be able to access DXE page table in SMM mode, which means Heap Guard can get correct memory paging attributes in what environment. It's not necessary to exclude SMM from detecting Heap Guard feature support. Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Cc: Ruiyu Ni

[edk2] [PATCH v2 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-12 Thread Jian J Wang
> v2: > a. add more specific explanations in commit message > b. add more comments in code > c. remove redundant logic in IsInSmm() > d. fix a logic hole in GetCurrentPagingContext() > e. replace meanless constant macro with meaning ones The MdePkg/Library/SmmMemoryAllocationLib, used

[edk2] [PATCH 37/37] Vlv2TbltDevicePkg: Removing ipf which from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 32/37] SignedCapsulePkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 01/37] AppPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 36/37] UefiCpuPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 16/37] FatPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 12/37] EdkShellPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 35/37] StdLibPrivateInternalFiles: Removing ipf from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 18/37] IntelFrameworkPkg: Removing ipf from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 07/37] CorebootPayloadPkg: Removing ipf from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 06/37] CorebootModulePkg: Removing ipf from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 25/37] OptionRomPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 17/37] IntelFrameworkModulePkg: Removing ipf from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 05/37] BeagleBoardPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 26/37] OvmfPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 33/37] SourceLevelDebugPkg: Removing ipf from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 31/37] ShellPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 29/37] QuarkSocPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 27/37] PcAtChipsetPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 28/37] QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 23/37] Nt32Pkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 24/37] Omap35xxPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 22/37] NetworkPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 14/37] EmulatorPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 15/37] FatBinPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 13/37] EmbeddedPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 19/37] IntelSiliconPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 11/37] EdkShellBinPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 08/37] CryptoPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 09/37] DuetPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 02/37] ArmPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 03/37] ArmPlatformPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

[edk2] [PATCH 04/37] ArmVirtPkg: Removing ipf which is no longer supported from edk2.

2018-06-12 Thread chenc2
Removing rules for Ipf sources file: * Remove the source file which path with "ipf" and also listed in [Sources.IPF] section of INF file. * Remove the source file which listed in [Components.IPF] section of DSC file and not listed in any other [Components] section. * Remove the embedded Ipf

Re: [edk2] Crc32 Calculation Miss

2018-06-12 Thread Gao, Liming
No. Most PEI runs in flash, are not loaded into RAM. So, I suggest to locate FvInfoPpi and get PEI FV image data. You can calculate CRC32 value of PEI FV image. From: Guy Raviv [mailto:guyrav...@gmail.com] Sent: Tuesday, June 12, 2018 1:37 PM To: Gao, Liming Cc: edk2-devel@lists.01.org

Re: [edk2] [RFC PATCH 00/11] GCC/X64: use hidden visibility for LTO PIE code

2018-06-12 Thread Shi, Steven
Hi Ard, Zenith, Thank you both explained the complete knowledge about ELF GOT, LTO, PIC/PIE, machine code mode and GCC visibility #pragma. It is pretty good to read them all in one picture. And I believe copying these explain to a edk2 wiki page in GitHub could be very useful for other edk2

[edk2] [Patch] BaseTools: remove the unneeded code

2018-06-12 Thread Yonghong Zhu
Do a clean up to remove the unneeded code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/MetaFileParser.py | 17 - 1 file changed, 17 deletions(-) diff --git

Re: [edk2] [Patch] BaseTools: Fix one bug of nest !include parser

2018-06-12 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, June 12, 2018 9:01 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: [edk2] [Patch]

Re: [edk2] [PATCH edk2-platforms 1/2] Silicon/SynQuacerPlatformFlashAccessLib: relax FV address check

2018-06-12 Thread Leif Lindholm
On Thu, Jun 07, 2018 at 05:08:17PM +0200, Ard Biesheuvel wrote: > In commit 913fdda9f4b9 ("Silicon/SynQuacerPlatformFlashAccessLib: don't > dereference FVB header fields"), we dropped all accesses to FVB header > field, which was necessary because the flash partition may not in fact > contain such

Re: [edk2] [PATCH edk2-platforms 2/2] Silicon/NorFlashSynQuacerLib: describe entire firmware region as FV

2018-06-12 Thread Leif Lindholm
On Thu, Jun 07, 2018 at 05:08:18PM +0200, Ard Biesheuvel wrote: > In order to allow for more flexibility when updating parts of the > firmware via capsule update, expand the description of the code FV > to cover the entire 4 MB region at the base of the NOR flash. > > Contributed-under: TianoCore

Re: [edk2] [PATCH edk2-platforms 3/3] Silicon/SynQuacerPlatformFlashAccessLib: replace progress indication

2018-06-12 Thread Leif Lindholm
On Thu, Jun 07, 2018 at 01:32:03PM +0200, Ard Biesheuvel wrote: > Replace the home cooked progress indication with calls into the new > (*Progress)() argument to PerformFlashWriteWithProgress(), which > allows the flash access routine to report progress via a platform > provided callback. > >

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-12 Thread Leif Lindholm
So, I've made all the comments I was going to be making on this set. Patches 3,5-7,13,20-21 are fine as long as you drop pre-existing Signed-off-by and Reviewed-by, so if you get rid of those you can add Reviewed-by: Leif Lindholm when reposting. (If any patch apart from the above didn't

Re: [edk2] [platforms PATCH 25/25] Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:23PM +0200, Marcin Wojtas wrote: > Finally, after switching to new MV_BOARD_DESC solution > in all drivers, stop using MvHwDescLib.h by its last user > and safely remove this header. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin

Re: [edk2] [platforms PATCH 24/25] Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:22PM +0200, Marcin Wojtas wrote: > MvI2cDxe driver used to get Armada7k8k controller description > from hardcoded values stored in the header file MvHwDescLib.h. > As a result it is very hard to support other > Armada SoC families with this driver. > > This patch

Re: [edk2] [platforms PATCH 23/25] Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:21PM +0200, Marcin Wojtas wrote: > Introduce new callback that can provide information > about I2C controllers to the I2c driver. > > Extend ArmadaBoardDescLib with new structure MV_BOARD_I2C_DESC, > for holding board specific data. In further steps it should > be

Re: [edk2] [platforms PATCH 22/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:20PM +0200, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCDescI2cGet ()), > which dynamically allocates and fills MV_SOC_I2C_DESC structure with > the SoC description of I2c controllers. > > Contributed-under: TianoCore Contribution

Re: [edk2] [platforms PATCH 19/25] Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:17PM +0200, Marcin Wojtas wrote: > Introduce new callback that can provide information > about MDIO controllers to the Mdio driver. > > Extend ArmadaBoardDescLib with new structure MV_BOARD_MDIO_DESC, > for holding board specific data. > > Contributed-under:

Re: [edk2] [platforms PATCH 18/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:16PM +0200, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCDescMdioGet ()), > which dynamically allocates and fills MV_SOC_MDIO_DESC structure with > the SoC description of Mdio controllers. > > Contributed-under: TianoCore Contribution

Re: [edk2] [platforms PATCH 17/25] Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:15PM +0200, Marcin Wojtas wrote: > MvComPhyLib library used to get Armada7k8k SerDes multiplexing > controller description from hardcoded values stored in the header > file MvHwDescLib.h. As a result it is very hard to support other > Armada SoC families with this

Re: [edk2] [platforms PATCH 16/25] Marvell/Drivers: MvBoardDesc: Extend protocol with COMPHY support

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:14PM +0200, Marcin Wojtas wrote: > Introduce new callback that can provide information > about COMPHY controllers to the ComPhyLib. > > Extend ArmadaBoardDescLib with new structure MV_BOARD_COMPHY_DESC, > for holding board specific data. In further steps it can > be

Re: [edk2] [platforms PATCH 15/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:13PM +0200, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCDescComPhyGet ()), > which dynamically allocates and fills MV_SOC_COMPHY_DESC structure with > the SoC description of ComPhy SerDes controllers. > > Contributed-under: TianoCore

Re: [edk2] [platforms PATCH 14/25] Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:12PM +0200, Marcin Wojtas wrote: > ComPhy Library used to get Armada7k8k AHCI/SDMMC/XHCI controller > description from hardcoded values stored in the header file > MvHwDescLib.h. As a result it is very hard to support other > Armada SoC families with this library. >

Re: [edk2] [platforms PATCH 12/25] Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:10PM +0200, Marcin Wojtas wrote: > Introduce new callback that can provide information > about NonDiscoverableDevices to the relevant drivers and libraries. > > Extend ArmadaBoardDescLib with new structures (MV_BOARD_AHCI_DESC/ >

Re: [edk2] [platforms PATCH 10/25] Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:08PM +0200, Marcin Wojtas wrote: > Pp2Dxe driver used to get Armada7k8k PP2 controller description from > hardcoded values stored in the header file MvHwDescLib.h. > As a result it is very hard to support other Armada SoC families > with this driver. > > This patch

Re: [edk2] [RFC PATCH 00/11] GCC/X64: use hidden visibility for LTO PIE code

2018-06-12 Thread Zenith432
> Absolute symbol references such as? > References to fixed (constant) > addresses? Pointers stored in the .data section.  For example, if you have an array of const char*. >  Why is that approach optimal? As few > relocations records are required as > possible? small pic model is optimal for

Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommunicationLibUsb: Add endpoint configuration.

2018-06-12 Thread Marvin Häuser
Sorry, I made a mistake overlooking that the Initialization function is only called under certain circumstances. I will submit a V2 soon. Thanks, Marvin > -Original Message- > From: edk2-devel On Behalf Of Marvin > Häuser > Sent: Tuesday, June 12, 2018 2:34 PM > To:

Re: [edk2] [RFC PATCH 00/11] GCC/X64: use hidden visibility for LTO PIE code

2018-06-12 Thread Ard Biesheuvel
On 12 June 2018 at 20:33, Laszlo Ersek wrote: > Some super-naive questions, which are supposed to educate me, and not to > question the series: > > On 06/12/18 17:22, Ard Biesheuvel wrote: >> The GCC toolchain uses PIE mode when building code for X64, because it >> is the most efficient in size:

Re: [edk2] [platforms PATCH 11/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:09PM +0200, Marcin Wojtas wrote: > This patch introduces new library callbacks for NonDiscoverable devices > i.e. AHCI/XHCI/SDMMC. They dynamically allocate and fill according > structures with the SoC description of the devices. > > Contributed-under: TianoCore

Re: [edk2] [RFC PATCH 00/11] GCC/X64: use hidden visibility for LTO PIE code

2018-06-12 Thread Laszlo Ersek
Some super-naive questions, which are supposed to educate me, and not to question the series: On 06/12/18 17:22, Ard Biesheuvel wrote: > The GCC toolchain uses PIE mode when building code for X64, because it > is the most efficient in size: it uses relative references where > possible, but still

Re: [edk2] [platforms PATCH 08/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:06PM +0200, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCDescPp2Get ()), > which dynamically allocates and fills MV_SOC_PP2_DESC structure with > the SoC description of PP2 NICs. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [OvmfPkg] Secure Boot issues

2018-06-12 Thread Laszlo Ersek
On 06/12/18 16:51, Philipp Deppenwiese wrote: > Also Windows 10 in safe mode with secure boot works but not the > normal mode. > > We use the > 14393.0.160715-1616.RS1_RELEASE_CLIENTENTERPRISE_S_EVAL_X64 LTSB > release for testing. Interesting, this reminds me of the "new" driver signing

Re: [edk2] [PATCH v2 2/4] OvmfPkg: add QemuRamfbDxe

2018-06-12 Thread Laszlo Ersek
Hi Gerd, On 06/12/18 11:31, Gerd Hoffmann wrote: > Add a driver for the qemu ramfb display device. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/QemuRamfbDxe/QemuRamfb.c | 396 > ++ >

Re: [edk2] [PATCH v3 1/4] MdeModulePkg/CapsuleRuntimeDxe: clean the capsule payload to DRAM

2018-06-12 Thread Yao, Jiewen
Yes, I agree. Only runtime. Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, June 12, 2018 8:25 AM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Zeng, Star > ; Kinney, Michael D > Subject:

Re: [edk2] [platforms PATCH 04/25] Marvell/Drivers: MvBoardDescDxe: Introduce board description driver

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:02PM +0200, Marcin Wojtas wrote: > From: jinghua > > This patch introduces a producer of MARVELL_BOARD_DESC_PROTOCOL, which > gets SoC description from ArmadaSoCDescLib, then based on dsc file, > provide only enabled hardware module controllers for the consumers, >

Re: [edk2] [PATCH v2 4/4] ArmVirtPkg: add QemuRamfbDxe

2018-06-12 Thread Laszlo Ersek
On 06/12/18 11:31, Gerd Hoffmann wrote: > Add QemuRamfbDxe to dsc and fdf files for ArmVirt package. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- > ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + >

Re: [edk2] [PATCH v2 3/4] OvmfPkg: add QemuRamfb to platform console

2018-06-12 Thread Laszlo Ersek
On 06/12/18 11:31, Gerd Hoffmann wrote: > Add QemuRamfbDxe device path to the list of platform console devices, > so ConSplitter will pick up the device even though it isn't a PCI GPU. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- >

Re: [edk2] [PATCH v2 1/4] OvmfPkg: add QEMU_RAMFB_GUID

2018-06-12 Thread Laszlo Ersek
On 06/12/18 11:31, Gerd Hoffmann wrote: > Add GUID header file for the QemuRamfbDxe driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Guid/QemuRamfb.h | 25 + > OvmfPkg/OvmfPkg.dec | 1

Re: [edk2] [platforms PATCH 02/25] Marvell/Library: Introduce ArmadaBoardDescLib class

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:34:00PM +0200, Marcin Wojtas wrote: > This patch adds a new library class that will be helpful > to describe a per-board information, which will be > processed by BoardDesc protocol. > > Together with ArmadaSoCDescLib data it will be a flexible > solution allowing to

Re: [edk2] [PATCH v3 1/4] MdeModulePkg/CapsuleRuntimeDxe: clean the capsule payload to DRAM

2018-06-12 Thread Ard Biesheuvel
On 12 June 2018 at 17:23, Yao, Jiewen wrote: > Ard > Do you think we also need update QueryCapsuleCapabilities() to return > UNSUPPORTED for CAPSULE_FLAGS_PERSIST_ACROSS_RESET? > Yes, but only at runtime. I can update the patch if you like. >> -Original Message- >> From: Ard Biesheuvel

[edk2] [RFC PATCH 10/11] UefiCpuPkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- UefiCpuPkg/Library/PlatformSecLibNull/PlatformSecLibNull.c | 1 + 1 file changed,

[edk2] [RFC PATCH 11/11] MdePkg/ProcessorBind.h X64: drop non-LTO limitation on visiblity override

2018-06-12 Thread Ard Biesheuvel
When LTO is in effect, overriding the symbol visibility to 'hidden' using a GCC pragma used to result in module entry points being discarded, and along with them all other code in the binary. Now that we annotated all module entry points explicitly as having 'default' visibility, this is no

[edk2] [RFC PATCH 09/11] Nt32Pkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Nt32Pkg/Sec/SecMain.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [RFC PATCH 08/11] MdePkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Library/DxeCoreEntryPoint.h | 1 +

Re: [edk2] [PATCH v3 1/4] MdeModulePkg/CapsuleRuntimeDxe: clean the capsule payload to DRAM

2018-06-12 Thread Yao, Jiewen
Ard Do you think we also need update QueryCapsuleCapabilities() to return UNSUPPORTED for CAPSULE_FLAGS_PERSIST_ACROSS_RESET? Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, June 12, 2018 4:23 AM > To:

[edk2] [RFC PATCH 05/11] EmulatorPkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- EmulatorPkg/Sec/Sec.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [RFC PATCH 02/11] DuetPkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- DuetPkg/DxeIpl/DxeInit.c | 1 + DuetPkg/EfiLdr/EfiLoader.c | 1 + 2 files

[edk2] [RFC PATCH 04/11] EmbeddedPkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/TemplateSec/TemplateSec.c | 1 + 1 file changed, 1 insertion(+) diff

[edk2] [RFC PATCH 00/11] GCC/X64: use hidden visibility for LTO PIE code

2018-06-12 Thread Ard Biesheuvel
The GCC toolchain uses PIE mode when building code for X64, because it is the most efficient in size: it uses relative references where possible, but still uses 64-bit quantities for absolute symbol references, which is optimal for executables that need to be converted to PE/COFF using GenFw.

[edk2] [RFC PATCH 07/11] MdeModulePkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/CapsulePei/X64/X64Entry.c | 1 + 1 file changed, 1

[edk2] [RFC PATCH 06/11] IntelFrameWorkPkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DriverEntryPoint.c | 1 + 1 file

[edk2] [RFC PATCH 01/11] MdePkg/ProcessorBind.h: define macro to decorate module entry points

2018-06-12 Thread Ard Biesheuvel
Add a macro EFI_ENTRYPOINT that we will use to decorate functions that serve as the entry points for EFI modules. This is necessary to work around a limitation in GCC, which may prune such routines from the ELF binary if they are defined with hidden visibility, even if they are explicitly

[edk2] [RFC PATCH 03/11] EdkCompatibilityPkg: annotate module entry points with EFI_ENTRYPOINT

2018-06-12 Thread Ard Biesheuvel
Annotate module entry points with EFI_ENTRYPOINT so we can classify the resulting symbol as global explicitly at link time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [platforms PATCH 01/25] Marvell/Library: Introduce ArmadaSoCDescLib class

2018-06-12 Thread Leif Lindholm
On Fri, Jun 08, 2018 at 05:33:59PM +0200, Marcin Wojtas wrote: > From: jinghua > > ArmadaSoCDescLib is a per SoC family library, which provides SoC > description, like register base of some hardware module controller, > COMPHY/I2C/NETWORK etc., which right now is hardcoded in MvHwDescLib.h. >

Re: [edk2] [PATCH v2 1/5] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data

2018-06-12 Thread Kinney, Michael D
Ard, The UEFI Spec allows UpdateCapsule() to return EFI_UNSUPPORTED. So after ExitBootServices() UpdateCapsule() can return EFI_UNSUPPORTED for any capsule that has the CAPSULE_FLAGS_PERSIST_ACROSS_RESET flag set. Mike > -Original Message- > From: Ard Biesheuvel

Re: [edk2] [OvmfPkg] Secure Boot issues

2018-06-12 Thread Philipp Deppenwiese
Hey Laszlo, On 12.06.2018 15:59, Laszlo Ersek wrote: > On 06/12/18 15:12, Philipp Deppenwiese wrote: >> Hey people, >> >> We are experiencing issues with UEFI secure boot enabled >> on UDK 2018 for the OvmfPkg. > UDK2018 does not include OvmfPkg; no UDK does, to my knowledge. I mean the UDK2018

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
2018-06-12 16:33 GMT+02:00 Leif Lindholm : > On Tue, Jun 12, 2018 at 04:27:18PM +0200, Ard Biesheuvel wrote: >> On 12 June 2018 at 16:23, Leif Lindholm wrote: >> > I have only bikeshedding-level comments on this set, inline below. >> > (Applies to at lest 2-3.) >> > >> > On Tue, Jun 12, 2018 at

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Leif Lindholm
On Tue, Jun 12, 2018 at 04:27:18PM +0200, Ard Biesheuvel wrote: > On 12 June 2018 at 16:23, Leif Lindholm wrote: > > I have only bikeshedding-level comments on this set, inline below. > > (Applies to at lest 2-3.) > > > > On Tue, Jun 12, 2018 at 04:06:34PM +0200, Marcin Wojtas wrote: > >> Add new

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
2018-06-12 16:27 GMT+02:00 Ard Biesheuvel : > On 12 June 2018 at 16:23, Leif Lindholm wrote: >> I have only bikeshedding-level comments on this set, inline below. >> (Applies to at lest 2-3.) >> >> On Tue, Jun 12, 2018 at 04:06:34PM +0200, Marcin Wojtas wrote: >>> Add new board description file

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Ard Biesheuvel
On 12 June 2018 at 16:23, Leif Lindholm wrote: > I have only bikeshedding-level comments on this set, inline below. > (Applies to at lest 2-3.) > > On Tue, Jun 12, 2018 at 04:06:34PM +0200, Marcin Wojtas wrote: >> Add new board description file Armada80x0McBin.dsc, >> which uses common

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Leif Lindholm
I have only bikeshedding-level comments on this set, inline below. (Applies to at lest 2-3.) On Tue, Jun 12, 2018 at 04:06:34PM +0200, Marcin Wojtas wrote: > Add new board description file Armada80x0McBin.dsc, > which uses common Armada7k8k.fdf file. By default > build capsule components. > Most

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
2018-06-12 16:11 GMT+02:00 Ard Biesheuvel : > Marcin, > > Thanks for focusing on McBin first. > > > On 12 June 2018 at 16:06, Marcin Wojtas wrote: >> Add new board description file Armada80x0McBin.dsc, >> which uses common Armada7k8k.fdf file. By default >> build capsule components. >> Most of

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Ard Biesheuvel
Marcin, Thanks for focusing on McBin first. On 12 June 2018 at 16:06, Marcin Wojtas wrote: > Add new board description file Armada80x0McBin.dsc, > which uses common Armada7k8k.fdf file. By default > build capsule components. > Most of the interfaces are fully functional, except for: > - USB

[edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
Add new board description file Armada80x0McBin.dsc, which uses common Armada7k8k.fdf file. By default build capsule components. Most of the interfaces are fully functional, except for: - USB ports - it requires merging GPIO support and VBUS power supply enabling - SdMmc ports - they are kept

[edk2] [platforms: PATCH 3/3] Marvell/Armada7k8k: Introduce support for Armada-8040-Db

2018-06-12 Thread Marcin Wojtas
Add new board description file Armada80x0Db.dsc, which uses common Armada7k8k.fdf file. Most of the interfaces are fully functional, except for: - USB ports - it requires merging GPIO support and VBUS power supply enabling Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [platforms: PATCH 1/3] Marvell/Armada7k8k: Use common .fdf file

2018-06-12 Thread Marcin Wojtas
As for the preparation for adding multiple boards support, move common part of the .fdf file to the SoC family directory and change output FD file name to more generic. Once needed, possible per-board differences will be resolved by including custom .fdf.inc file. This way adding new common

[edk2] [platforms: PATCH 0/3] Armada7k8k new boards support

2018-06-12 Thread Marcin Wojtas
Hi, This short patchset introduces support for two Armada7k8k-based boards: MacchiatoBin and Armada-8040-Db. In order to avoid further duplication, they use common .fdf file for entire SoC family. More details can be found in the commit logs. The patches are available in the github:

  1   2   >