Hi Gary,
Patch 03 used some Tab characters, Patch 17 has some Trailing whitespace. You
can use the BaseTools\Scripts\PatchCheck.py to check its format.
I try to build OVMF platform, it directly report error:
from .BuildReport import BuildReport
ValueError: Attempted relative import in
On 6/22/2018 10:38 AM, Hao Wu wrote:
Introduces the below PPI:
struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI {
EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar;
EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATHGetNvmeHcDevicePath;
};
The GetNvmeHcMmioBar service will provide the caller
Reviewed-by: david@intel.com
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
-Original Message-
From: Guo, Mang
Sent: Friday, June 22, 2018 11:22 AM
To: edk2-devel@lists.01.org
Cc: Wei, David
Subject:
Set BIOS LOCK default value from 'disable' to 'enable' to meet security
requirement.
Cc: zwei4
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
---
.../Common/PlatformSettings/PlatformSetupDxe/SouthClusterConfig.vfi | 6 +++---
1 file changed, 3 insertions(+), 3
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Gao, Liming
> Sent: Monday, June 18, 2018 10:58 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Zeng, Star
> Subject: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage
> to match code logic
>
> BdsEntry
The driver now can recognize the BlockIo2 PPI for NVM Express devices.
And support identifying the recovery capsule on those devices.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
Reviewed-by: Ruiyu Ni
---
FatPkg/FatPei/FatLiteApi.c | 6 +-
Introduces the below PPI:
struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI {
EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar;
EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATHGetNvmeHcDevicePath;
};
The GetNvmeHcMmioBar service will provide the caller with the MMIO BAR
address of each NVMe HC
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=256
This commit adds the PEI BlockIo support for NVM Express devices.
The driver will consume the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI for NVM
Express host controllers within the system. And then produces the
BlockIo(2) PPIs for each
Cc: Eric Dong
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
Reviewed-by: Ruiyu Ni
Reviewed-by: Star Zeng
---
MdeModulePkg/Include/Guid/RecoveryDevice.h | 9 +
MdeModulePkg/MdeModulePkg.dec | 3 +++
2 files changed, 12
The series is also available at:
https://github.com/hwu25/edk2/tree/nvme_pei_blockio_v2
V2 updates:
Patch 1/4:
A. Remove the unnecessary input parameter 'PeiServices' from the 2
services of the EDKII PEI NVME host controller PPI.
B. Fix typo of 'DevicePathLenth' to 'DevicePathLength' within the
VS2017 reports warning LNK4281: undesirable base address 0x0 for x64 image;
set base address above 4GB for best ASLR optimization.
edk2 build always sets baes address to zero as default. So, ignore this link
warning.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming
Reviewed-by: Long Qin
Please correct the typos:
+ @retval EFI_SUCCESS DTPM2.0 instance is registered, or system dose not
surpport registr DTPM2.0 instance
V3: recreate the patch base on latest version
::= {"PCD(" ")"} {} {}
::= {} {"$(NAMED_GUID)"}
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
3_edk_ii_fdf_file_format/32_fdf_definition.md |
On Thu, Jun 21, 2018 at 12:40:29PM +, Zhu, Yonghong wrote:
> Hi Gary,
>
> Python 2.7 doesn't have the module builtins, if we apply this patch now, it
> will cause build failure on Python 2.7.
>
Urhh, I thought it's a "built-in" module but it's actually from
python-future.
I'll revert this
Reviewed-by: Eric Dong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, June 21, 2018 8:06 PM
To: edk2-devel@lists.01.org
Cc: Xu, WeiX
Subject: [edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh
Yes. GCC49_ARM_PREFIX can be reused. The difference in GCC49 and GCC49xASL is
ASL compiler. Their GCC part is same.
> -Original Message-
> From: Chris Co [mailto:christopher...@microsoft.com]
> Sent: Friday, June 22, 2018 9:28 AM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Cc: Zhu,
I think the code needs
1. Remove the check to S3 boot mode.
2. Use DEBUG_BLKIO in block read function.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express
devices
Cc:
Please fix typo 'DevicePathLenth' to 'DevicePathLength'.
With that, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Subject:
Cache TPM interface type info to avoid excessive interface ID register read
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Include/Library/Tpm2DeviceLib.h| 12 +++-
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, June 20, 2018 9:56 PM
> To: Chris Co ; edk2-devel@lists.01.org
> Cc: Zhu, Yonghong ; Leif Lindholm
>
> Subject: RE: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support
>
> Chris:
> I suggest to name this tool chain as
2018-06-21 17:06 GMT+02:00 Leif Lindholm :
>
> On Tue, Jun 19, 2018 at 12:58:19AM +0200, Marcin Wojtas wrote:
> > Hi,
> >
> > The third version of the patchset comes with the single Signed-off-by,
> > Reviewed-by's and corrected double parentheses in one of the headers.
> > For the details, please
Reviewed-by: Jaben Carsey
Note: I am not a maintainer of BaseTools and do not push commits for it :)
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gary Lin
> Sent: Wednesday, June 20, 2018 9:43 PM
> To: edk2-devel@lists.01.org
> Cc:
On Tue, Jun 19, 2018 at 12:58:19AM +0200, Marcin Wojtas wrote:
> Hi,
>
> The third version of the patchset comes with the single Signed-off-by,
> Reviewed-by's and corrected double parentheses in one of the headers.
> For the details, please check the changelog below.
>
> The patches are
On 20 June 2018 at 21:09, Ard Biesheuvel wrote:
> On 20 June 2018 at 18:39, Ard Biesheuvel wrote:
>> On 19 June 2018 at 22:52, Chris Co wrote:
>>> Hi,
>>>
>>> Just checking if there is anything needed on my end to get this patch
>>> merged in.
>>>
>>
>> Well, the patch looks obviously correct,
On 21 June 2018 at 16:01, Leif Lindholm wrote:
> On Thu, Jun 21, 2018 at 10:13:15AM +0200, Ard Biesheuvel wrote:
>> Given that these days, our ARM port only supports ARMv7 and later, we
>> can assume that the page table walker's memory accesses are cache
>> coherent, and so there is no need to
On Thu, Jun 21, 2018 at 10:13:15AM +0200, Ard Biesheuvel wrote:
> Given that these days, our ARM port only supports ARMv7 and later, we
> can assume that the page table walker's memory accesses are cache
> coherent, and so there is no need to perform cache maintenance. It
> does require the page
Hi Gary,
Python 2.7 doesn't have the module builtins, if we apply this patch now, it
will cause build failure on Python 2.7.
Best Regards,
Zhu Yonghong
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Thursday, June 21, 2018 12:44 PM
To: edk2-devel@lists.01.org
Cc: Zhu,
On Wed, Jun 20, 2018 at 05:42:54PM +0100, Sami Mujawar wrote:
> The OEM Table ID length cannot be more than 8 characters.
> Moreover, the ACPICA iASL compiler patch "Add error messages
> for ACPI tables with bad OEM and OEM Table IDs" dated
> 13 April 2018 [20180413]
>
Constructor is too early that ConnectAll() may not do. Move refresh boot
option in form open.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Xu WeiX
Reviewed-by: Liming Gao
---
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 3 +--
1 file changed,
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 21, 2018 3:46 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Zeng, Star; Dong, Eric; Yao, Jiewen
> Subject: RE: [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME
> device PEI BlockIo support
>
> 2 minor comments.
Ray,
Hi Ray,
Thanks for the feedbacks.
I will propose a V2 version of the series according to your comments.
Best Regards,
Hao Wu
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 21, 2018 3:36 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Zeng, Star; Dong, Eric; Yao, Jiewen
Peculiarly enough, the current page table manipulation code takes it
upon itself to write back and invalidate the memory contents covered
by section mappings when their memory attributes change. It is not
generally the case that data must be written back when such a change
occurs, even when
Follow up series to v2 'ArmMmuLib ARM: remove cache maintenance of block
mapping contents'
Patch #1 updated to remove more cache maintenance of memory *content*
Patch #2 added to remove cache maintenance of page table entries themselves,
and to remove support for storing page tables in memory
Given that these days, our ARM port only supports ARMv7 and later, we
can assume that the page table walker's memory accesses are cache
coherent, and so there is no need to perform cache maintenance. It
does require the page tables themselves to reside in memory mapped as
writeback cacheable so
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu,
>Yonghong
>Sent: Wednesday, June 13, 2018 9:13 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: remove the unneeded code
>
>Do a clean up to remove
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu,
>Yonghong
>Sent: Tuesday, June 19, 2018 9:11 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Enhance BaseTools supports FeaturePcd
>usage in VFR
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, June 15, 2018 3:04 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Zeng, Star ;
> Dong, Eric ; Ni, Ruiyu ; Yao,
> Jiewen
> Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, June 15, 2018 3:04 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Ni, Ruiyu ; Yao,
> Jiewen
> Subject: [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery capsule
> on NVME device
>
>
2 minor comments.
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, June 15, 2018 3:04 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Zeng, Star ;
> Dong, Eric ; Ni, Ruiyu ; Yao,
> Jiewen
> Subject: [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME
> device PEI
On Thu, Jun 21, 2018 at 12:43:28PM +0800, Gary Lin wrote:
> Convert "except ... ," to "except ... as" to be compatible with python3.
> Based on "futurize -f lib2to3.fixes.fix_except"
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Yonghong Zhu
> Cc: Liming Gao
> Signed-off-by:
On 21 June 2018 at 00:05, Leif Lindholm wrote:
> On Wed, Jun 20, 2018 at 09:10:07PM +0200, Ard Biesheuvel wrote:
>> Peculiarly enough, the current page table manipulation code takes it
>> upon itself to write back and invalidate the memory contents covered
>> by section mappings when their memory
42 matches
Mail list logo
