[edk2] [PATCH] BaseTools/VfrCompile: honor EXTRA_LDFLAGS

2018-08-16 Thread Laszlo Ersek
In commit 81502cee20ac ("BaseTools/Source/C: take EXTRA_LDFLAGS from the caller", 2018-08-16), I missed that "VfrCompile/GNUmakefile" does not use BUILD_LFLAGS in the APPLICATION linking rule, unlike "app.makefile" does. Instead, "VfrCompile/GNUmakefile" uses the (undefined) LFLAGS macro.

[edk2] [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5715] Stuff RSB before RSM

2018-08-16 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1093 Return Stack Buffer (RSB) is used to predict the target of RET instructions. When the RSB underflows, some processors may fall back to using branch predictors. This might impact software using the retpoline mitigation strategy on those

Re: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

2018-08-16 Thread Dong, Eric
Hi, Got your points now. I think we can update the code when new library API added. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, August 16, 2018 9:00 PM > To: edk2-devel@lists.01.org; Laszlo

Re: [edk2] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Add RSB stuffing before RSM instruction

2018-08-16 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, August 17, 2018 7:02 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen; Dong, Eric; Kinney, Michael D > Subject: Re: [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Add RSB stuffing > before RSM

Re: [edk2] [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant definition.

2018-08-16 Thread Li, Songpeng
The file "NetworkPkg/TlsDxe/TlsProtocol.c" which contains "NetworkPkg/TlsDxe/TlsImpl.h" is using the definition HTONS which defined in TlsProtocol.c: Line 264 *((UINT16 *) Data) = HTONS (TlsGetVersion (Instance->TlsConn)); NetLib.h: Line 230 #define HTONS(x) NTOHS(x) It cannot be

Re: [edk2] [PATCH v2 0/2] UefiCpuPkg: Add RSB stuffing before RSM instruction

2018-08-16 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Friday, August 17, 2018 5:09 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Kinney, Michael D; Yao, Jiewen; Dong, Eric > Subject: Re: [edk2] [PATCH v2 0/2] UefiCpuPkg:

Re: [edk2] [PATCH v2 0/2] UefiCpuPkg: Add RSB stuffing before RSM instruction

2018-08-16 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, August 17, 2018 4:05 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Kinney, Michael D; Yao, Jiewen; Dong, Eric > Subject: Re: [edk2] [PATCH v2 0/2] UefiCpuPkg: Add RSB stuffing before RSM > instruction

Re: [edk2] [PATCH 3/5] SecurityPkg: Remove unused PCDs

2018-08-16 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Zhang, Shenglei Sent: Thursday, August 16, 2018 1:32 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zhang, Chao B Subject: [PATCH 3/5] SecurityPkg: Remove unused PCDs The PCDs below are unused, so they have been removed from inf.

[edk2] [PATCH v1 1/1] BaseTools: remove unused code

2018-08-16 Thread Jaben Carsey
the if statment just has pass statement. invert if condition and just use do the else work. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/InfBuildData.py | 6 +- 1 file changed, 1

Re: [edk2] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Add RSB stuffing before RSM instruction

2018-08-16 Thread Laszlo Ersek
Beyond comments (1) through (4) which I made under the blurb (v2 0/2): On 08/16/18 05:14, Hao Wu wrote: > Return Stack Buffer (RSB) is used to predict the target of RET > instructions. When the RSB underflows, some processors may fall back to > using branch predictors. This might impact software

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Add RSB stuffing before RSM instruction

2018-08-16 Thread Laszlo Ersek
On 08/16/18 05:14, Hao Wu wrote: > Return Stack Buffer (RSB) is used to predict the target of RET > instructions. When the RSB underflows, some processors may fall back to > using branch predictors. This might impact software using the retpoline > mitigation strategy on those processors. > > This

Re: [edk2] [PATCH v2 0/2] UefiCpuPkg: Add RSB stuffing before RSM instruction

2018-08-16 Thread Laszlo Ersek
On 08/16/18 22:04, Laszlo Ersek wrote: > (1) [...] > (2) [...] > (3) [...] (4) Please reference in the commit messages as well; which is about the unification of the INC files. Thanks! Laszlo ___

Re: [edk2] [PATCH v2 0/2] UefiCpuPkg: Add RSB stuffing before RSM instruction

2018-08-16 Thread Laszlo Ersek
Hello Hao, On 08/16/18 05:14, Hao Wu wrote: > V2 changes: > A. Refine commit log message to clarify the purpose of the series > > B. Extract the RSB stuffing logic to INC files to avoid code duplication: > When compiling .NASM source files, the current build rule does not support > including

Re: [edk2] [PATCH 5/5] NetworkPkg: UefiPxeBcDxe: Remove the redundant code.

2018-08-16 Thread Laszlo Ersek
On 08/16/18 03:37, Songpeng Li wrote: > The function PxeBcFreeBootFileOption that is never called > have been removed. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Laszlo Ersek > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant definition.

2018-08-16 Thread Laszlo Ersek
On 08/16/18 03:37, Songpeng Li wrote: > The definition NetLib has been removed. (1) I suggest calling this "lib class dependency", not "definition". (I could have made the same for a GUID removed in a previous patch, but there "definition" seemed acceptable. "GUID dependency" would be an

Re: [edk2] [PATCH 3/5] NetworkPkg: TcpDxe: Remove the redundant code.

2018-08-16 Thread Laszlo Ersek
On 08/16/18 03:37, Songpeng Li wrote: > The function TcpPawsOK that is never called have been removed. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Laszlo Ersek > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH 1/5] NetworkPkg: IScsiDxe: Remove the redundant code and definition.

2018-08-16 Thread Laszlo Ersek
On 08/16/18 03:37, Songpeng Li wrote: > The function IScsiFindTcbByITT that is never called have been removed. > The definition gEfiAcpi20TableGuid has been removed. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Laszlo Ersek > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 >

Re: [edk2] [PATCH 1/1] OvmfPkg: link Sha384 and Sha512 support into Tcg2Pei and Tcg2Dxe

2018-08-16 Thread Laszlo Ersek
On 08/15/18 14:31, Laszlo Ersek wrote: > On 08/15/18 05:10, Gary Lin wrote: >> Sha384 and Sha512 were added to HashInstanceLib recently. To make them >> available in Tcg2Pei and Tcg2Dxe, we have to link both libraries. >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc:

Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

2018-08-16 Thread Laszlo Ersek
On 08/15/18 19:37, Gao, Liming wrote: > Laszlo: > The patch is good. Reviewed-by: Liming Gao Thanks! Pushed as commit range 9becf2f0759e..81502cee20ac. Laszlo > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, August 15, 2018 10:19 AM >>

Re: [edk2] [PATCH v2 0/7] UefiLib: centralize OpenFileByDevicePath() and fix its bugs

2018-08-16 Thread Laszlo Ersek
On 08/15/18 19:42, Gao, Liming wrote: > Laszlo: > Sorry to miss the patch. Thank you to update IntelFrameworkPkg UefiLib. The > change in MdePkg and IntelFrameworkPkg is good to me. Reviewed-by: Liming Gao > Thank you. Series pushed as commit range 52047be02430..9becf2f0759e. Laszlo > >>

Re: [edk2] [PATCH] ShellPkg/edit: Fix heap access out-of-bounds

2018-08-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, August 15, 2018 11:33 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Wang, Jian J > > Subject: [PATCH] ShellPkg/edit: Fix heap access out-of-bounds > Importance: High > > The issue was found

Re: [edk2] [PATCH 1/5] MdeModulePkg: Remove unused PCDs

2018-08-16 Thread Laszlo Ersek
On 08/16/18 08:30, Zeng, Star wrote: > Hi Shenglei, > > BaseLib is not belong to MdeModulePkg, please spit it into separated patch. I'd also like to review v2 of this series, please consider CC'ing me on it. Thanks, Laszlo > > Thanks, > Star > -Original Message- > From: Zhang,

[edk2] [edk2-wiki PATCH 2/2] release planning: link soft and hard feature freeze definitions

2018-08-16 Thread Laszlo Ersek
The "description" column refers to Soft Freeze and Hard Freeze, without explaining them. Link the definitions added in the previous patch. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek ---

[edk2] [edk2-wiki PATCH 1/2] release planning: describe the hard and soft feature freezes

2018-08-16 Thread Laszlo Ersek
Adopt QEMU's definitions for the soft and hard feature freezes, and update them for the edk2 process. (In particular, while we don't forbid such pull requests that are submitted to the mailing list, we usually apply patches from emails with git-am, rather than merge remote branches.) Cc: Andrew

[edk2] [edk2-wiki PATCH 0/2] document the Soft and Hard Feature Freezes

2018-08-16 Thread Laszlo Ersek
The recently added "EDK II Release Planning" wiki page refers to the Soft and Hard Feature Freezes, but the definitions are missing. This series provides them, and updates the planning page to link them. The pages can be read "live" in my wiki clone, by starting from

Re: [edk2] EDK II Stable Tag release edk2-stable201808 completed

2018-08-16 Thread Laszlo Ersek
On 08/16/18 00:28, Kinney, Michael D wrote: > Hello, > > The tag edk2-stable201808 has been created. > > https://github.com/tianocore/edk2/releases/tag/edk2-stable201808 > > git clone -b edk2-stable201808 https://github.com/tianocore/edk2.git > > The main EDK II Wiki page has been

Re: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

2018-08-16 Thread Marvin Häuser
Comments inline. Thanks and best regards, Marvin. > -Original Message- > From: Laszlo Ersek > Sent: Thursday, August 16, 2018 2:31 PM > To: Dong, Eric ; Marvin Häuser > ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: Re: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change >

Re: [edk2] [PATCH 0/2] UefiCpuPkg: Add RSB stuffing before rsm instruction

2018-08-16 Thread Laszlo Ersek
On 08/16/18 05:07, Wu, Hao A wrote: > I have filed a Bugzilla for adding $(INC)-like support when compiling > .NASM files: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1085 > > After some discussion with the BaseTools owners, some investigation is > needed for the above support. Hence, I

Re: [edk2] [PATCH 0/2] UefiCpuPkg: Add RSB stuffing before rsm instruction

2018-08-16 Thread Laszlo Ersek
On 08/16/18 05:07, Wu, Hao A wrote: >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Friday, August 10, 2018 11:06 PM >> (2) If I understand correctly, the same pattern is used everywhere -- a >> loop body is executed

Re: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

2018-08-16 Thread Laszlo Ersek
On 08/16/18 02:56, Dong, Eric wrote: > Hi Marvin & Laszlo, > > I'm not very clear about the risk to use this function name. I think it is > just used in a driver as an internal function, other drivers or libraries > can't use it. I think we don't need to add internal prefix to all internal >

[edk2] [PATCH edk2-non-osi v3 2/2] Silicon/Hisilicon/D06: Add Oem Shell libraries

2018-08-16 Thread Ming Huang
Add Hisilicon Oem Shell libraries for some commands,such as biosupdate, getmac, setmac, provision, acpistartos, brdinfo, sfpinfo. biosupdate example: ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1 biosupdate serverIp -u user -p password -f D06.fd -m master acpistartos example:

[edk2] [PATCH edk2-platforms v3 34/36] Hisilicon/D06: Add PciPlatformLib

2018-08-16 Thread Ming Huang
Add a Null PciPlatformLib for build D06. The switch generic PciHostBridge patch set add two api for PciPlatform driver, so need to implement the two api for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc

[edk2] [PATCH edk2-platforms v3 36/36] Platform/Hisilicon/D0x: Update version string to 18.08

2018-08-16 Thread Ming Huang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 2 +- Platform/Hisilicon/D05/D05.dsc | 2 +- Platform/Hisilicon/D06/D06.dsc | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-16 Thread Ming Huang
If install SPCR table, KVM will not output while install or boot some OS, like ubuntu, so add SPCR switch setup item and set it disable by default. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-non-osi v3 1/2] Hisilicon/D06: Add binary modules

2018-08-16 Thread Ming Huang
Description per Module: GetInfoFromBmc: Get board infomation from BMC and install a protocal. IoInitDxe: Serdes initialization and PCIe port initialization and SMMU workaround. IpmiInterfacePei: Install PEI ipmi interface PPI. IpmiInterfaceDxe: Install DXE ipmi interface protocal.

[edk2] [PATCH edk2-non-osi v3 0/2] Upload D06 binary modules

2018-08-16 Thread Ming Huang
This patch set include: 1 Add D06 binary modules; 2 Add oem shell libraries. Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: d06-non-osi-v3 Ming Huang (2): Hisilicon/D06: Add binary modules Silicon/Hisilicon/D06: Add Oem Shell libraries

[edk2] [PATCH edk2-platforms v3 35/36] Hisilicon/D06: Add edk2-non-osi Shell components

2018-08-16 Thread Ming Huang
Add Hisilicon Oem Shell libraries for some commands,such as biosupdate, getmac, setmac, provision, acpistartos, brdinfo, sfpinfo. biosupdate example: ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1 biosupdate serverIp -u user -p password -f D06.fd -m master acpistartos example:

[edk2] [PATCH edk2-platforms v3 33/36] Silicon/Hisilicon/setup: Support SMMU switch

2018-08-16 Thread Ming Huang
Select without SMMU iort while SMMU item is disable, Select with SMMU iort while SMMU item is enable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/HisiAcpiPlatformDxe/UpdateAcpiTable.c | 88 1 file changed,

[edk2] [PATCH edk2-platforms v3 25/36] Platform/Hisilicon/D06: Add EarlyConfigPeim peim

2018-08-16 Thread Ming Huang
This peim configuare SMMU,BSP,MN(Miscellaneous Node). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc| 1 + Platform/Hisilicon/D06/D06.fdf| 1 +

[edk2] [PATCH edk2-platforms v3 26/36] Platform/Hisilicon/D06: Add PciHostBridgeLib

2018-08-16 Thread Ming Huang
PciHostBridgeLib which is need by PciHostBridgeDxe, provide root bridges and deal with resource conflict. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 2 +-

[edk2] [PATCH edk2-platforms v3 30/36] Silicon/Hisilicon/D06: Modify for close slave core clock.

2018-08-16 Thread Ming Huang
From: ZhenYao When BIOS booting, the power consumption is too high, so need close some clusters clock that don't work to reduce power consumption. The implementation of functions is in edk2-non-osi. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhenYao ---

[edk2] [PATCH edk2-platforms v3 29/36] Platform/Hisilicon/D06: Add capsule upgrade support

2018-08-16 Thread Ming Huang
This module support updating the boot CPU firmware only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 14 Platform/Hisilicon/D06/D06.fdf

[edk2] [PATCH edk2-platforms v3 31/36] Silicon/Hisilicon/D06: Add I2C Bus Exception handle function

2018-08-16 Thread Ming Huang
During the period of I2c accessing, if the board is reset unexpectedly, and because the I2c client can not reset, the SDA will be always pull down, then it cause I2C bus Exception. Follow the Hi1620 I2C FS chapter 1.8.2 design, add I2C Bus Exception handle function. It will Config SCL and SDA to

[edk2] [PATCH edk2-platforms v3 27/36] Hisilicon/D06: add apei driver

2018-08-16 Thread Ming Huang
From: Luqi Jiang This driver provide a means for the platform to convey error information to OSPM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Luqi Jiang --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/D06.fdf

[edk2] [PATCH edk2-platforms v3 28/36] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-16 Thread Ming Huang
Add some Lpc macro to LpcLib.h for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/LpcLib.h | 51 +++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v3 19/36] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP"

2018-08-16 Thread Ming Huang
From: Yang XinYi Add Setup Item "EnableGOP" for D06, This Item only takes effect on VGA device SM750. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yang XinYi --- Silicon/Hisilicon/Include/Library/OemConfigData.h| 1 +

[edk2] [PATCH edk2-platforms v3 24/36] Hisilicon/D0x: Update SMBIOS type9 info

2018-08-16 Thread Ming Huang
From: Sun Yuanchen Move board level code to OemMiscLibD0x for unifying D0x. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sun Yuanchen --- Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf | 1 +

[edk2] [PATCH edk2-platforms v3 23/36] Platform/Hisilicon/D06: Add OemNicConfig2P Driver

2018-08-16 Thread Ming Huang
This Driver provide Get/Set Mac function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 2 +- Platform/Hisilicon/D06/D06.fdf | 2 +-

[edk2] [PATCH edk2-platforms v3 22/36] Platform/Hisilicon/D06: Add OemNicLib

2018-08-16 Thread Ming Huang
OemNicLib provide nic related api like GetMac,SetMac. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/Library/OemNicLib/OemNicLib.inf | 35 ++

[edk2] [PATCH edk2-platforms v3 15/36] Silicon/Hisilicon/D06: Fix I2C enable fail issue for D06

2018-08-16 Thread Ming Huang
I2C may enable failed in D06, so retry I2C enable while enable failed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v3 20/36] Hisilicon/Hi1620: Add ACPI PPTT table

2018-08-16 Thread Ming Huang
From: Heyi Guo This driver fetches information from MADT, so it is adaptable for partial good and 1P/2P, since MADT is updated for different configurations by certain mechanism. Since L2 cache is also private resource of core, so we need to set the next level of cache for L1I and L1D, which is

[edk2] [PATCH edk2-platforms v3 21/36] Platform/Hisilicon/D06: Enable ACPI PPTT

2018-08-16 Thread Ming Huang
From: Heyi Guo Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/D06.fdf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc index

[edk2] [PATCH edk2-platforms v3 13/36] Hisilicon/I2C: Modify I2CLib.c for coding style

2018-08-16 Thread Ming Huang
Correct coding style for I2CLib.c before adding other I2CLib patches. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 1034 ++-- 1 file changed, 499 insertions(+), 535 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v3 14/36] Silicon/Hisilicon/I2C: Refactor I2C library

2018-08-16 Thread Ming Huang
The hunk of waiting TX/TX finish is used by ten times, so move there hunks to a function CheckI2CTimeOut(). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 4 + Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 161

[edk2] [PATCH edk2-platforms v3 16/36] Silicon/Hisilicon/D06: Add I2C delay for HNS auto config

2018-08-16 Thread Ming Huang
Because I2C Port5 salve device connect under I2C extender (9545 device), it will cost more time to access I2C slave device, so add delay time for HNS auto config. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 3

[edk2] [PATCH edk2-platforms v3 18/36] Silicon/Hisilicon/D06: Optimize HNS config CDR post time

2018-08-16 Thread Ming Huang
From: shaochangliang Use I2C 400KB speed for config CDR. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH edk2-platforms v3 12/36] Silicon/Hisilicon/D06: Stop watchdog

2018-08-16 Thread Ming Huang
according as watchdog design on D06, watchdog should be stopped before boot a option. This is an out of band watchdog timer in BMC; it is used to monitor the whole BIOS boot process and reset the system in case BIOS hangs somewhere, i.e. it is armed when system is power on, and disabled before

[edk2] [PATCH edk2-platforms v3 17/36] Hisilicon/I2C: Fix a typo issue

2018-08-16 Thread Ming Huang
Modify spedd to Speed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 2 +- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v3 11/36] Hisilicon/D06: Add Hi1620OemConfigUiLib

2018-08-16 Thread Ming Huang
From: Yang XinYi This library is added for oem setup menu item. Setup item include: 1 DDR option item; 2 BMC option item; 3 Ras option item; 4 Misc option item; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yang XinYi --- Silicon/Hisilicon/HisiPkg.dec

[edk2] [PATCH edk2-platforms v3 09/36] Hisilicon/D06: Add Debug Serial Port Init Driver

2018-08-16 Thread Ming Huang
From: Heyi Guo Hi1620 have two physical PL011 serial ports on the board, one for serial port console (described by ACPI SPCR) and the other for standard debug port (described by ACPI DBG2). This driver is to initialize the debug UART, not the serial console. Contributed-under: TianoCore

[edk2] [PATCH edk2-platforms v3 08/36] Silicon/Hisilicon/Acpi: Unify HisiAcipPlatformDxe

2018-08-16 Thread Ming Huang
The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by UpdateAcpiTable.c and Srat aslc. The struct may be different according to chips, so move some macro to PlatformArch.h. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-platforms v3 02/36] Hisilicon/D0X: Rename the global variable gDS3231RtcDevice

2018-08-16 Thread Ming Huang
The global variable gDS3231RtcDevice is used by several modules included common module in HwPkg. Renaming it with a general name is proper. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/OemMiscLib.h

[edk2] [PATCH edk2-platforms v3 03/36] Hisilicon/D06: Add several base file for D06

2018-08-16 Thread Ming Huang
Add several base head files and add several build files for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dec | 29 ++ Platform/Hisilicon/D06/D06.dsc | 455

[edk2] [PATCH edk2-platforms v3 00/36] Upload for D06 platform

2018-08-16 Thread Ming Huang
The major features of this patchset include: 1 D06 source code; 2 Unify some D0x modules; This patch set is base on pcihostbridage-v2. For compiling D06, add below hunk to edk2-platforms.config [d06] LONGNAME=HiSilicon D06 DSC=Platform/Hisilicon/D06/D06.dsc ARCH=AARCH64 Code can also be found in

[edk2] [PATCH edk2-platforms v3 01/36] Hisilicon/D0x: Unify FlashFvbDxe driver

2018-08-16 Thread Ming Huang
Add PcdSFCMEM0BaseAddress and switch three 32-bit macro PcdFlashNvStorage of D05/D03 to 64-bit for unifying FlashFvbDxe driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.fdf| 6 +++---

[edk2] [PATCH edk2-platforms v3 07/36] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-16 Thread Ming Huang
This patch is relative to D06 SasDxe driver. The SasDxe set a variable to notice this libray. Here Wait for all disk ready for 15S at most. D06: For using straight-through hard disk backboard, some disk need 15 seconds to ready. Actually, wait less 15 seconds here(minus the time from end of SAS

[edk2] [PATCH edk2-platforms v3 05/36] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

2018-08-16 Thread Ming Huang
Add PcdCoreCount to fix build issue while add binary components. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 7 +++ Platform/Hisilicon/D06/D06.fdf

[edk2] [PATCH edk2-platforms v3 04/36] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib

2018-08-16 Thread Ming Huang
Add M41T83RealTimeClockLib for RTC. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 1 + Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf | 46 ++

Re: [edk2] [PATCH v2 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition

2018-08-16 Thread Leif Lindholm
On Thu, Aug 16, 2018 at 09:49:24AM +0800, Haojian Zhuang wrote: > Fix the LDO9_VSET register definition in PMIC. LDO9 is used > by Designware SD controller. Without this fix, SD controller > fails to operate SD card since lack of right voltage setting. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel

Re: [edk2] [PATCH edk2-non-osi v2 3/4] Hisilicon/D06: Add binary modules

2018-08-16 Thread Leif Lindholm
On Thu, Aug 16, 2018 at 10:14:14AM +0800, Ming wrote: > 在 8/15/2018 11:27 PM, Leif Lindholm 写道: > > Thanks, this commit message is a lot better. > > > > My only concern with this patch is that the binaries are built with a > > truly ancient toolchain. Is there some particular reason for this? >

Re: [edk2] [PATCH] ShellPkg/edit: Fix heap access out-of-bounds

2018-08-16 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, August 16, 2018 2:33 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Wang, Jian J > > Subject: [PATCH] ShellPkg/edit: Fix heap access out-of-bounds > > The issue was found when heap guard is turned

Re: [edk2] Question regarding CMOS regions.

2018-08-16 Thread Ramesh R .
1) To check the Extended RAM validity. * Read the Offset 0 from Extended RTC Ram. * If no 0 value, extended RTC Ram is present. * If it's 0xFF, write some value to Offset 0 * Read it back. If you get the value that you wrote, extended RTC RAM is present and

Re: [edk2] [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs

2018-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zhang, Shenglei Sent: Thursday, August 16, 2018 1:32 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel Subject: [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs The PCDs below are unused, so they have been removed from inf.

[edk2] [PATCH] ShellPkg/edit: Fix heap access out-of-bounds

2018-08-16 Thread Ruiyu Ni
The issue was found when heap guard is turned on. PrintLib somehow receives a non-null terminated string in var-arg. When the PrintLib implementation reads the string it keeps reading because no null-terminator is met, which triggers the page fault set by the heap guard. The issue is caused by a

Re: [edk2] [PATCH 1/5] MdeModulePkg: Remove unused PCDs

2018-08-16 Thread Zeng, Star
Hi Shenglei, BaseLib is not belong to MdeModulePkg, please spit it into separated patch. Thanks, Star -Original Message- From: Zhang, Shenglei Sent: Thursday, August 16, 2018 1:32 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 1/5] MdeModulePkg: Remove

Re: [edk2] Question regarding CMOS regions.

2018-08-16 Thread MohammadYounasKhan.P
Thanks Ruiyu. I have some inconsistencies with CMOS regions. Even EDKII uses some CMOS regions. I have attached the CMOS dump took using RW tool below: Type:ISA Port 0070,0071 Width:01 00=56 01=17 02=45 03=17 04=11 05=15 06=04 07=16 08=08 09=18 0A=26 0B=02 0C=50 0D=80 0E=00 0F=00 10=00

Re: [edk2] [PATCH 5/5] UefiCpuPkg: Remove an unused PCD

2018-08-16 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, August 16, 2018 1:32 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH 5/5] UefiCpuPkg: Remove an unused PCD > > The PCD below is unused, so it has been removed from inf. >

Re: [edk2] Question regarding CMOS regions.

2018-08-16 Thread Ni, Ruiyu
Younas, Why are you still working on CMOS in now UEFI world? Detailed answer is in below. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of > mohammadyounaskha...@dell.com > Sent: Thursday, August 16, 2018 12:44 PM > To: edk2-devel@lists.01.org > Subject: Re: [edk2]

Re: [edk2] [PATCH 4/5] ShellPkg: Remove unused PCDs

2018-08-16 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, August 16, 2018 1:32 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH 4/5] ShellPkg: Remove unused PCDs > > The PCDs below are unused, so they have been