[edk2] reg: Clarification required on ISCSI Initiator Implementation

2018-08-29 Thread Sivaraman Nainar
Hello All, As per the current ISCSI implementation there is only one Initiator name maintained even when there are multiple MAC and attempts are made from an UEFI system. Is there history behind not allowing to change the Initiator Name specific to MAC ? Thanks Siva

[edk2] [Patch] BaseTools: Involve Dec default value to calculate Maxsize

2018-08-29 Thread BobCF
Involve Dec default value to calculate Maxsize for structure PCD Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [edk2] [PATCH v2 0/9] Quality improvement for EmulatorPkg Win Host

2018-08-29 Thread Wu, Hao A
The series is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Thursday, August 30, 2018 10:02 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/9] Quality

[edk2] [PATCH v2 2/9] EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode

2018-08-29 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1118 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmuGopDxe/GopScreen.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH v2 1/9] EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure

2018-08-29 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1118 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmuGopDxe/GopInput.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH v2 5/9] EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit)

2018-08-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 6 +- EmulatorPkg/Win/Host/WinBlockIo.c | 2 +- EmulatorPkg/Win/Host/WinHost.c| 2 +- 3 files changed, 3 insertions(+), 7 deletions(-)

[edk2] [PATCH v2 4/9] EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState

2018-08-29 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1118 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/Win/Host/WinGopInput.c | 17 + 1 file changed, 17 insertions(+) diff --git

[edk2] [PATCH v2 8/9] EmulatorPkg: Use MdeModulePkg/Bds module

2018-08-29 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1120 Logo is enabled by adding a separate core driver LogoDxe. UiApp and BootManagerMenuApp are added to provide two UIs. LoadFileOnFv2 is added to auto-install LoadFile protocol for applications in FV so the boot options for applications can

[edk2] [PATCH v2 7/9] EmulatorPkg/Win: Add VS2017 project file

2018-08-29 Thread Ruiyu Ni
Developer can build the Win Host in VS2017 and launch to debug it. Platform 'x64' is to build 64bit EmulatorWin. Platform 'Win32' is to build 32bit EmulatorWin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish ---

[edk2] [PATCH v2 9/9] EmulatorPkg: IoThunk->Close() is called too early, may causing hang

2018-08-29 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1121 To produce a EFI_BLOCK_IO_PROTOCOL instance in Emulator platform, EmulatorPkg defines the EMU_IO_THUNK_PROTOCOL. OS dependent layer needs to produce this protocol implementation and a generic OS independent layer consumes this protocol to

[edk2] [PATCH v2 6/9] EmulatorPkg/AutoScanPei: Report the correct CPU address size

2018-08-29 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1119 Today's implementation reports CPU address size as 36 through CPU HOB. But when WinHost is running at 64bit, the system memory might be allocated above 2^36. It causes system asserts when DxeCore code tries to find the corresponding GCD

[edk2] [PATCH v2 3/9] EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation

2018-08-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao Wu Cc: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 1 + EmulatorPkg/Win/Host/WinGop.h | 4 +- EmulatorPkg/Win/Host/WinGopScreen.c | 218

[edk2] [PATCH v2 0/9] Quality improvement for EmulatorPkg Win Host

2018-08-29 Thread Ruiyu Ni
The patch sets make Win Host boot in 64 bit, fix all SCT issues regarding to console input/output, switch to use MdeModulePkg/Bds. v2: 1. Pass PatchChecker.py (VS project files don't pass. I don't want to change the default file content because next time when VS opens the project again

Re: [edk2] [PATCH v2 00/12] Add WinHost support in EmulatorPkg

2018-08-29 Thread Shia, Cinnamon
Hi Ray, Does this change mean that Nt32Pkg is going to be retired? Thanks Cinnamon Shia -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, August 23, 2018 5:56 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 00/12]

[edk2] Remove EDK package from edk2 master

2018-08-29 Thread Gao, Liming
EDK2 plans to retire EDK style packages. Below BZ requests to remove FatBinPkg, EdkShellPkg, EdkShellBinPkg and EdkCompatiblityPkg from edk2 master. They can be replaced by Edk2 FatPkg, ShellBinPkg and ShellPkg. UnixPkg is an empty package. So, it is also suggested to be removed. But, they are

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message

2018-08-29 Thread Wang, Jian J
Laszlo, Thanks for the comment. I’ll add the info. Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 29, 2018 9:54 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Dong, Eric Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message On

[edk2] [PATCH v1 8/9] BaseTools: refactor to not overcreate ModuleAutoGen objects

2018-08-29 Thread Jaben Carsey
currently created for 3 different purposes and saved once. this makes it created once and saved and then referenced. Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py

[edk2] [PATCH v1 9/9] BaseTools: refactor to cache InfBuildData data

2018-08-29 Thread Jaben Carsey
use Common.caching and auto cache properties and functions of InfBuildData Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/InfBuildData.py | 842 +--- 1 file

[edk2] [PATCH v1 4/9] BaseTools: refactor class properties

2018-08-29 Thread Jaben Carsey
use decorators and auto cache those that were cached manually remove properties never used Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Misc.py | 90 +--- 1 file changed,

[edk2] [PATCH v1 6/9] BaseTools: refactor Build Database objects

2018-08-29 Thread Jaben Carsey
1) use namedtuple instead of custom class when apropriate 2) rename collections.OrderedDict to OrderedDict since we import it already Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 5/9] BaseTools: Workspace classes refactor properties

2018-08-29 Thread Jaben Carsey
1) use decorators 2) also change some private functions to public when all callers are external 3) change external callers to use functions instead of directly accessing private data. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben

[edk2] [PATCH v1 3/9] BaseTools: AutoGen - refactor class properties

2018-08-29 Thread Jaben Carsey
use function decorators Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/GenMake.py | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git

[edk2] [PATCH v1 7/9] BaseTools: Don't save unused workspace data

2018-08-29 Thread Jaben Carsey
FlexibleFieldName was never used not set. DefinitionPosition (file and line number) are recalculated and never used outside the function. remove the saving of the data. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 1/9] BaseTools: Refactor PlatformAutoGen

2018-08-29 Thread Jaben Carsey
use decorators for property and automatic caching remove circular dependency between some APIs Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 587

[edk2] [PATCH v1 0/9] BaseTools: refactor Workspace classes

2018-08-29 Thread Jaben Carsey
update the classes for the following: 1) use decorators for property 2) use decorators for caching property and caching function - this allows for objects to reduce in size as they get used 3) remove unused variables and properties 4) use tuple instead of custom class when apropriate 5) remove

[edk2] [PATCH v1 2/9] BaseTools: AutoGen refactor WorkspaceAutoGen class

2018-08-29 Thread Jaben Carsey
Update the WorkspaceAutoGen class to use caching decorators and remove the no longer needed private variables. Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 69

[edk2] [PATCH v1 1/1] BaseTools: Clarify a DSC parsing error about PCDs

2018-08-29 Thread Jaben Carsey
This error needs the information about which DEC files were searched. Cc: Yonghong Zhu Cc: Liming Gao Cc: Lee Hamel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 1 file changed, 1

Re: [edk2] [Patch] BaseTools: Support multi thread build Basetool on Windows

2018-08-29 Thread Gao, Liming
Jaben: NmakeSubdirs.bat will be removed once NmakeSubdirs.py is stable. Now, bat is kept for a while. Thanks Liming > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, August 29, 2018 12:10 AM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; Guo, Dongao > Subject: Re:

[edk2] [PATCH v1 1/1] BaseTools: Refactor to remove functionally equivalent functions

2018-08-29 Thread Jaben Carsey
IsSupportedArch and IsBinaryModule return the same value under the same curcimstances. Remove newer one with fewer callers and send them to the other function. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message

2018-08-29 Thread Laszlo Ersek
On 08/29/18 05:21, Jian J Wang wrote: > It's reported the debug message in CpuDxe driver is quite annoying in > boot and shell, and slow down the boot process. To solve this issue, > this patch changes the DEBUG_INFO to DEBUG_VERBOSE. On a typical Intel > real platform, at least 16s boot time can

Re: [edk2] [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs

2018-08-29 Thread Laszlo Ersek
On 08/28/18 05:42, shenglei wrote: > The PCDs below are unused, so they have been removed from inf. > gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under:

Re: [edk2] [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD

2018-08-29 Thread Laszlo Ersek
On 08/28/18 05:42, shenglei wrote: > The PCD below is unused, so it has been removed from inf. > gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei >

Re: [edk2] [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs

2018-08-29 Thread Laszlo Ersek
On 08/28/18 05:42, shenglei wrote: > The PCDs below are unused, so they have been removed from inf. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize > gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore

Re: [edk2] [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs

2018-08-29 Thread Laszlo Ersek
On 08/28/18 05:42, shenglei wrote: > The PCDs below are unused, so they have been removed from inf. > gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId >

Re: [edk2] OSFC tickets

2018-08-29 Thread Richardson, Brian
Note there will be a TianoCore hack-a-thon as part of the conference, focused on Signed UEFI Capsule Update & Recovery. There are also a number of sessions & workshops related to TianoCore. More Info: https://github.com/tianocore/tianocore.github.io/wiki/OSFC-2018 Thanks ... br --- Brian

Re: [edk2] [Patch] BaseTools: Dynamic Pcd value override from command line.

2018-08-29 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, August 29, 2018 4:48 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Dynamic Pcd value override from command line. > > Fixed the pcd value override issue

[edk2] [PATCH edk2-platforms] sgi575/acpi: Use ACPI 6.2 specification

2018-08-29 Thread Chandni Cherukuri
Switched from using ACPI 6.1 to 6.2 specification for SGI575 since SBBR 1.1 requires ACPI 6.2 tables or later. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc | 8

Re: [edk2] [patch V3] ShellPkg/SmbiosView: Update SmbiosView for SMBIOS3.2.0

2018-08-29 Thread Zeng, Star
Dandan, thanks. Reviewed-by: Star Zeng Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 29, 2018 4:53 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu ; Zeng, Star Subject: [edk2] [patch V3]

[edk2] [PATCH 1/2] MdeModulePkg PeiCore: Handle multiple FV images in one FV file

2018-08-29 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1131 PI spec and BaseTools supports to generate multiple FV images in one FV file. This patch is to update PeiCore to handle the case. Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star

[edk2] [PATCH 2/2] MdeModulePkg DxeCore: Handle multiple FV images in one FV file

2018-08-29 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1131 PI spec and BaseTools supports to generate multiple FV images in one FV file. This patch is to update DxeCore to handle the case. Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star

[edk2] [PATCH 0/2] Core: Handle multiple FV images in one FV file

2018-08-29 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1131 Star Zeng (2): MdeModulePkg PeiCore: Handle multiple FV images in one FV file MdeModulePkg DxeCore: Handle multiple FV images in one FV file MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 241 ---

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer of MdeModulePkg

2018-08-29 Thread Laszlo Ersek
On 08/28/18 07:36, Star Zeng wrote: > Add Jian J Wang and > remove Eric Dong . > Eric is focusing on UefiCpuPkg. > > Cc: Jian J Wang > Cc: Eric Dong > Cc: Michael D Kinney > Cc: Laszlo Ersek > Cc: Andrew Fish > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 >

[edk2] [patch V3] ShellPkg/SmbiosView: Update SmbiosView for SMBIOS3.2.0

2018-08-29 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099 Update SmbiosView to parse the new definitions which are introduced in SMBIOS3.2.0 V2: 1. Add structure length check before dump the fileds in Type 9 and Type 17 in case some fileds are not organized and reported by drivers. 2. Dump the

[edk2] [PATCH v2] MdeModulePkg/Network: Add 32bit subnet mask support for IP4 PXE boot.

2018-08-29 Thread Fu Siyuan
V2 update: The original patch has a problem, that if an IP child which not using default address is configured with /32 subnet mask, while the gateway is configured to the default route table, then the gateway won't take effect on that IP child. This patch fixed the problem. This patch updates

[edk2] [Patch] BaseTools: Dynamic Pcd value override from command line.

2018-08-29 Thread BobCF
Fixed the pcd value override issue when Dynamic Pcd is from command line but is not list in Dsc file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 7 ++- 1 file changed, 6

[edk2] OSFC tickets

2018-08-29 Thread Philipp Deppenwiese
Friendly reminder. 2 days until the ticket sale is closed. Buy your tickets now https://osfc.io/tickets ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-08-29 Thread Sumit Garg
Hi Bhupesh, On Wed, 29 Aug 2018 at 11:11, Bhupesh Sharma wrote: > > Hi Sumit, > > On Tue, Aug 28, 2018 at 10:04 PM, Sumit Garg wrote: > > Hi Achin, > > > > On Tue, 28 Aug 2018 at 18:38, Achin Gupta wrote: > >> > >> Hi Sumit, > >> > >> Apologies for not replying sooner. Some questions and

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Graphic Change.

2018-08-29 Thread zwei4
(1) Fixed the issue that the VBT passed to OS is not the right VBT file. All boards are affected. (2) For UP2, disable Onboard LSPCON for HDMI 2.0 in VBT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mike Wu CC: Mang Guo ---

Re: [edk2] [PATCH v1 1/1] BaseTools: Create and use a shared value for 'MSFT' from DataType

2018-08-29 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, August 25, 2018 12:33 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools: Create and use a shared value for 'MSFT'