Re: [edk2] Missing ‘or’ in CLA

2018-09-01 Thread Henri Yandell
As patch text (sorry, was on a phone for the first email and forgot I could
generate the patch from GitHub via url):

From 86403de1826e3bcf860497c69141b40082ec56a5 Mon Sep 17 00:00:00 2001
From: Henri Yandell 
Date: Wed, 29 Aug 2018 22:31:39 -0700
Subject: [PATCH] Adding missing 'or'

When the CLA was created from the Apache ICLA, the option for a CCLA
was removed. When this was done the 'or' was lost in the text. This
puts it back in so that you represent that you have received
permission __or__ your employer has waived such rights.
---
 Contributions.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Contributions.txt b/Contributions.txt
index f34626912a4..7859435c175 100644
--- a/Contributions.txt
+++ b/Contributions.txt
@@ -201,7 +201,7 @@ title, and interest in and to Your Contributions.
   license. If your employer(s) has rights to intellectual property
   that You create that includes Your Contributions, You represent
   that You have received permission to make Contributions on behalf
-  of that employer, that Your employer has waived such rights for
+  of that employer or that Your employer has waived such rights for
   Your Contributions.
 * You represent that each of Your Contributions is Your original
   creation (see Section 4 for submissions on behalf of others).


On Fri, Aug 31, 2018 at 12:30 PM Laszlo Ersek  wrote:

> Mike,
>
> On 08/31/18 01:58, Henri Yandell wrote:
> > The CLA is missing an ‘or’ in section 3.
> >
> > See https://github.com/tianocore/edk2/pull/133/files for an example of
> the
> > specific text.
>
> could you please turn this report into a real patch (if the suggested
> change is valid)? Technically it's easy enough so I could do it as well,
> just so we have something to review on the list, but:
> - I have no idea if the suggested change is valid,
> - I wasn't around when "Contributions.txt" was originally invented.
>
> Thanks
> Laszlo
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [PATCH v1 edk-platforms 1/2] Platform/HiKey960: add PL011UartClockLib

2018-09-01 Thread Udit Kumar



> -Original Message-
> From: edk2-devel  On Behalf Of Haojian
> Zhuang
> Sent: Thursday, August 9, 2018 8:16 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v1 edk-platforms 1/2] Platform/HiKey960: add
> PL011UartClockLib
> 
> Since PL011UartClockLib is required by PL011 SerialPortLib.
> 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang 
> ---
>  Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> index be13714b9c19..15990b788336 100644
> --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> @@ -45,6 +45,7 @@ [LibraryClasses.common]
>DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> 
> +
> PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartCl
> ockLib.inf

I think, this lib is part of common dsc of HiSilicon platforms . 
 
> SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib
> .inf
> 
> RealTimeClockLib|ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031Re
> alTimeClockLib.inf
>TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> --
> 2.7.4
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> develdata=02%7C01%7Cudit.kumar%40nxp.com%7C6ace3239bab84b
> e9ded708d5fda23ca8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%
> 7C636693795605123423sdata=ixi5vsyZ1Z471FoRFlCRvRx9IrcNGgXY3gt
> 3QglboA8%3Dreserved=0
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel