[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Setup Cleanup

2018-09-29 Thread zwei4
Remove TPM setup option. Add fixed PCD gPlatformModuleTokenSpaceGuid.PcdTpmControl to enable/disable TPM at build-time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mike Wu CC: Mang Guo CC: Steele Kelly --- .../Common/Include/Guid/SetupVariable.h

Re: [edk2] [PATCH v1] MinPlatformPkg/Test: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Wu, Hao A
Please ignore this one. Some more information need to be added in the subject line. Another patch mail has been sent out to address this. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao > Wu > Sent: Sunday,

[edk2] [PATCH v1][edk2-platforms/devel-MinPlatform] MinPlatformPkg/Test: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Hao Wu
Speculative execution is used by processor to avoid having to wait for data to arrive from memory, or for previous operations to finish, the processor may speculate as to what will be executed. If the speculation is incorrect, the speculatively executed instructions might leave hints such as

[edk2] [PATCH v1] MinPlatformPkg/Test: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Hao Wu
Speculative execution is used by processor to avoid having to wait for data to arrive from memory, or for previous operations to finish, the processor may speculate as to what will be executed. If the speculation is incorrect, the speculatively executed instructions might leave hints such as

Re: [edk2] [PATCH v3 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

2018-09-29 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Sunday, September 30, 2018 1:34 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Kinney, Michael D; Yao, Jiewen > Subject: Re: [edk2] [PATCH v3 0/5] [CVE-2017-5753] Bounds

Re: [edk2] [Patch] FDF spec: Support Structure PCD field assignment syntax in [Defines] section

2018-09-29 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Sunday, September 30, 2018 10:08 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] FDF spec: Support Structure PCD field assignment syntax in [Defines] section

[edk2] [Patch] FDF spec: Support Structure PCD field assignment syntax in [Defines] section

2018-09-29 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_fdf_file_format/34_[defines]_section.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/3_edk_ii_fdf_file_format/34_[defines]_section.md

Re: [edk2] [Patch] BaseTools: refactor the error for PCD value is negative or exceed max

2018-09-29 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Saturday, September 29, 2018 11:08 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools:

Re: [edk2] [edk2-ModuleWriteGuide] Create repository for EDKII Module Write Guide document

2018-09-29 Thread Gao, Liming
Hi, all EDKII Module Write Guide gitboot contents have been published into https://github.com/tianocore-docs/edk2-ModuleWriteGuide.git. And, this doc is also added into https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Draft-Specification. If you have interest, please help

Re: [edk2] [PATCH] ShellPkg ShellLib.h: Fix wrong parameter name for ShellOpenFileByName

2018-09-29 Thread Zeng, Star
Ray, Thanks. I did not check the detail. But at least, one of definition and implementation needs to be updated. Maybe the description need to be enhanced also as you described. ShellLib.h: EFI_STATUS EFIAPI ShellOpenFileByDevicePath( IN OUT EFI_DEVICE_PATH_PROTOCOL **FilePath, OUT

Re: [edk2] [PATCH] ShellPkg ShellLib.h: Fix wrong parameter name for ShellOpenFileByName

2018-09-29 Thread Ni, Ruiyu
Star, Per my understanding, FilePath means the full path pointing to the file, FileName means the very last part of the full path. E.g.: "fs0:\a\b\c\d.txt" is a FilePath, "d.txt" is a FileName. So I think only specifying FileName is not enough to identify a file. The parameter name should be

Re: [edk2] [Patch] UefiCpuPkg/Include/Register/Msr/GoldmontPlusMsr.h: Change to DOS format file.

2018-09-29 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Saturday, September 29, 2018 9:38 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Laszlo Ersek > Subject: [edk2] [Patch] >

Re: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups

2018-09-29 Thread Laszlo Ersek
On 09/30/18 00:23, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: inline_asm_rw_ops_1208 > > This series mainly fixes the operand constraints (missing input-output > qualifications) in "BaseSynchronizationLib/*/GccInline.c". > > (It would be better to remove these

[edk2] [PATCH 5/5] MdePkg/BaseSynchronizationLib GCC: simplify IA32 InternalSyncCompareExchange64()

2018-09-29 Thread Laszlo Ersek
The IA32 variant of InternalSyncCompareExchange64() is correct, but we can simplify it. We don't need to load the lower 32 bits of ExchangeValue into EBX in two steps (first into a general register, then into EBX); we can ask GCC to populate EBX like that itself. Cc: Liming Gao Cc: Michael D

[edk2] [PATCH 3/5] MdePkg/BaseSynchronizationLib GCC: fix InternalSyncCompareExchange32()

2018-09-29 Thread Laszlo Ersek
(This patch is identical to the last one, except for the InternalSyncCompareExchange16() -> InternalSyncCompareExchange32() and "cmpxchgw" -> "cmpxchgl" replacements.) The CMPXCHG instruction has the following operands: - AX (implicit, CompareValue):input and output - destination operand

[edk2] [PATCH 2/5] MdePkg/BaseSynchronizationLib GCC: fix InternalSyncCompareExchange16()

2018-09-29 Thread Laszlo Ersek
The CMPXCHG instruction has the following operands: - AX (implicit, CompareValue):input and output - destination operand (*Value): input and output - source operand (ExchangeValue): input The IA32 version of InternalSyncCompareExchange16() correctly marks CompareValue as input/output, but

[edk2] [PATCH 4/5] MdePkg/BaseSynchronizationLib GCC: fix X64 InternalSyncCompareExchange64()

2018-09-29 Thread Laszlo Ersek
(This patch is identical to the X64 half of the last one, except for the InternalSyncCompareExchange32() -> InternalSyncCompareExchange64() and "cmpxchgl" -> "cmpxchgq" replacements.) The CMPXCHG instruction has the following operands: - AX (implicit, CompareValue):input and output -

[edk2] [PATCH 1/5] MdePkg/BaseSynchronizationLib GCC: fix whitespace and comments

2018-09-29 Thread Laszlo Ersek
The "GccInline.c" files have some inconsistent whitespace, and missing (or incorrect) operand comments. Fix and unify them. This patch doesn't change behavior. Cc: Liming Gao Cc: Michael D Kinney Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1208 Contributed-under: TianoCore Contribution

[edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups

2018-09-29 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: inline_asm_rw_ops_1208 This series mainly fixes the operand constraints (missing input-output qualifications) in "BaseSynchronizationLib/*/GccInline.c". (It would be better to remove these files altogether in favor of the already existing NASM

Re: [edk2] [PATCH v3 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

2018-09-29 Thread Laszlo Ersek
On 09/29/18 08:57, Hao Wu wrote: > V3 changes: > A. Fix wrong file (should be LoadFenceSmm.c) gets listed in >MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf > > B. Rename the newly introduced internal function from 'VariableLoadFence' >to 'MemoryLoadFence' within >

Re: [edk2] [Patch] UefiCpuPkg/Include/Register/Msr/GoldmontPlusMsr.h: Change to DOS format file.

2018-09-29 Thread Laszlo Ersek
On 09/29/18 03:37, Eric Dong wrote: > Follow EDKII coding style, change file format to dos style. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1213 > > Cc: Dandan Bi > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- >

[edk2] [PATCH] ShellPkg ShellLib.h: Fix wrong parameter name for ShellOpenFileByName

2018-09-29 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1221 The parameter name FilePath should be FileName. I am trying to write an application for my own use and want to use this interface, but confused by the parameter name. Interesting, the implementation in UefiShellLib.c is correct. Cc:

[edk2] [Patch] BaseTools: do basic check in FvImage with header size and signature

2018-09-29 Thread Yonghong Zhu
From: zhijufan Add some basic check in FvImage with header size and signature. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1181 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/GenFds/Fv.py

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup Setup Option

2018-09-29 Thread zwei4
Remove SecureBoot setup option. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mike Wu CC: Mang Guo CC: Steele Kelly --- .../Smbios/SmBiosMiscDxe/MiscOemType0x94Function.c | 11 +- .../Smbios/SmBiosMiscDxe/SmBiosMiscDxe.inf | 1 +

[edk2] [PATCH v3 1/5] MdePkg/BaseLib: Add new AsmLfence API

2018-09-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1193 This commit will add a new BaseLib API AsmLfence(). This API will perform a serializing operation on all load-from-memory instructions that were issued prior to the call of this function. Please note that this API is only available on IA-32

[edk2] [PATCH v3 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass

2018-09-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1194 Speculative execution is used by processor to avoid having to wait for data to arrive from memory, or for previous operations to finish, the processor may speculate as to what will be executed. If the speculation is incorrect, the

[edk2] [PATCH v3 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1194 Speculative execution is used by processor to avoid having to wait for data to arrive from memory, or for previous operations to finish, the processor may speculate as to what will be executed. If the speculation is incorrect, the

[edk2] [PATCH v3 3/5] MdeModulePkg/SmmLockBox: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1194 Speculative execution is used by processor to avoid having to wait for data to arrive from memory, or for previous operations to finish, the processor may speculate as to what will be executed. If the speculation is incorrect, the

Re: [edk2] [PATCH v2 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass

2018-09-29 Thread Zeng, Star
Got it, thanks. Reviewed-by: Star Zeng Star -Original Message- From: Wu, Hao A Sent: Saturday, September 29, 2018 2:21 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [PATCH v2 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass >

Re: [edk2] [PATCH v2 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass

2018-09-29 Thread Wu, Hao A
> -Original Message- > From: Zeng, Star > Sent: Saturday, September 29, 2018 2:11 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen; Zeng, Star > Subject: RE: [PATCH v2 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017- > 5753]Fix bounds check bypass > > Please double check

Re: [edk2] [PATCH v2 4/5] MdeModulePkg/Variable: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Zeng, Star
VariableSmm.inf is including LoadFenceDxe.c, it should be LoadFenceSmm.c. I also suggest using MemoryLoadFence instead of VariableLoadFence as the name. With them corrected, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, September 25, 2018 2:13

Re: [edk2] [PATCH v2 3/5] MdeModulePkg/SmmLockBox: [CVE-2017-5753] Fix bounds check bypass

2018-09-29 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Tuesday, September 25, 2018 2:13 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Yao, Jiewen ; Zeng, Star Subject: [PATCH v2 3/5] MdeModulePkg/SmmLockBox: [CVE-2017-5753] Fix bounds check bypass

Re: [edk2] [PATCH v2 2/5] MdeModulePkg/FaultTolerantWrite:[CVE-2017-5753]Fix bounds check bypass

2018-09-29 Thread Zeng, Star
Please double check whether the AsmLfence calling should be before the line below. PrivateData = (VOID *)>Data[Length]; Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, September 25, 2018 2:13 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Yao, Jiewen ; Zeng,