On Wed, 12 Dec 2018 at 01:24, Gao, Liming wrote:
>
> That's good. Reviewed-by: Liming Gao
>
Thanks all
Pushed as e07092edca84..0d68ce514b92
> >-Original Message-
> >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> >Sent: Tuesday, December 11, 2018 9:46 PM
> >To: Gao, Liming
Name macros appropriately to follow the rule
in coding standards specification.
Change the following macro from variable style
HwErrRecVariableNameLength
HwErrRecVariableNamePrefixLength
HwErrRecVariableNameIndexLength
to macro style.
HW_ERR_REC_VARIABLE_NAME_LEN
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, December 07, 2018 7:23 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Wang,
> Jian J ; Wu, Hao A ; Leif
> Lindholm ; Laszlo
Hello,
I think it's better to separate different toolchains in different files and use
"include" to include them. This can significantly reduce the difficulty of
maintenance and anyone who still wants/has to use older toolchains can have a
chance to follow the edk2-master.
Old toolchains
Hi, all
I don't get any comments on this change. So, I will push it this week.
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Liming Gao
>Sent: Wednesday, December 05, 2018 10:49 PM
>To: edk2-devel@lists.01.org
>Subject:
Get it. I will keep it.
Thanks
Liming
From: David F. [mailto:df7...@gmail.com]
Sent: Wednesday, December 12, 2018 6:58 AM
To: Gao, Liming
Cc: Ard Biesheuvel ; Laszlo Ersek
; edk2 developers list
Subject: Re: [edk2] [PATCH] BaseTools/Conf/tools_def.template: drop ARM/AARCH
support from
That's good. Reviewed-by: Liming Gao
>-Original Message-
>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>Sent: Tuesday, December 11, 2018 9:46 PM
>To: Gao, Liming
>Cc: Leif Lindholm ; edk2-devel@lists.01.org; Laszlo
>Ersek ; Feng, Bob C
>Subject: Re: [PATCH] BaseTools/GenFw
I missed that it was for the build-tool source itself and not for the
targets that are built using edk2 and the API itself.
On Tue, Dec 11, 2018 at 2:55 PM Ard Biesheuvel
wrote:
> On Tue, 11 Dec 2018 at 23:53, David F. wrote:
> >
> > I don't know, to me it's very clear that UINTN is talking
As far as VS2008 - That's what I use for all my UEFI work. So don't drop
that, it's not obsolete, it's still usable.
On Tue, Dec 11, 2018 at 5:27 AM Gao, Liming wrote:
> Ard:
> This patch is good. It belongs to the part of BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377. I give
On Tue, 11 Dec 2018 at 23:53, David F. wrote:
>
> I don't know, to me it's very clear that UINTN is talking about the target,
> just like size_t would be.
>
But which target? This change is against the source of the BaseTools,
which are host tools that can be used to build a single target image
I don't know, to me it's very clear that UINTN is talking about the target,
just like size_t would be.
There are/were a bunch of API's using UINTN so using UINTN was desirable,
and where needed UINTN_MAX.
I just don't see an advantage to removing it. Do see disadvantage to
removing it for
On Tue, 11 Dec 2018 at 21:16, Pete Batard wrote:
>
> Hi Leif,
>
> On 2018.12.11 18:10, Leif Lindholm wrote:
> > Hi Pete,
> >
> > Many thanks for this.
> > I expect Ard will give more detailed review, since he has some
> > familiarity with the port. But I wanted to make a few comments.
> >
> >
Hi Leif,
On 2018.12.11 18:10, Leif Lindholm wrote:
Hi Pete,
Many thanks for this.
I expect Ard will give more detailed review, since he has some
familiarity with the port. But I wanted to make a few comments.
Could you cc me as well on any future revisions?
Will do.
On Mon, Dec 10, 2018
We will be preforming maintenance on our Bugzilla instance at 15:00 GMT
on Wednesday December 12th (7am PST).
There is no specific issue that we are patching. This is general
proactive maintenance.
I will send an email at the start and end of the maintenance, and
communicate any updates to
Align the ACPI platform driver with the DT patching code, which only
enables the IPMI/KCS device node on B1 silicon (or later).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 3 ++-
1 file
Get rid of the CPP conditionals, and use the new boolean PCD for KCS
support instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 1 +
Now that all code references the PCD instead, let's drop the macro
from all Styx platforms.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 8
In order to get rid of another CPP macro, introduce a boolean PCD
that we will set in the platform to enable IPMI/KCS support.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/AmdStyx.dec| 1 +
We already have a boolean PCD that tells us whether XGBE support should
be enabled, so use it instead of C preprocessor conditionals.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 1 +
We already have a boolean PCD that tells us whether XGBE support should
be enabled, so use it instead of C preprocessor conditionals.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/Drivers/PlatInitPei/PlatInitPei.inf | 1 +
Move the IPMI/KCS device node from the DSDT into its own SSDT, and only
install it if we have support for KCS enabled in the platform.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +
Now that all code relies on the PCD rather than the DO_XGBE macro,
get rid of it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 9 ++---
Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 2 --
2
I promise :-)
This gets rid of the last build config options passed via the command
line into the preprocessor, and replaces them with PCD references.
Ard Biesheuvel (11):
Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes
Platform/SoftIron/Overdrive1000Board: remove dead XGBE
The I/O Remapping Table (IORT) does not require that each device of
which it describes the I/O remapping actually exists in the namespace.
So let's simplify the code by always including the XGBE nodes, and
just let them be unused if the platform does not include XGBE controllers.
Remove the references to the XGBE SNP drivers, which are inside a
!ifdef() that never gets enabled anyway.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 8
1 file changed, 8
We already have a boolean PCD that tells us whether XGBE support should
be enabled, so use it instead of C preprocessor conditionals.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 +
On Mon, Nov 26, 2018 at 02:52:14PM +, Nariman Poushin wrote:
> Openssl is fetched as a git submodule, so make sure git clone --recursive
> is specified in the instructions to fetch a full source tree.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Nariman Poushin
Hi Pete,
Many thanks for this.
I expect Ard will give more detailed review, since he has some
familiarity with the port. But I wanted to make a few comments.
Could you cc me as well on any future revisions?
On Mon, Dec 10, 2018 at 12:38:33PM +, Pete Batard wrote:
> Version History:
>
> *
On Tue, 11 Dec 2018 at 13:19, Ard Biesheuvel wrote:
>
> Patch #1 reshuffles the .dsc contents of ArmVirtQemuKernel so that we
> can run on ARM targets as well.
>
> Patch #2 fixes the CLANG38 build for ArmVirtQemuKernel and ArmVirtXen,
> by tweaking the linker options passed to emit the
On Tue, 11 Dec 2018 at 16:53, Leif Lindholm wrote:
>
> On Tue, Dec 11, 2018 at 04:02:31PM +0100, Ard Biesheuvel wrote:
> > Another day, another round of cleanups for Styx. Patch #1 was sent out
> > earlier, and has been updated to switch to a VOID* type PCD. Remaining
> > patches are various
On Thu, 6 Dec 2018 at 13:51, Wu, Hao A wrote:
>
> > -Original Message-
> > From: Ni, Ruiyu
> > Sent: Wednesday, December 05, 2018 5:25 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A
> > Subject: [PATCH] MdeModulePkg/PciBus: Shadow option ROM after BARs
> > are programmed
> >
> >
On 12/11/18 13:58, Ard Biesheuvel wrote:
> On Tue, 11 Dec 2018 at 13:57, Leif Lindholm wrote:
>>
>> Not my package, but a couple of minor style/language comments below
>> (because this is awkward enough any future readers/users will need all
>> the help they can get).
>>
>> On Tue, Dec 11, 2018
On Tue, 11 Dec 2018 at 10:06, Ard Biesheuvel wrote:
>
> On Tue, 11 Dec 2018 at 10:04, Sumit Garg wrote:
> >
> > On Tue, 11 Dec 2018 at 13:56, Ard Biesheuvel
> > wrote:
> > >
> > > On Tue, 11 Dec 2018 at 08:46, Sumit Garg wrote:
> > > >
> > > > This driver uses OpteeLib to interface with
On 12/11/18 13:19, Ard Biesheuvel wrote:
> Move some PCD settings outs of the [PcdsFixedAtBuild.AARCH64] block,
> so that they apply to 32-bit ARM as well. Without this change, the
> ARM build doesn't work.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard
On 12/11/18 10:37, Ard Biesheuvel wrote:
> We currently permit R_ARM_GOT_PREL relocations in the ELF32 conversion
> routines, under the assumption that relative relocations are fine as
> long as the section layout is the same between ELF and PE/COFF.
>
> However, as is the case with any proxy
On Tue, Dec 11, 2018 at 04:02:31PM +0100, Ard Biesheuvel wrote:
> Another day, another round of cleanups for Styx. Patch #1 was sent out
> earlier, and has been updated to switch to a VOID* type PCD. Remaining
> patches are various cleanups for Styx in general, and some for Overdrive
> (+ Cello)
On 12/11/18 08:11, David F. wrote:
> Not sure why you'd take that out when someone using UINTN for variables may
> want to use MAX_UINTN ?Future may be different.
The UINTN type comes from the UEFI spec:
Unsigned value of native width. (4 bytes on supported 32-bit
processor
Instead of incorporating the prebuilt device tree binary as a
FREEFORM FFS file into the build, define a module that contains
the source so that the device tree compiler is invoked at build
time.
The original .dts file is moved into the new module, and cleaned
up a little so that explicit phandle
Another day, another round of cleanups for Styx. Patch #1 was sent out
earlier, and has been updated to switch to a VOID* type PCD. Remaining
patches are various cleanups for Styx in general, and some for Overdrive
(+ Cello)
Ard Biesheuvel (6):
Platform/AMD/OverdriveBoard: fix byte order of
The PCDs containing the default MAC addresses are of type UINT64,
and so the byte order needs to be inverted. As they are currently,
both default MAC addresses are invalid since they have the multicast
bit set.
For readability, let's switch to a VOID* type PCD while at it.
Contributed-under:
Replace the default resolution of the DevicePathLib library with
the version that invokes the DevicePathDxe protocol driver, which
was created to avoid having to carry a copy of the entire library
in each module.
Note that this driver itself incorporates on the NULL PcdLib instance,
to avoid
Enable the various bits and pieces that implement IPv6 networking
and HTTP/HTTPS boot from UEFI.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 32 ++--
The define ARM_CPU_AARCH64 is only tested once, in the SMBIOS driver,
to decide whether to emit 'v8' or 'v7' as processor architecture.
However, this platform has no 32-bit addressable DRAM, and so it
cannot be built or executed in 32-bit mode anyway, making the test
rather pointless.
Instead of relying on the compiler command line to pass the value
of NUM_CORES as a preprocessor define, use the value of the PcdCoreCount
PCD that we already set in the platform .DSC.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
On Tue, 11 Dec 2018 at 15:03, Leif Lindholm wrote:
>
> On Tue, Dec 11, 2018 at 02:25:10PM +0100, Ard Biesheuvel wrote:
> > Ensure that we prevent the CPU from proceeding after having taken an
> > unhandled exception on a RELEASE build, which does not contain the
> > ASSERT() which ensures this on
OK. I'll get it fixed.
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, December 11, 2018 9:49 PM
To: Feng, Bob C
Cc: Gao, Liming ; Andrew Fish ; Leif
Lindholm ; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH edk2-platforms]
On Tue, 11 Dec 2018 at 14:34, Gao, Liming wrote:
>
> I have no comments for this change. Reviewed-by: Liming Gao
>
>
Thanks all
Pushed as 765fb87c2b70..de3c440e8a54
> > -Original Message-
> > From: Laszlo Ersek [mailto:ler...@redhat.com]
> > Sent: Tuesday, December 11, 2018 2:19 AM
>
On Tue, 11 Dec 2018 at 14:38, Feng, Bob C wrote:
>
> Hi Ard,
>
> Would you please try this format? While I'll check this issue anyway.
>
> [PcdsDynamic]
>gAmdStyxTokenSpaceGuid.PcdEthMacA|{CODE({0})}|UINT8[6]|0x000d0001
>gAmdStyxTokenSpaceGuid.PcdEthMacB|{CODE({0})}|UINT8[6]|0x000d0002
On Tue, 11 Dec 2018 at 14:40, Gao, Liming wrote:
>
> Ard:
> With this change, GenFw will report what error message if ELF image has
> R_ARM_GOT_PREL relocations.
>
Numerous occurrences of
GenFw: ERROR 3000: Invalid
WriteSections ():
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF
> Sent: Tuesday, December 11, 2018 5:03 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming Reviewed-by: Liming Gao
>
> Subject: [edk2] [Patch V3] BaseTools:
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF
> Sent: Tuesday, December 11, 2018 5:04 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch V3] BaseTools: Fixed the build fail issue for
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, December 11, 2018 5:04 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming ;
> Leif Lindholm
> Subject: [Patch V3] BaseTools: Fix PcdNvStoreDefaultValueBuffer Value.
>
> From: "Feng, Bob C"
Ard:
With this change, GenFw will report what error message if ELF image has
R_ARM_GOT_PREL relocations.
Thanks
Liming
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, December 11, 2018 7:21 PM
> To: Leif Lindholm
> Cc:
On Tue, Dec 11, 2018 at 02:18:35PM +0100, Marcin Wojtas wrote:
> Recent changes in EDK2 resulted in compilation break
> of all Marvell platforms, because the applications
> include deprecated ShellBase.h header. Fix that.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Hi Ard,
Would you please try this format? While I'll check this issue anyway.
[PcdsDynamic]
gAmdStyxTokenSpaceGuid.PcdEthMacA|{CODE({0})}|UINT8[6]|0x000d0001
gAmdStyxTokenSpaceGuid.PcdEthMacB|{CODE({0})}|UINT8[6]|0x000d0002
and this in my .dsc file
[PcdsDynamicDefault.common]
I have no comments for this change. Reviewed-by: Liming Gao
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, December 11, 2018 2:19 AM
> To: Ard Biesheuvel
> Cc: edk2-devel@lists.01.org; Gao, Liming
> Subject: Re: [edk2] [PATCH] BaseTools/tools_def
On Tue, 11 Dec 2018 at 14:27, Gao, Liming wrote:
>
> Ard:
> This patch is good. It belongs to the part of BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377. I give Reviewed-by:
> Liming Gao . I will keep it and push it together with
> the full patch set to remove all obsolete tool
Ard:
This patch is good. It belongs to the part of BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=1377. I give Reviewed-by: Liming
Gao . I will keep it and push it together with the full
patch set to remove all obsolete tool chains. Is it OK?
Thanks
Liming
> -Original Message-
>
Ensure that we prevent the CPU from proceeding after having taken an
unhandled exception on a RELEASE build, which does not contain the
ASSERT() which ensures this on DEBUG and NOOPT builds.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Recent changes in EDK2 resulted in compilation break
of all Marvell platforms, because the applications
include deprecated ShellBase.h header. Fix that.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1390 is submit for it. Bob
will fix it.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, December 11, 2018 3:54 PM
> To: Gao, Liming
> Cc: Andrew Fish ; Leif Lindholm ;
>
On Tue, 11 Dec 2018 at 13:57, Leif Lindholm wrote:
>
> Not my package, but a couple of minor style/language comments below
> (because this is awkward enough any future readers/users will need all
> the help they can get).
>
> On Tue, Dec 11, 2018 at 01:19:36PM +0100, Ard Biesheuvel wrote:
> > The
Not my package, but a couple of minor style/language comments below
(because this is awkward enough any future readers/users will need all
the help they can get).
On Tue, Dec 11, 2018 at 01:19:36PM +0100, Ard Biesheuvel wrote:
> The self-relocating PrePi module that is used by the
Move some PCD settings outs of the [PcdsFixedAtBuild.AARCH64] block,
so that they apply to 32-bit ARM as well. Without this change, the
ARM build doesn't work.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemuKernel.dsc | 20
Patch #1 reshuffles the .dsc contents of ArmVirtQemuKernel so that we
can run on ARM targets as well.
Patch #2 fixes the CLANG38 build for ArmVirtQemuKernel and ArmVirtXen,
by tweaking the linker options passed to emit the self-relocating PrePi
SEC module.
Ard Biesheuvel (2):
The self-relocating PrePi module that is used by the ArmVirtQemuKernel
and ArmVirtXen targets runs the linker in PIE mode so that it emits
dynamic relocations into the final image in a way that permits the
module to relocate itself into place before calling into the C code.
When building these
On Tue, 11 Dec 2018 at 02:48, Wu, Hao A wrote:
>
> > -Original Message-
> > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> > Sent: Saturday, December 08, 2018 6:25 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Ard Biesheuvel
> > Subject: [PATCH]
On Tue, 11 Dec 2018 at 12:19, Ard Biesheuvel wrote:
>
> On Tue, 11 Dec 2018 at 10:53, Leif Lindholm wrote:
> >
> > On Tue, Dec 11, 2018 at 10:37:15AM +0100, Ard Biesheuvel wrote:
> > > We currently permit R_ARM_GOT_PREL relocations in the ELF32 conversion
> > > routines, under the assumption
On Tue, 11 Dec 2018 at 10:53, Leif Lindholm wrote:
>
> On Tue, Dec 11, 2018 at 10:37:15AM +0100, Ard Biesheuvel wrote:
> > We currently permit R_ARM_GOT_PREL relocations in the ELF32 conversion
> > routines, under the assumption that relative relocations are fine as
> > long as the section layout
On Tue, Dec 11, 2018 at 10:37:15AM +0100, Ard Biesheuvel wrote:
> We currently permit R_ARM_GOT_PREL relocations in the ELF32 conversion
> routines, under the assumption that relative relocations are fine as
> long as the section layout is the same between ELF and PE/COFF.
>
> However, as is the
We currently permit R_ARM_GOT_PREL relocations in the ELF32 conversion
routines, under the assumption that relative relocations are fine as
long as the section layout is the same between ELF and PE/COFF.
However, as is the case with any proxy generating relocation, it is
up to the linker to emit
Hi Bob,
Thanks for cc.
I'm happy with all 3 commit messages.
Regards,
Leif
On Tue, Dec 11, 2018 at 05:03:25PM +0800, BobCF wrote:
> From: "Feng, Bob C"
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1387
>
> This patch is going to fix the regression issue which is
> introduced by commit
On Fri, Dec 7, 2018 at 5:49 AM Vijayenthiran Subramaniam
wrote:
>
> On Thu, Dec 6, 2018 at 5:18 PM Ard Biesheuvel
> wrote:
> >
> > On Wed, 5 Dec 2018 at 07:10, Vijayenthiran Subramaniam
> > wrote:
> > >
> > > Hi Ard,
> > >
> > > The virtio block device and virtio network device are available
On Tue, 11 Dec 2018 at 10:04, Sumit Garg wrote:
>
> On Tue, 11 Dec 2018 at 13:56, Ard Biesheuvel
> wrote:
> >
> > On Tue, 11 Dec 2018 at 08:46, Sumit Garg wrote:
> > >
> > > This driver uses OpteeLib to interface with OP-TEE based RNG service
> > > (pseudo trusted application) to implement
On Tue, 11 Dec 2018 at 13:56, Ard Biesheuvel wrote:
>
> On Tue, 11 Dec 2018 at 08:46, Sumit Garg wrote:
> >
> > This driver uses OpteeLib to interface with OP-TEE based RNG service
> > (pseudo trusted application) to implement EFI_RNG_PROTOCOL that is used
> > to seed kernel entropy pool.
> >
>
From: "Feng, Bob C"
https://bugzilla.tianocore.org/show_bug.cgi?id=1385
This patch is going to fix the regression issue that is
introduced by commit e6eae3b4c7b9b756263ecec79694de5f1e85b73a
and commit 0b6c5954e1d9a17e01eee7d5ef840a5b4790e2e8.
PcdNvStoreDefaultValueBuffer value is update to Vpd
From: "Feng, Bob C"
https://bugzilla.tianocore.org/show_bug.cgi?id=1386
This patch is going to fix the regression issue that is
introduced by commit 72a1d77694d51914c0dd6aa97dbfa58634b0a4a5
The issue will happen in the following cases:
1. There is no Pcd value assignment in Dsc file
2. There
From: "Feng, Bob C"
https://bugzilla.tianocore.org/show_bug.cgi?id=1387
This patch is going to fix the regression issue which is
introduced by commit bf9e636605188e291d33ab694ff1c5926b6f0800.
This patch Remove the CopyDict incorrect usage for non-dict
input data. Add a check for CopyDict
Hi Leif,
I understand your concern.
I collected another performance data set based on open source MinKabylake
platform and updated the BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=1288. The data looks better than
Ovmf. It enabled multiple SKU.
Before I sent those patch, I did verify
On Tue, 11 Dec 2018 at 08:46, Sumit Garg wrote:
>
> This driver uses OpteeLib to interface with OP-TEE based RNG service
> (pseudo trusted application) to implement EFI_RNG_PROTOCOL that is used
> to seed kernel entropy pool.
>
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Contributed-under:
Leif, David,
Thanks for the heads up. I finally will have a slot for the edk2 today -
will fix and submit.
Best regards,
Marcin
wt., 11 gru 2018 o 08:16 David F. napisał(a):
> I ran in to it too, it was easy fix, the headers changed to those in
> MDEPKG and the header file name changed. IIRC
On Tue, 11 Dec 2018 at 08:39, Sumit Garg wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sumit Garg
Reviewed-by: Ard Biesheuvel
Pushed as f4c8c1bbf169..f0574a194c1e
> ---
> ArmPkg/Include/Library/OpteeLib.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
Add a checking step in DevicePathUtilities.c to verify DevicePath.
Cc: Liming Gao
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../Library/UefiDevicePathLib/DevicePathUtilities.c | 12
1 file changed, 12
On Tue, 11 Dec 2018 at 01:53, Gao, Liming wrote:
>
> If PCD is related to one structure in DEC/DSC, it can be refer as structure
> pointer in C source code. Here is wiki for its usage:
> https://github.com/lgao4/edk2/wiki/StrucutrePcd-Usage
>
OK so I now have this in my .dec file
On Mon, 10 Dec 2018 at 22:58, Leif Lindholm wrote:
>
> On Wed, Dec 05, 2018 at 07:50:14PM +0100, Ard Biesheuvel wrote:
> > Primarily, this series gets rid of the hacked up way this platform
> > patches the DSDT at build time, by #include'ing intermediate output
> > of the iasl compiler [or some
This driver uses OpteeLib to interface with OP-TEE based RNG service
(pseudo trusted application) to implement EFI_RNG_PROTOCOL that is used
to seed kernel entropy pool.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sumit Garg
---
I think leaving it in is fine, it is its own directory and everything will
build with the build tools, when you start separating it, it may not build
so easily. It already take a bit of processing and scripting to compile
full blown apps ported to run on the direct UEFI platform (as well as
Shenglei:
Please update IsDevicePathValid() API description in
MdePkg\Include\Library\DevicePathLib.h, and also remove ASSERT (DevicePath !=
NULL); in function implementation.
Thanks
Liming
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 11, 2018 2:31 PM
> To:
On Mon, 10 Dec 2018 at 23:20, Leif Lindholm wrote:
>
> On Thu, Dec 06, 2018 at 01:12:02PM +0100, Ard Biesheuvel wrote:
> > After fixing the iasl issue yesterday, I got a bit carried away and ended
> > up rewriting most of the ACPI table generation logic for Styx. So this
> > applies on top of the
I ran in to it too, it was easy fix, the headers changed to those in MDEPKG
and the header file name changed. IIRC it was the same name minus the
leading Efi, so EfiShellParameters.h became ShellParameters.h. I don't
have a full list but one of the notes on that change points out the new
names.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sumit Garg
---
ArmPkg/Include/Library/OpteeLib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPkg/Include/Library/OpteeLib.h
b/ArmPkg/Include/Library/OpteeLib.h
index 6884d5681831..a7b2ff1b6b57 100644
---
Not sure why you'd take that out when someone using UINTN for variables may
want to use MAX_UINTN ?Future may be different.
On Mon, Dec 3, 2018 at 5:08 AM Laszlo Ersek wrote:
> On 11/30/18 23:45, Ard Biesheuvel wrote:
> > The maximum value that can be represented by the native word size
> >
I uses VS2008
On Mon, Dec 10, 2018 at 4:38 AM Gao, Liming wrote:
> Leif:
> Thanks for your suggestion. I will work out the patch set serials to
> remove those tool chains. I don't remember the usage model of UNIXGCC. II
> will wait for Rebecca response.
>
> Thanks
> Liming
> > -Original
Add a checking step in DevicePathUtilities.c to verify DevicePath.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
BaseTools/Source/C/DevicePath/DevicePathUtilities.c | 12
1 file changed, 12 insertions(+)
“BaseCryptLib” library can be used by MM_STANDALONE drivers as well.
So add MM_STANDALONE as the module type this library supports
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 7 ++-
Add a checking step to verify DevicePath.
Cc: Bob Feng
Cc: Liming Gao
Cc: Michael D Kinney
Shenglei Zhang (2):
BaseTools/DevicePath: Add a checking step
MdePkg/UefiDevicePathLib: Add a checking step
BaseTools/Source/C/DevicePath/DevicePathUtilities.c | 12
“AuthVariableLib” library can be used by MM_STANDALONE drivers as well.
So add MM_STANDALONE as the module type this library supports
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
Reviewed-by: Chao Zhang
---
97 matches
Mail list logo
