Re: [edk2] [edk2-test] SctPkg compilation is failing

2019-03-19 Thread Supreeth Venkatesh
Hi Meenakshi, I was able to reproduce this error. This is because a change in the edk2 file BaseTools/Source/C/Makefiles/app.makefile which was using relative path to make it work with absolute path. This fix is present in latest edk2 versions already. Hence, as indicated earlier I will update

[edk2] [Patch V2][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Enable USB3.0 source debug

2019-03-19 Thread Zailiang Sun
In V2: Track the bug in Bugzilla instead of HSD https://bugzilla.tianocore.org/show_bug.cgi?id=1634 Added a boolean macro SOURCE_DEBUG_USE_USB3 to dsc file in order to build a BIOS image with USB3.0 source level debugging libraries. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch V2][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: SPI lock

2019-03-19 Thread Zailiang Sun
In V2: Track the bug in Bugzilla instead of HSD https://bugzilla.tianocore.org/show_bug.cgi?id=1635 Set protection bit such as BCR, PR0, PR1 and HSFS bits in SPI registers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc: David Wei Cc: Yi Qian ---

[edk2] SerialDxe with BaseSerialPortLib16550 and standard PC com port

2019-03-19 Thread Jacob Burkholder
Greetings! I had trouble using SerialDxe.efi with BaseSerialPortLib16550 on a standard PC com port (com1). The PC is an asrock motherboard running whatever EFI bios it came with. I changed MdeModulePkg.dsc so that BaseSerialPortLib16550 would be used instead of BaseSerialPortLibNull and then

[edk2] [PATCH 0/2] Change reset logic related on capsule

2019-03-19 Thread Zhichao Gao
Add CapsuleCacheWriteBack for IA ARCH. Remove DoS3 in ResetSystemRuntimeDxe. Zhichao Gao (2): MdeModulePkg/CapsuleRuntimeDxe: Merge changes form arm to all ARCH MdeModulePkg/ResetSystemRuntimeDxe: Remove DoS3 in warm reset .../Universal/CapsuleRuntimeDxe/CapsuleReset.c | 21

[edk2] [PATCH 2/2] MdeModulePkg/ResetSystemRuntimeDxe: Remove DoS3 in warm reset

2019-03-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462 Original logic is that checking the CapsuleUpdate variable and do the EnterS3WithImmediateWake if the system require a capsule update. The EnterS3WithImmediateWake is usually implemented in Platform ResetSystemLib instance and it may do some

[edk2] [PATCH 1/2] MdeModulePkg/CapsuleRuntimeDxe: Merge changes form arm to all ARCH

2019-03-19 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462 The arm ARCH has already to add a function CapsuleCacheWriteBack to flush the cache data to DRAM. That is also required in IA32 ARCH. So merge the changes. And this function do not support in runtime phase. Contributed-under: TianoCore

Re: [edk2] [PATCH V3 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, March 19, 2019 11:26 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: [PATCH V3

Re: [edk2] [PATCH V3 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, March 19, 2019 11:26 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: [PATCH V3

Re: [edk2] [PATCH 0/2] DynamicTablesPkg: add package .dsc

2019-03-19 Thread Sami Mujawar
Pushed as 7681a891cec6..fbdfef35cb82 -Original Message- From: Sami Mujawar Sent: 19 March 2019 05:25 PM To: Leif Lindholm ; edk2-devel@lists.01.org Cc: Alexei Fedorov ; nd Subject: RE: [PATCH 0/2] DynamicTablesPkg: add package .dsc Reviewed-by: Sami Mujawar -Original Message-

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-19 Thread Leif Lindholm
A starting proposal for my end would be: --- In order to keep track of who did what, all patches contributed need to include a statement that to the best of the contributor's knowledge they have the right to contribute it under the specified license. The test for this is as specified in the

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-19 Thread Jordan Justen
On 2019-03-19 12:09:41, Kinney, Michael D wrote: > Leif and Jordan, > > Would you mind putting together a specific proposal I would propose adding the exact text from that site into a DeveloperCertificate.txt in the root of the tree. Then reference when documenting how to contribute a patch,

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-19 Thread Kinney, Michael D
Leif and Jordan, Would you mind putting together a specific proposal and perhaps some links to other projects that use the same approach? I am happy to update the RFC to V3 to address this topic if we can close on it quickly. Thanks, Mike > -Original Message- > From: Leif Lindholm

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-19 Thread Leif Lindholm
Hi Mike, I see where Jordan is coming from here. It isn't just about losing the comment in Contriutions.txt - there are bits in the actual TianoCore Contribution Agreement that cover the same things as https://developercertificate.org/ (that are not explicitly called out elsewhere in the

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-19 Thread stephano
On 3/19/2019 7:45 AM, Gao, Liming wrote: Jordan: I suggest to add the line length discussion in edk2 community meeting. Which length is better, 80 or 120? If we expect every patch follows this rule, do we need update PatchCheck to add the checker, and notify the developer know this

[edk2] [PATCH V3 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add the new PEIM DebugServicePei and library instance PeiDebugLibDebugPpi to dsc file to verify it can build correctly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Jian J Wang Cc: Hao Wu Cc:

[edk2] [PATCH V3 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-19 Thread Zhichao Gao
From: Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add a PEI debug library instance PeiDebugLibDebugPpi base on DebugPpi. Using the combination of the DebugServicePei and this lib instance can reduce the image size of PEI drivers. Contributed-under: TianoCore

[edk2] [PATCH V3 15/17] MdeModulePkg: Add a PEIM to install Debug PPI

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add a PEIM to install Debug PPI so that PEI debug library instance can locate gEdkiiDebugPpiGuid to implement the debug functions. Using this PPI can reduce the size of PEIMs which consume the debug library. Contributed-under: TianoCore

[edk2] [PATCH V3 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add a debug PPI for PEI phase. This PPI will provide basic services of debug. PEI debug lib instance can use these services to implement debug function to reduce the PEIMs which consume the debug lib. Contributed-under: TianoCore

[edk2] [PATCH V3 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 12/17] IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 07/17] MdePkg/UefiDebuglibDebugPortProtocol: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 03/17] MdePkg/BaseDebugLibSerialPort: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 05/17] MdePkg/UefiDebugLibStdErr: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 06/17] MdePkg/DxeRuntimeDebugLibSerialPort: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 04/17] MdePkg/UefidebugLibConOut: Add new APIs

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 02/17] MdePkg/BaseDebugLibNull: Add new APIs for DebugLib

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V3 00/17] Add new APIs DebugVPrint for DebugLib

2019-03-19 Thread Zhichao Gao
Add a new API DebugVPrint to all the instances of DebugLib. This API is added to provide a function who want to implement special debug function with '...' parameter. Add a PEIM to install gEdkiiDebugPpiGuid, and implement a PEI debug library instance base on it. All PEIMs except pei core type can

[edk2] [PATCH V3 01/17] MdePkg/DebugLib.h: Add new APIs for DebugLib

2019-03-19 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs DebugVPrint and DebugBPrint prototype definition in the DebugLib header file. These APIs would expose a print routine with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-19 Thread Anthony PERARD
On Thu, Mar 14, 2019 at 07:45:56PM +, Igor Druzhinin wrote: > On 14/03/2019 17:41, Anthony PERARD wrote: > > Hi, > > > > On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote: > >> This aperture doesn't exist in OVMF and trying to use it causes > > > > I'm trying to understand what

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-19 Thread Gao, Liming
Jordan: I suggest to add the line length discussion in edk2 community meeting. Which length is better, 80 or 120? If we expect every patch follows this rule, do we need update PatchCheck to add the checker, and notify the developer know this requirement? For now, I suggest that the

[edk2] [PATCH v2 6/6] DynamicTablesPkg: Minor updates and fix typos

2019-03-19 Thread Sami Mujawar
This patch was originally merged in edk2 master at 07f4e26eb6fe5203028ecfe9bad90d3b67dc72c8. However, this was later reverted at 4c20a791fdbd3b4c83dba060fefa84027313 as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch as the edk2 merge window is now

[edk2] [PATCH v2 3/6] DynamicTablesPkg: Add OEM Info

2019-03-19 Thread Sami Mujawar
This patch originally merged in edk2 master at c788bdaba47536447ae37518a96d92e0da54aad7. However, this was later reverted at bdbbedea949eb4b10d24110c0e559b03c7a6bce4 as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch as the edk2 merge window is now

[edk2] [PATCH v2 5/6] DynamicTablesPkg: Remove GIC Distributor Id field

2019-03-19 Thread Sami Mujawar
This patch was originally merged in edk2 master at d3a15f435f9716aa2f2ea5e9b35fcda04f267ab4. However, this was later reverted at 82c4426a176c271d24915b403b267a431bdc52f5 as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch as the edk2 merge window is now

[edk2] [PATCH v2 4/6] DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI

2019-03-19 Thread Sami Mujawar
This patch was originally merged in edk2 master at 6814256083a90ef218e7ae240e51922045175df1. However, this was later reverted at db8382ef5e44bd07654fb4726b77f3c329210561 as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch as the edk2 merge window is now

[edk2] [PATCH v2 2/6] DynamicTablesPkg: Rename enum used for ID Mapping

2019-03-19 Thread Sami Mujawar
This patch was originally merged in edk2 master at 1d49a75367ef6827b8b8f77f61e9ce245d1bdee3. However, this was later reverted at 334111b0dab80394aeb1ebb8f0f3314847e2dc1f as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch as the edk2 merge window is now

[edk2] [PATCH v2 0/6] DynamicTablesPkg: Framework updates and fixes

2019-03-19 Thread Sami Mujawar
This patch series was originally merged in edk2 master. However, this was later reverted as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch series as the edk2 merge window is now open. This patch series updates the Dynamic Tables Framework to

[edk2] [PATCH v2 1/6] DynamicTablesPkg: Fix protocol section

2019-03-19 Thread Sami Mujawar
This patch was originally merged in edk2 master at bde673b2dcd1b087af7f49dd5f0c3b82b02172a5. However, this was later reverted at 7d180efeaa03df25973416dc0aad099f4fe7e251 as it was merged during the Soft Feature Freeze for edk2-stable201903. Resubmitting this patch as the edk2 merge window is now

Re: [edk2] [Patch MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Leif Lindholm
Thanks, Ming. On Tue, Mar 19, 2019 at 08:59:13PM +0800, Ming Huang wrote: > The system environment: virtual-CDROM(USB interface) via BMC, insert a > iso file to CDROM, like ubuntu-18.04.1-server-arm64.iso, change CDROM > to first boot option. > With release version bios, disconnecting CDROM when

Re: [edk2] [edk2-test] SctPkg compilation is failing

2019-03-19 Thread Supreeth Venkatesh
Sorry, I had to make a few changes to get uefi-sct working with edk2-stable201903 tag. I will update the instructions after posting those patches. Please let me know which versions of edk2 and edk2-test are you using, so that I

[edk2] [Patch MdeModulePkg/Library v1 0/1] Fix exception issue while UsbMass block io uninstalled

2019-03-19 Thread Ming Huang
The Bugzilla tracker for this: https://bugzilla.tianocore.org/show_bug.cgi?id=1631 Ming Huang (1): MdeModulePkg/UefiBootManangerLib: Fix exception issue MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.9.5

[edk2] [Patch MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Ming Huang
The system environment: virtual-CDROM(USB interface) via BMC, insert a iso file to CDROM, like ubuntu-18.04.1-server-arm64.iso, change CDROM to first boot option. With release version bios, disconnecting CDROM when boot to "1 seconds left, Press Esc or F2 to enter Setup" then system will get a

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Ming Huang
On 3/19/2019 1:56 PM, Wu, Hao A wrote: >> -Original Message- >> From: Ming Huang [mailto:ming.hu...@linaro.org] >> Sent: Tuesday, March 19, 2019 12:14 PM >> To: Wu, Hao A; Leif Lindholm >> Cc: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; Zeng, Star; Dong, >> Eric; Ni, Ray;

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Enable USB3.0 source debug

2019-03-19 Thread Zailiang Sun
https://vthsd.intel.com/hsd/tiano/tracker/default.aspx?tracker_id=216942 Added a boolean macro SOURCE_DEBUG_USE_USB3 to dsc file in order to build a BIOS image with USB3.0 source level debugging libraries. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc:

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Leif Lindholm
On Tue, Mar 19, 2019 at 12:01:51PM +0800, Ming Huang wrote: > On 3/18/2019 8:42 PM, Leif Lindholm wrote: > > +MdeModulePkg maintainers (you added MdePkg maintainers to cc) > > > > This looks like an improvement to me. > > > > Am I correct in guessing this behaviour refers to some specific corner

Re: [edk2] [Patch V2 3/3] Vlv2TbltDevicePkg: Fix 32bit BIOS build failure issue

2019-03-19 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Tuesday, March 19, 2019 4:36 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Qian, Yi > Subject: [Patch V2 3/3] Vlv2TbltDevicePkg: Fix 32bit BIOS build failure issue > > In V2: Added new option

Re: [edk2] [PATCH] Vlv2TbltDevicePkg: Resolved chipsec complains

2019-03-19 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Tuesday, March 19, 2019 4:56 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Qian, Yi > Subject: [PATCH] Vlv2TbltDevicePkg: Resolved chipsec complains > >

Re: [edk2] [Patch V2 2/3] Vlv2TbltDevicePkg: Fix build failure issue after ECP cleanup

2019-03-19 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Tuesday, March 19, 2019 4:36 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Qian, Yi > Subject: [Patch V2 2/3] Vlv2TbltDevicePkg: Fix build failure issue after ECP > cleanup > > In V2: no new

Re: [edk2] [Patch V2 1/3] Vlv2TbltDevicePkg: ECP Cleanup.

2019-03-19 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Tuesday, March 19, 2019 4:33 PM > To: edk2-devel@lists.01.org > Cc: Qian, Yi ; Wei, David > Subject: [Patch V2 1/3] Vlv2TbltDevicePkg: ECP Cleanup. > > In V2: no new changes > > Remove modules of

[edk2] [PATCH] Vlv2TbltDevicePkg: Resolved chipsec complains

2019-03-19 Thread Zailiang Sun
https://bugzilla.tianocore.org/show_bug.cgi?id=1335 Set bit in SPI individual lock register to lock down BMWAG, BMRAG, PR0, PR1, PR2, PR3, SCF, PREOP, OPTYPE and OPMENU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc: David Wei Cc: Yi Qian ---

[edk2] [Patch V2 3/3] Vlv2TbltDevicePkg: Fix 32bit BIOS build failure issue

2019-03-19 Thread Zailiang Sun
In V2: Added new option "USE=IA32" when ARCH is IA32 Added conditional choice for Logo.inf in PlatformPkg.fdf, based on the build ARCH information. And Changed the location of binary object files to align with previous releases (%WORKSPACE%\silicon). Contributed-under: TianoCore Contribution

[edk2] [Patch V2 2/3] Vlv2TbltDevicePkg: Fix build failure issue after ECP cleanup

2019-03-19 Thread Zailiang Sun
In V2: no new changes Moved stuff in the three old packages IA32FamilyCpuPkg, Vlv2BinaryPkg and Vlv2MiscBinariesPkg into a new package Vlv2SocBinPkg. Updated the build scripts and added build instructions in Readme.md. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David

[edk2] [Patch V2 1/3] Vlv2TbltDevicePkg: ECP Cleanup.

2019-03-19 Thread Zailiang Sun
In V2: no new changes Remove modules of EdkCompatibilityPkg from DSC/FDF of Vlv2TbltDevicePkg to make this platform ECP free. Test: Boot to 64-bit Windows 10. Cc: Zailiang Sun Cc: Yi Qian Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei ---

Re: [edk2] [PATCH] Vlv2TbltDevicePkg: SPI lock

2019-03-19 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Monday, March 18, 2019 9:42 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Qian, Yi ; Kinney, > Michael D > Subject: [PATCH] Vlv2TbltDevicePkg: SPI lock > >

Re: [edk2] [Patch 1/1] Document: Update FDF spec to remove EDK and IPF related contents

2019-03-19 Thread Gao, Liming
Bob: There is one typo in commit message. Remove EDK and IPF related contents inf Fdf spec ==> Remove EDK and IPF related contents from Fdf spec. With this change, Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, March 06, 2019 5:53 PM >To:

Re: [edk2] [Patch V2 1/1] Document: Update Inf spec to remove EDK and IPF related contents

2019-03-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, March 06, 2019 4:54 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >; Carsey, Jaben >Subject: [Patch V2 1/1] Document: Update Inf spec to remove EDK and IPF >related contents > >BZ:

Re: [edk2] [Patch] BaseTools: Remove EDK_GLOBAL related logic

2019-03-19 Thread Gao, Liming
Bob: Some platform still specifies EDK_GLOBAL, such as https://github.com/tianocore/edk2-platforms/blob/devel-MinPlatform/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc. Please update them first. Thanks Liming >-Original Message- >From: edk2-devel

Re: [edk2] [Patch] BaseTools: Remove the logic SourceOverridePath

2019-03-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Friday, March 15, 2019 11:18 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Remove the logic SourceOverridePath > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350

Re: [edk2] [Patch] BaseTools: Remove EDKI related logic from Trim tool

2019-03-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Friday, March 15, 2019 11:22 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Remove EDKI related logic from Trim tool > >BZ:

[edk2] [PATCH v2 09/10] MdePkg/BaseMemoryLibRepStr: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseMemoryLibRepStr.inf

[edk2] [PATCH v2 08/10] MdePkg/BaseMemoryLibOptPei: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseMemoryLibOptPei.inf

[edk2] [PATCH v2 10/10] MdePkg/BaseMemoryLibSse2: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 07/10] MdePkg/BaseMemoryLibOptDxe: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseMemoryLibOptDxe.inf

[edk2] [PATCH v2 04/10] MdePkg/BaseCpuLib: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 v2: Remove CpuSleep.nasm| GCC and CpuFlushTlb.nasm| GCC in X64 arch in BaseCpuLib.inf. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore

[edk2] [PATCH v2 00/10] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 v2: Remove some description in 04/10. Cc: Michael D Kinney Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Shenglei Zhang (10): UefiCpuPkg/SmmCpuFeaturesLib:

[edk2] [PATCH v2 06/10] MdePkg/BaseMemoryLibMmx: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 05/10] MdePkg/BaseLib: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 03/10] UefiCpuPkg/CpuExceptionHandlerLib:Remove.S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 01/10] UefiCpuPkg/SmmCpuFeaturesLib: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Eric Dong Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 02/10] UefiCpuPkg/BaseUefiCpuLib: Remove .S files for IA32 and X64 arch

2019-03-19 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

Re: [edk2] [PATCH v3 2/3] SecurityPkg/SecurityPkg.uni: Add the prompt and help information

2019-03-19 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shenglei Zhang > Sent: Wednesday, March 13, 2019 11:24 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v3 2/3] SecurityPkg/SecurityPkg.uni: Add the prompt

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-19 Thread Wu, Hao A
> -Original Message- > From: Ming Huang [mailto:ming.hu...@linaro.org] > Sent: Tuesday, March 19, 2019 12:14 PM > To: Wu, Hao A; Leif Lindholm > Cc: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; Zeng, Star; Dong, > Eric; Ni, Ray; dann.fraz...@canonical.com;