Re: [edk2] [PATCH edk2-platforms v3 13/18] Hisilicon/D06: Add Setup Item "Support DPC" and delete some PCIe menus

2019-03-21 Thread Ming Huang
On 3/21/2019 8:32 PM, Leif Lindholm wrote: > Hi Ming, > > On Wed, Mar 20, 2019 at 04:08:24PM +0800, Ming Huang wrote: >> Add setup item "Support DPC" to enable or disable PCIe DPC >> (Downstream Port Containment). >> >> The pcie menu is suppressed for original code as these menus >> are not

Re: [edk2] [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue

2019-03-21 Thread Ming Huang
On 3/22/2019 1:56 AM, Leif Lindholm wrote: > Urgh, this was an unfortunate off-by-one post: > I am deferring this patch until after Linaro's 2019.03 firmware > release and cherry-picking it into that. There must be a better way to > solve this. > > My comment referred to "Hisilicon/D06: Drop

[edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-21 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462 The IA32 ARCH need cache flush function during capsule update. Both arm ARCH and IA32 do not need flush cache function, so merge the CapsuleCacheWriteBack() to one file. And add a null version for EBC. Contributed-under: TianoCore

[edk2] [PATCH V2 0/2] Change reset logic related on capsule

2019-03-21 Thread Zhichao Gao
Add CapsuleCacheWriteBack for IA ARCH before runtime. Remove DoS3 in ResetSystemRuntimeDxe. V2: Adjust the code that would not change the logic of arm ARCH. Fix some build errors because of type convertion. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc:

[edk2] [PATCH V2 2/2] MdeModulePkg/ResetSystemRuntimeDxe: Remove DoS3 in warm reset

2019-03-21 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462 Original logic is that checking the CapsuleUpdate variable and do the EnterS3WithImmediateWake if the system require a capsule update. The EnterS3WithImmediateWake is usually implemented in Platform ResetSystemLib instance and it may do some

Re: [edk2] [PATCH 1/3] Nt32Pkg/Nt32Pkg.dsc: Remove EdkCompatibilityPkg information

2019-03-21 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shenglei Zhang > Sent: Friday, March 22, 2019 10:35 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2] [PATCH 1/3]

[edk2] [PATCH 1/3] Nt32Pkg/Nt32Pkg.dsc: Remove EdkCompatibilityPkg information

2019-03-21 Thread Shenglei Zhang
EdkCompatibilityPkg will be removed from edk2/master. The dependency about EdkCompatibilityPkg in Nt32Pkg.dsc should also be removed. Cc: Ray Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- Nt32Pkg/Nt32Pkg.dsc | 51

[edk2] [PATCH 3/3] EdkCompatibilityPkg: Remove EdkCompatibilityPkg

2019-03-21 Thread Shenglei Zhang
If this patch contains all changes of removing EdkCompatibilityPkg, it will be too big to send. So this patch only contains one operation, deleting EdkCompatibilityPkg. https://bugzilla.tianocore.org/show_bug.cgi?id=1103 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 2/3] Maintainers.txt: Remove EdkCompatibilityPkg information

2019-03-21 Thread Shenglei Zhang
EdkCompatibilityPkg will be deleted from edk2/master. So update the maintainer information of EdkCompatibilityPkg. https://bugzilla.tianocore.org/show_bug.cgi?id=1103 Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-21 Thread Wu, Hao A
If it follows the EDK II C Coding Standards Specification, then ignore my relating comments then, Best Regards, Hao Wu > -Original Message- > From: Gao, Zhichao > Sent: Friday, March 22, 2019 10:19 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Gao, Liming; Wang, Jian J; Ni, Ray;

[edk2] [PATCH 0/2] FmpDevicePkg/FmpDxe: Change the default Image Type ID

2019-03-21 Thread Zhichao Gao
Add a pcd to provide a default image type ID for FmpDxe driver instead of gEfiCallerIdGuid. If the pcd is not initialized as a GUID type, then it will assert and fall back to gEfiCallerIdGuid in function GetImageTypeIdGuid. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH 2/2] FmpDevicePkg/FmpDxe: Change the default Image Type ID

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1638 Change the default Image Type id from gEfiCallerIdGuid to PcdFmpDeviceImageDefaultTypeIdGuid. If the pcd is not initialized as a valid GUID value, the driver will ASSERT and fall back to gEfiCallerIdGuid. Contributed-under: TianoCore

[edk2] [PATCH 1/2] FmpDevicePkg/FmpDevucePkg.dec: Add a pcd

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1638 Add a pcd named PcdFmpDeviceImageDefaultTypeIdGuid. This is used to provide a default Image Type Id for FmpDxe driver instead of the gEfiCallerIdGuid. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc:

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-21 Thread Gao, Zhichao
For the sections you point. It seems good to watch the patch downloaded. The indention is one or two space behind the function name depend on tab expand(2 space). Is it need to adjust them? Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Friday, March 22, 2019 10:09 AM >

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-21 Thread Wu, Hao A
> -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Sean Brogan; > Michael Turner; Bret Barkelew > Subject: [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add

Re: [edk2] [PATCH V4 15/17] MdeModulePkg: Add a PEIM to install Debug PPI

2019-03-21 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > Michael Turner; Bret Barkelew > Subject: [PATCH V4

Re: [edk2] [PATCH V4 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-21 Thread Wu, Hao A
> -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > Michael Turner; Bret Barkelew > Subject: [PATCH V4 14/17] MdeModulePkg: Add definitions for

Re: [edk2] [PATCH V4 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Wu, Hao A
> -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > Michael Turner; Bret Barkelew > Subject: [PATCH V4 13/17]

[edk2] [PATCH 1/2] Platform/Intel: Added python build script.

2019-03-21 Thread Agyeman
This change allows building all the platforms in Platform/Intel with a single python script. This script is tested on windows 10 , python 2.7 and python 3.7 with VS2015 Files Added: * BuildBios.py: the main build script build.json: contains general/default build settings *

[edk2] [PATCH 2/2] ReadMe.md: Update the build instructions

2019-03-21 Thread Agyeman
Updated the build instructions to include the python script build instructions Cc: Michael Kubacki Cc: Michael D Kinney Cc: Nate DeSimone Cc: Liming Gao Cc: Ankit Sinha Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Agyeman --- ReadMe.md | 14 ++ 1 file

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-21 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, March 22, 2019 3:04 AM > To: Ard Biesheuvel; Wu, Hao A > Cc: edk2-devel@lists.01.org; Justen, Jordan L; Ni, Ray > Subject: Re: [PATCH v1 0/2] Ovmf: Stop using ISA drivers within > IntelFrameworkModulePkg >

Re: [edk2] [PATCH V4 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: [PATCH V4

Re: [edk2] [PATCH V4 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, March 21, 2019 10:05 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: [PATCH V4

Re: [edk2] [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Gao, Zhichao
Sorry for forgetting to add tag. I am new to this community and this wiki page would help me a lot. Thanks, Zhichao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, March 22, 2019 2:58 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Justen,

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dsc: Add a driver to build

2019-03-21 Thread Chaganty, Rangasai V
Reviewed-by: Rangasai V Chaganty -Original Message- From: Gao, Zhichao Sent: Thursday, March 21, 2019 7:44 AM To: edk2-devel@lists.01.org Cc: Ni, Ray ; Chaganty, Rangasai V ; Gao, Liming Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dsc: Add a driver to build REF:

[edk2] [edk2-announce] Monthly Community Meeting Update

2019-03-21 Thread stephano
https://www.tianocore.org/monthly-meeting/ These meetings are now available on the Groups.io calendar as a recurring meeting. You can subscribe to the calendar to receive any updates. Reminders will be sent out automatically to those subscribed to the group. I will no longer be providing

[edk2] [edk2-announce] Groups.io Transition

2019-03-21 Thread stephano
First off, I'd like to thank Laszlo for his help in confirming the functionality of the Groups.io mailing list. I could not have done this without him. Groups.io seems to mimic our current list almost 100%, certainly enough to make it viable. Also, it will allow such exciting features as

[edk2] [edk2-announce] APAC/NAMO Bug Triage Time Changes

2019-03-21 Thread stephano
Hey All, So, as it turns out, we here in the US change to Daylight Savings Time, whereas in PRC they do not change their clocks. Because of this, I've moved the Bug Triage for this evening out 1 hour to 5pm PDT (8am in PRC). The triage will remain at this time until Daylight Savings ends in

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-21 Thread Laszlo Ersek
On 03/21/19 11:08, Ard Biesheuvel wrote: > On Thu, 21 Mar 2019 at 07:44, Wu, Hao A wrote: >> > > Just a couple of notes from my side - I'm sure Laszlo will have a much > longer list :-) > > - Dropping the floppy driver is fine with me. > - What is OVMF specific about this

Re: [edk2] [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Laszlo Ersek
On 03/21/19 15:04, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 > > Add new APIs' implementation (DebugVPrint, DebugBPrint) > in the DebugLib instance. These APIs would expose print > routines with VaList parameter and BaseList parameter. > > Contributed-under:

Re: [edk2] [PATCH edk2-non-osi v3 0/8] Upload D0x binary modules

2019-03-21 Thread Leif Lindholm
On Wed, Mar 20, 2019 at 04:17:21PM +0800, Ming Huang wrote: > Main Changes since v2 : > 1 Move "Add some header files" patch to the first of this series; > > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: 1902-non-osi-v3 Apart from the patches I've

Re: [edk2] [PATCH edk2-platforms v3 00/18] Fix issues and improve D0x

2019-03-21 Thread Leif Lindholm
On Wed, Mar 20, 2019 at 04:08:11PM +0800, Ming Huang wrote: > Main Changes since v2 : > 1 Move tidy and delete header file patch to the first of the series. > > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: 1902-platforms-v3 Apart from the patches

Re: [edk2] [PATCH edk2-non-osi v3 8/8] Hisilicon/D06: Add Setup Item "Support DPC"

2019-03-21 Thread Leif Lindholm
Just in case there is an interdependency with the edk2-platforms patch Hisilicon/D06: Add Setup Item "Support DPC" and delete some PCIe menus" I will refrain from pushing this just yet, and will similarly cherry-pick this patch into the Linaro release build. I will push this patch once I push

Re: [edk2] [PATCH edk2-platforms v3 12/18] Hisilicon/D06: Modify for IMP self-Adapte support

2019-03-21 Thread Leif Lindholm
On Wed, Mar 20, 2019 at 04:08:23PM +0800, Ming Huang wrote: > As new IMP(Cortex-M7) firmware support self-adapte, so do not > need BIOS to implement some function, remove useless funtions I will reword/correct the above to "unused functions". With that: Reviewed-by: Leif Lindholm > and report

Re: [edk2] [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue

2019-03-21 Thread Leif Lindholm
Urgh, this was an unfortunate off-by-one post: I am deferring this patch until after Linaro's 2019.03 firmware release and cherry-picking it into that. There must be a better way to solve this. My comment referred to "Hisilicon/D06: Drop the leading 0 (0x0 -> 0x)", which will be pushed with an

Re: [edk2] [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue

2019-03-21 Thread Leif Lindholm
I will update the subject line to reflect what is actually being changed. Other than that, Reviewed-by: Leif Lindholm On Wed, Mar 20, 2019 at 04:08:16PM +0800, Ming Huang wrote: > From: Jason Zhang > > BmcWdtEnable is a field of OemConfigData structure, need have > runtime service

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-21 Thread Laszlo Ersek
On 03/21/19 13:04, Lars Kurth wrote: > > > On 20/03/2019, 18:25, "Laszlo Ersek" wrote: > > But, again, this should be discussed in that separate BZ then. > > > >OvmfPkg/XenBusDxe/XenBus.c > > This file is licensed under the BSD license, aka >

[edk2] [PATCH] PcAtChipsetPkg/PcatChipsetPkg.dsc: Add a driver to build

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1646 Add the IdeControllerDxe driver to the [Components] section to make sure it would build correctly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao ---

[edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dsc: Add a driver to build

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1647 Add a driver MicrocodeFlashAccessLibNull.inf to the [Components] section to make sure it would build correctly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Rangasai V Chaganty Cc:

Re: [edk2] Enquiry on GetTimerPeriod function in Ping.c

2019-03-21 Thread Carsey, Jaben
Correct 0 is supposed to indicate an error. That function may be incorrect for your platform. I think that function is used to help determine the granularity to use when determine how long it took for packets to make their trip over the network and back. -Jaben > -Original Message- >

[edk2] [PATCH V4 15/17] MdeModulePkg: Add a PEIM to install Debug PPI

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add a PEIM to install Debug PPI so that PEI debug library instance can locate gEdkiiDebugPpiGuid to implement the debug functions. Using this PPI can reduce the size of PEIMs which consume the debug library. Contributed-under: TianoCore

[edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-21 Thread Zhichao Gao
From: Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add a PEI debug library instance PeiDebugLibDebugPpi base on DebugPpi. Using the combination of the DebugServicePei and this lib instance can reduce the image size of PEI drivers. Contributed-under: TianoCore

[edk2] [PATCH V4 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add a debug PPI for PEI phase. This PPI will provide basic services of debug. PEI debug lib instance can use these services to implement debug function to reduce the PEIMs which consume the debug lib. Contributed-under: TianoCore

[edk2] [PATCH V4 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add the new PEIM DebugServicePei and library instance PeiDebugLibDebugPpi to dsc file to verify it can build correctly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Jian J Wang Cc: Hao Wu Cc:

[edk2] [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 12/17] IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 10/17] IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 07/17] MdePkg/UefiDebuglibDebugPortProtocol: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 03/17] MdePkg/BaseDebugLibSerialPort: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 05/17] MdePkg/UefiDebugLibStdErr: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 06/17] MdePkg/DxeRuntimeDebugLibSerialPort: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 04/17] MdePkg/UefidebugLibConOut: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 00/17] Add new APIs DebugVPrint for DebugLib

2019-03-21 Thread Zhichao Gao
Add a new API DebugVPrint to all the instances of DebugLib. This API is added to provide a function who want to implement special debug function with '...' parameter. Add a PEIM to install gEdkiiDebugPpiGuid, and implement a PEI debug library instance base on it. All PEIMs except pei core type can

[edk2] [PATCH V4 02/17] MdePkg/BaseDebugLibNull: Add new APIs for DebugLib

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH V4 01/17] MdePkg/DebugLib.h: Add new APIs for DebugLib

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs DebugVPrint and DebugBPrint prototype definition in the DebugLib header file. These APIs would expose a print routine with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH edk2-platforms v3 13/18] Hisilicon/D06: Add Setup Item "Support DPC" and delete some PCIe menus

2019-03-21 Thread Leif Lindholm
Hi Ming, On Wed, Mar 20, 2019 at 04:08:24PM +0800, Ming Huang wrote: > Add setup item "Support DPC" to enable or disable PCIe DPC > (Downstream Port Containment). > > The pcie menu is suppressed for original code as these menus > are not ready. This patch remove the suppression for pcie menu, >

[edk2] Enquiry on GetTimerPeriod function in Ping.c

2019-03-21 Thread twooi
Hi, I am enabling an UEFI ethernet driver in our platform. While I tried to test the driver with ping command, I noticed that ping operation is aborted due to the GetTimerPeriod function return a value 0. In the function GetTimerPeriod in ping.c, the function will return the value of

Re: [edk2] Debugging why Build Rebuilds Something

2019-03-21 Thread Cohen, Eugene
Liming - thank you - this technique of diff'ing the Makefiles immediately identified the issue. We were defining an environment variable that contained date/time values that was used in tools_def resulting in all this unnecessary rebuild behavior. Thanks a ton! Eugene From: Cohen, Eugene

Re: [edk2] [PATCH] BaseTools: Add embedded driver support to GenerateCapsule.py

2019-03-21 Thread Tomas Pilar (tpilar)
Hi Mike, Thank you, that is great news! Cheers, Tom On 20/03/2019 20:00, Kinney, Michael D wrote: > Hi Tomas, > > Thanks for the contribution. I agree we need this feature. > We have been working on updates to GenerateCapsule that > add support for one or more embedded drivers and multiple >

Re: [edk2] Debugging why Build Rebuilds Something

2019-03-21 Thread Cohen, Eugene
Great - I will try this now, thanks Liming! From: Gao, Liming Sent: Thursday, March 21, 2019 4:02 AM To: Cohen, Eugene ; edk2-devel@lists.01.org Subject: RE: Debugging why Build Rebuilds Something Could you help check the timestamp of AutoGen files in OpenSslLib output directory? After the

Re: [edk2] [PATCH V3 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Gao, Zhichao
Thanks for your reminder. I forgot to add all CCs to cover letter. I would be careful next time. Thanks, Zhichao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 21, 2019 12:58 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Justen,

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-21 Thread Ard Biesheuvel
On Thu, 21 Mar 2019 at 07:44, Wu, Hao A wrote: > > > >> > > >> Just a couple of notes from my side - I'm sure Laszlo will have a much > > >> longer list :-) > > >> > > >> - Dropping the floppy driver is fine with me. > > >> - What is OVMF specific about this driver? Is it only the hardcoded > >

Re: [edk2] Debugging why Build Rebuilds Something

2019-03-21 Thread Gao, Liming
Could you help check the timestamp of AutoGen files in OpenSslLib output directory? After the first build, copy OpenSslLib output directory to another directory After the second build, compare the output directory between two builds, please check whether there is the difference for

[edk2] Debugging why Build Rebuilds Something

2019-03-21 Thread Cohen, Eugene
I'm experiencing an annoying problem where OpenSslLib is constantly being rebuilt. I don't think I've done anything unusual or different to it but nevertheless it gets built almost every time I rebuild the same platform. I don't believe any source file timestamps are changing so I think this

Re: [edk2] [PATCH 1/2] MdeModulePkg/CapsuleRuntimeDxe: Merge changes form arm to all ARCH

2019-03-21 Thread Gao, Zhichao
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, March 20, 2019 5:49 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Gao, Liming > ; Zeng, Star > Subject: Re: [edk2] [PATCH 1/2] MdeModulePkg/CapsuleRuntimeDxe: > Merge

Re: [edk2] [PATCH V3 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Gao, Zhichao
I have mixed the section with IntelFrameworkModulePkg. Seems the truncating behavior can work fine. And the comment of this section should be updated. Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Thursday, March 21, 2019 3:06 PM > To: Gao, Liming ; Gao, Zhichao > ;

Re: [edk2] [PATCH V3 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Wu, Hao A
> -Original Message- > From: Gao, Liming > Sent: Thursday, March 21, 2019 2:58 PM > To: Gao, Zhichao; edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Sean Brogan; Michael Turner; > Bret Barkelew > Subject: RE: [PATCH V3 13/17] >

Re: [edk2] [PATCH V3 01/17] MdePkg/DebugLib.h: Add new APIs for DebugLib

2019-03-21 Thread Gao, Liming
Reviewed-by: Liming Gao for MdePkg. >-Original Message- >From: Gao, Zhichao >Sent: Tuesday, March 19, 2019 11:26 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >; Sean Brogan ; >Michael Turner ; Bret Barkelew > >Subject: [PATCH V3 01/17] MdePkg/DebugLib.h: Add new

Re: [edk2] [PATCH v2 02/10] UefiCpuPkg/BaseUefiCpuLib: Remove .S files for IA32 and X64 arch

2019-03-21 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shenglei Zhang > Sent: Tuesday, March 19, 2019 2:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH v2 02/10]

Re: [edk2] [PATCH V3 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Gao, Liming
Zhichao: Why do below change? Seemly, this change is not related to add new APIs. In fact, current log is added as the purpose by commit 137ed15511e2045a7333e33ae7f1e873ce1961dd. if (TotalSize > sizeof (Buffer)) { TotalSize = sizeof (Buffer); ==> return; } Thanks Liming

Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-21 Thread Wu, Hao A
> >> > >> Just a couple of notes from my side - I'm sure Laszlo will have a much > >> longer list :-) > >> > >> - Dropping the floppy driver is fine with me. > >> - What is OVMF specific about this driver? Is it only the hardcoded > >> list of COM1/COM2/PS2 keyboard? If so, should we split this

[edk2] [PATCH v2 3/3] MdePkg/BaseUefiDecompressLib: Improve performance of boundary validation

2019-03-21 Thread shenglei
From: Shenglei Zhang The boundary validation checking in MakeTable() performs on every loop iteration. This could be improved by checking just once before the loop. https://bugzilla.tianocore.org/show_bug.cgi?id=1329 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore

[edk2] [PATCH v2 2/3] BaseTools/C/Common: Improve performance of boundary validation

2019-03-21 Thread shenglei
From: Shenglei Zhang The boundary validation checking in MakeTable() performs on every loop iteration. This could be improved by checking just once before the loop. https://bugzilla.tianocore.org/show_bug.cgi?id=1329 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore

[edk2] [PATCH v2 0/3] Improve performance of boundary validation in MakeTable()

2019-03-21 Thread shenglei
The boundary validation checking in MakeTable() performs on every loop iteration. This could be improved by checking just once before the loop. https://bugzilla.tianocore.org/show_bug.cgi?id=1329 v2:1.Change the the algorithm implementation of the judgement in all patches. 2.Remove previous

[edk2] [PATCH v2 1/3] BaseTools/TianoCompress: Improve performance of boundary validation

2019-03-21 Thread shenglei
From: Shenglei Zhang The boundary validation checking in MakeTable() performs on every loop iteration. This could be improved by checking just once before the loop. https://bugzilla.tianocore.org/show_bug.cgi?id=1329 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore