Re: [edk2] [PATCH] ArmPkg: fixups for 64-bit pointers

g patch that changes to 64-bit accessors for PcdCpuVectorBaseAddress, these patches need to be merged at commit time, and I will take care of that. Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg/ArmPkg.dec| 4 ++-- > ArmPkg/

Re: [edk2] [PATCH] ArmPlatformPkg: fixups for 64-bit mailbox pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran > --- > ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 -- > ArmPlatformPkg/PrePi/MainMPCore.c | 10 -- > 2

Re: [edk2] [PATCH] ArmPkg: apply A57 errata

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Hi Leo, Thanks for the patches. I will respond to the patches

Re: [edk2] [PATCH] MdeModulePkg: support for ACPI tables only above 4GB's

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran I already fixed this issue upstream. Please refer to f9bbb8d9c3f0

Re: [edk2] [PATCH] ArmPkg: apply A57 errata

On 24 March 2016 at 21:30, Leo Duran <leo.du...@amd.com> wrote: > From: Leendert van Doorn <leend...@paramecium.org> > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran <leo.du...@amd.com> Reviewed-by: Ard Biesheuvel <ard.bieshe

Re: [edk2] [PATCH] BaseTools: fixups to get rid of compiler warnings

(+ Yonghong, Liming) On 24 March 2016 at 21:30, Leo Duran wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran > --- > BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c | 18 +- >

Re: [edk2] [PATCH] ArmPkg: fixups for 64-bit pointers

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran The presence of this patch suggests that you are copying the vector table

Re: [edk2] [PATCH] EmbeddedPkg/RTC: use returned status at init-time

On 24 March 2016 at 21:30, Leo Duran <leo.du...@amd.com> wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran <leo.du...@amd.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > EmbeddedPkg/RealTimeClock

Re: [edk2] [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'.

On 23 March 2016 at 16:42, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > >> -Original Message- >> From: Qiu, Shumin >> Sent: Tuesday, March 22, 2016 1:36 AM >> To: edk2-devel@lists.01.org >> Cc: Carsey, Jaben

[edk2] [PATCH 0/4] detect unused but set variables on GCC/X64 and GCC/IA32

. By enabling the warning only on DEBUG, we still get the coverage, and better code, but without inadvertently breaking the RELEASE build for code that is fine. Ard Biesheuvel (4): MdeModulePkg/PciHostBridgeDxe: remove unused but set variables ShellPkg/UefiShellDebug1CommandsLib: remove unused but set

[edk2] [PATCH 1/4] MdeModulePkg/PciHostBridgeDxe: remove unused but set variables

Remove variables that are declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/B

[edk2] [PATCH 4/4] BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds

, which, due to the EDK2 coding style which disallows initialized automatic variables, may contain such variables without having been noticed by other toolchains. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- BaseTool

[edk2] [PATCH 3/4] UefiCpuPkg/MtrrLib: remove unused but set variable

Remove variable TempQWord that is declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- UefiCpuPkg/L

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

Remove variable FStartRow that is declared, assigned but never referenced. This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ShellPkg/L

Re: [edk2] [PATCH 0/4] detect unused but set variables on GCC/X64 and GCC/IA32

On 24 March 2016 at 09:11, Laszlo Ersek <ler...@redhat.com> wrote: > On 03/24/16 07:45, Ard Biesheuvel wrote: >> On 24 March 2016 at 07:41, Gao, Liming <liming@intel.com> wrote: >>> Ard: >>> Thanks for your contribution. I agree to enable this warning

Re: [edk2] [PATCH 0/4] detect unused but set variables on GCC/X64 and GCC/IA32

On 24 March 2016 at 07:41, Gao, Liming wrote: > Ard: > Thanks for your contribution. I agree to enable this warning in DEBUG only. > Reviewed-by: Liming Gao for this serials. > Thanks Liming. I will hold off from merging most of these patches to

Re: [edk2] [PATCH 1/3] ArmPkg: Add ArmReadHcr to enable read-modify-write of HCR

On 4 March 2016 at 00:04, Cohen, Eugene <eug...@hp.com> wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen <eug...@hp.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg/Include/Chips

Re: [edk2] [PATCH 2/3] ArmPkg: ARM/AArch64 implementation of CpuExceptionHandlerLib

On 4 March 2016 at 00:05, Cohen, Eugene wrote: > Introduce ARM and AArch64 instances of the CpuExceptionHandlerLib > which provides exception handling and registration of handlers > regardless of execution phase. > > Two variants of the ArmExceptionLib are provided: one where >

Re: [edk2] [PATCH] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData

On 4 March 2016 at 18:40, wrote: > From: Sami Mujawar > > The UEFI specification allows the operating system (OS) to use the > Graphics Output Protocol (GOP) in the following scenarios: > a. as part of the startup process and > b. prior to loading of

Re: [edk2] [PATCH] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData

On 5 March 2016 at 00:55, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 4 March 2016 at 18:40, <evan.ll...@arm.com> wrote: >> From: Sami Mujawar <sami.muja...@arm.com> >> >> The UEFI specification allows the operating system (OS) to u

Re: [edk2] [PATCH v2] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

On 2 March 2016 at 16:28, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 2 March 2016 at 00:39, Cohen, Eugene <eug...@hp.com> wrote: >> (Second revision of patch which adds two missing #defines for ARM >> instructions) >> >> Instead of only

Re: [edk2] [PATCH v2] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

age FFS files to look for instances > in encapsulated FVs so the vector area can be updated appropriately. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen <eug...@hp.com> Tested-by: Ard Biesheuvel <ard.biesheu...@linaro.org> As far as th

Re: [edk2] [PATCH] ArmPlatformPkg: delete orphaned ArmVExpress.dsc.inc

lication of effort. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 477 &g

Re: [edk2] [PATCH] ArmPkg: Configure TTBCR register

On 1 March 2016 at 16:11, Leif Lindholm wrote: > Hi Evan, > > On Tue, Mar 01, 2016 at 02:14:35PM +, evan.ll...@arm.com wrote: >> From: Evan Lloyd >> >> Architecturally, the TTBCR register value is undefined at reset for >> Non-Secure. >> On some

Re: [edk2] AllocatePool and AllocateBuffer

On 3 March 2016 at 16:16, Ravikanth MVR wrote: > Hi Ard, > > In x86 architectures,we are allocating memory via AllocatePool for DMA > transaction and it works fine.But in ARM-AARCH64 architecture,AllocatePool() > is not working and we had to use AllocateBuffer() as per

Re: [edk2] [GIT PULL] CryptoPkg/OpensslLib: Fix CRLF breakage in process_files.sh

On 5 March 2016 at 17:54, David Woodhouse wrote: > Please PULL this commit from: > > git://git.infradead.org/users/dwmw2/edk2.git fix-crlf-crap > Fetched and pushed, thanks! > > > From 9353c60cea6eeedbbe4b336aea02646e2bf25f47 Mon Sep 17 00:00:00 2001 > From: David

Re: [edk2] [PATCH v2] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

it an assert that usually never fires: ASSERT [PeiCore] /home/ard/build/edk2/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c(426): PrivateData.PeiMemoryInstalled == ((BOOLEAN)(1==1)) >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Wednesday,

Re: [edk2] [PATCH v2] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

On 2 March 2016 at 14:50, Cohen, Eugene wrote: >> I suppose the output of the final GenFv is what matters, right? > > I expected to see stuff like "UpdateArmResetVectorIfNeeded updating AArch64 > SEC vector" - obviously that's not being emitted. > > Just to double-check, you did

Re: [edk2] [PATCH] ArmPkg: Configure TTBCR register

On 2 March 2016 at 11:27, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Wed, Mar 02, 2016 at 10:12:37AM +0100, Ard Biesheuvel wrote: >> On 1 March 2016 at 16:11, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> > Hi Evan, >> > >> > O

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

Ard. > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Ard Biesheuvel >> Sent: Friday, April 1, 2016 8:19 PM >> To: Yao, Jiewen <jiewen@intel.com> >> Cc: edk2-devel@lists.01.org <edk

Re: [edk2] [PATCH] ArmPlatformPkg: Initialize the UART Debug Port

On 4 March 2016 at 19:37, wrote: > From: Sami Mujawar > > The Operating system debugger relies on the firmware to configure and > initialize the UART debug port. > > This patch initializes the PL011 UART to be used as a Debug Port. > > Code at: >

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 16:07, Yao, Jiewen wrote: > That is enough. Thanks! > > I suggest you use this way as temp work-around. > > As final solution, I think we can construct table after all ReadyToBoot > events are processed, which need more update in DxeCore. > For now, the

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 1 April 2016 at 16:17, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/01/16 16:13, Ard Biesheuvel wrote: >> On 29 March 2016 at 22:08, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >>> On 29 March 2016 at 19:51, Laszlo Ersek <ler...@redhat.com>

Re: [edk2] [PATCH 3/3] ArmPkg: Correct typos in ArmArchTimerLib.c.

omments, and one diagnostic message. > > Code at: > https://github.com/EvanLloyd/tianocore/commit/6de873f7e3fd63b045adf994e1c8289a7da66531 > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Evan Lloyd <evan.ll...@arm.com> Reviewed-by: Ard Biesheuvel

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 29 March 2016 at 22:08, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 29 March 2016 at 19:51, Laszlo Ersek <ler...@redhat.com> wrote: >> Edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII configuration settings >> available to OS runtime") implement

Re: [edk2] [PATCH 1/2] MdePkg: Add ARM Serial Port Subtype definitions

@Liming, Michael: do you have any objections to this patch? Thanks, Ard. On 5 March 2016 at 00:45, Yao, Jiewen wrote: > Reviewed by: jiewen@intel.com > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

Re: [edk2] [PATCH 2/2] MdePkg: Add ARM Serial Port Subtypes to DBG2

@Liming, Michael: any objections? On 5 March 2016 at 00:41, Yao, Jiewen wrote: > Reviewed by: jiewen@intel.com > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > evan.ll...@arm.com > Sent: Saturday, March 05, 2016

Re: [edk2] [PATCH] ArmPlatformPkg: Add PCD for Pl011 UART Interrupt

uja...@arm.com> > Signed-off-by: Evan Lloyd <evan.ll...@arm.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Pushed as 7dfe93097c03 ArmPlatformPkg: Add PCD for Pl011 UART Interrupt > --- > ArmPlatformPkg/ArmPlatformPkg.dec | 3 ++- > 1 file chang

Re: [edk2] [PATCH] EmbeddedPkg: Fix SBSA Generic Watchdog helper

<sami.muja...@arm.com> > Signed-off-by: Evan Lloyd <evan.ll...@arm.com> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Pushed as d51949806737 EmbeddedPkg/AcpiLib: fix SBSA Generic Watchdog helper definition > --- > EmbeddedPkg/Include/Library/AcpiLib.h | 4 ++-- &g

Re: [edk2] [PATCH 0/2] MdePkg: Add ARM Serial Port definitions

On 4 March 2016 at 18:24, wrote: > Second stab at Serial port id updates, responding to request from > Jiewen Yao > > [PATCH 1/2] MdePkg: Add ARM Serial Port Subtype definitions > [PATCH 2/2] MdePkg: Add ARM Serial Port Subtypes to DBG2 Thanks

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 1 April 2016 at 16:32, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/01/16 16:20, Ard Biesheuvel wrote: >> On 1 April 2016 at 16:17, Laszlo Ersek <ler...@redhat.com> wrote: >>> On 04/01/16 16:13, Ard Biesheuvel wrote: >>>> On 29 March 2016 at 22:08,

Re: [edk2] [PATCH 1/2] ArmPlatformPkg: Add support to configure PL011 UART clock

On 3 March 2016 at 13:16, wrote: > From: Sami Mujawar > > On some platforms the UART clock is not the same for all the serial > ports. The PL011 driver should be reentrant and capable of handling > serial ports with different clock rates. > > This patch

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

om: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi >> Guo >> Sent: Monday, March 28, 2016 8:06 PM >> To: Ard Biesheuvel <ard.biesheu...@linaro.org>; Ni, Ruiyu >> <ruiyu...@intel.com> >> Cc: edk2-devel@lists.01.org; Tian, Feng <feng.t...

Re: [edk2] [PATCH] MdeModulePkg: consistent AllocatePages() support for tables above 4 GB's

On 29 March 2016 at 19:14, Duran, Leo <leo.du...@amd.com> wrote: > > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Tuesday, March 29, 2016 12:10 PM >> To: Duran, Leo >> Cc: Charles Garcia-Tobin;

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

le the feature was being introduced, popular demand for a controlling > Feature PCD rose (see > <http://thread.gmane.org/gmane.comp.bios.edk2.devel/7626>), which is why > we can set it now to FALSE. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contribute

Re: [edk2] Error while loading a symbol file (No Debug Directory)

On 30 March 2016 at 02:06, Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> wrote: >> -Original Message- >> From: af...@apple.com [mailto:af...@apple.com] >> Sent: Tuesday, March 29, 2016 4:09 PM >> To: Vladimir Olovyannikov >> Cc: Eugene Coh

Re: [edk2] Error while loading a symbol file (No Debug Directory)

On 30 March 2016 at 12:30, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 30 March 2016 at 02:06, Vladimir Olovyannikov > <vladimir.olovyanni...@broadcom.com> wrote: >>> -Original Message- >>> From: af...@apple.com [mailto:af...@apple.com] >&

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 31 March 2016 at 15:20, Yao, Jiewen wrote: > Hi Ard > Thanks for your log. Yes, it seems new issue, I have never encountered before. > > Here is what I found: > > 1) MemoryAttributeTable is always installed in ReadyToBoot event. (Sorry, I > gave wrong info on EndOfDxe,

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

On 31 March 2016 at 17:58, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 31 March 2016 at 17:56, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> On 31 March 2016 at 17:45, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >>> On 24 March 2016 at

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

On 31 March 2016 at 17:56, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 31 March 2016 at 17:45, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> On 24 March 2016 at 21:30, Leo Duran <leo.du...@amd.com> wrote: >>> From: Leendert van Doorn <leend

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

rd. >> -----Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Thursday, March 31, 2016 9:34 PM >> To: Yao, Jiewen <jiewen@intel.com> >> Cc: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org >> <e

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

On 31 March 2016 at 17:45, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 24 March 2016 at 21:30, Leo Duran <leo.du...@amd.com> wrote: >> From: Leendert van Doorn <leend...@paramecium.org> >> >> Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 2/2] ArmVirtPkg/ArmVirtQemu: allow firmware to be built in ACPI-only mode

On 31 March 2016 at 15:11, Laszlo Ersek <ler...@redhat.com> wrote: > On 03/31/16 14:53, Ard Biesheuvel wrote: >> On 31 March 2016 at 14:48, Laszlo Ersek <ler...@redhat.com> wrote: >>> (4) for the subject of this patch, I would prefer something less >>> sen

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

On 24 March 2016 at 21:30, Leo Duran wrote: > From: Leendert van Doorn > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leo Duran Looking in more detail at this patch, I am a bit puzzled so please see

Re: [edk2] Building the ShellPkg

On 31 March 2016 at 17:39, Mahan, Patrick wrote: > David, > > Thanks, that is exactly what was needed. > > (Writing that one down in my tips and tricks for UEFI) > Hi Patrick, If you are on Linux, the simplest way to work around this is to symlink

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 31 March 2016 at 15:33, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 31 March 2016 at 15:20, Yao, Jiewen <jiewen@intel.com> wrote: >> Hi Ard >> Thanks for your log. Yes, it seems new issue, I have never encountered >> before. &g

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 09:24, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 31 March 2016 at 15:33, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> On 31 March 2016 at 15:20, Yao, Jiewen <jiewen@intel.com> wrote: >>> Hi Ard >>> Thanks

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

On 31 March 2016 at 22:51, Leendert van Doorn wrote: > >> So what we may have here is either a bug in DmaLib on ARM, or a bug in the >> PCI emulation >> where it handles EfiPciIoOperationBusMasterCommonBuffer allocations >> incorrectly, since such >> buffers need to be

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 14:16, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 1 April 2016 at 09:25, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> On 1 April 2016 at 09:24, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >>> On 31 March 2016 a

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

On 29 March 2016 at 08:26, Kinney, Michael D wrote: > Ard, > > Many handlers running at the same TPL are ok as long as each of the handlers > run for very short periods of time. Any event handlers that execute as > raised TPL for extended periods of time will impact

Re: [edk2] [PATCH 1/3] ArmPkg: Add GetTimeInNanoSecond() to ArmArchTimerLib

core/commit/cfa119bc7343d5410a173dc8202de629db15a5f0 >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> > > Reviewed-by: Ryan Harkin <ryan.har...@linaro.org> > Reviewed-by: Ard Biesheuvel <ard.bieshe

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

On 4 April 2016 at 19:17, Ryan Harkin wrote: > Hi Haojian, > > I've had time to investigate where TC2 is hanging with your patches > applied and narrowed it down to the single line of code marked below. > > I'm going to read the code now and see if I can work out what it's

Re: [edk2] [PATCH] MdeModulePkg: support for ACPI tables only above 4GB's

s patch, and check if the ACPI tables are in a suitable location for you. Thanks, Ard. > > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, March 24, 2016 4:10 PM > To: Duran, Leo > Cc: edk2-devel@lists.01.org; Leif Lindholm; Leendert

Re: [edk2] ld -z being used linking PE (not ELF) binaries?

(+ Jordan, Liming) On 23 March 2016 at 01:11, Charles Duffy wrote: > Howdy -- > > I'm running an edk2 build with TOOL_CHAIN_TAG=UNIXGCC. > > This eventually fails as follows: > > Building ... >

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

On 17 March 2016 at 10:11, Laszlo Ersek wrote: > Adding Ard > > On 03/17/16 08:28, Zeng, Star wrote: >> On 2016/3/17 15:16, Andrew Fish wrote: >>> On Mar 17, 2016, at 12:10 AM, Gao, Liming wrote: Andrew: DxeDebugPrintErrorLevelLib

[edk2] [PATCH 2/2] ArmVirtPkg/ArmVirtQemu: allow firmware to be built in ACPI-only mode

-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.dsc | 5 + 1 file changed, 5 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index fafad7751e6d..e626df768f85 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQe

[edk2] [PATCH 1/2] ArmVirtPkg/VirtFdtDxe: make installation of FDT as config table option

as a configuration table. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtPkg.dec| 9 +++ ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 67 +++- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf | 3 + 3

[edk2] [PATCH 0/2] ArmVirtPkg/ArmVirtQemu: add ACPI-only support

The default ArmVirtQemu build leaves it up to the OS whether it prefers DT over ACPI, since it always present both descriptions. This may not always be desirable, so allow ArmVirtQemu to be built in ACPI-only mode Ard Biesheuvel (2): ArmVirtPkg/VirtFdtDxe: make installation of FDT as config

Re: [edk2] [PATCH 2/2] ArmVirtPkg/ArmVirtQemu: allow firmware to be built in ACPI-only mode

On 31 March 2016 at 14:48, Laszlo Ersek <ler...@redhat.com> wrote: > (4) for the subject of this patch, I would prefer something less > sensational :), such as > > ArmVirtPkg/ArmVirtQemu: gate FDT config table install with build option > > On 03/31/16 13:

Re: [edk2] [PATCH v3 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 13 April 2016 at 14:16, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> This implements a library ArmVirtPL031FdtClientLib which is intended to >> be incorporated into RealTimeClockRuntimeDxe via NULL library class >> resolut

Re: [edk2] [PATCH v3 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 14:21, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >&g

Re: [edk2] [PATCH v4 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 13 April 2016 at 16:51, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 16:32, Ard Biesheuvel wrote: >> This implements a library ArmVirtPL031FdtClientLib which is intended to >> be incorporated into RealTimeClockRuntimeDxe via NULL library class >> resolut

Re: [edk2] [PATCH] ArmVirtPkg/RelocatableVirtHelper: use correct FindMemNode argument order

On 13 April 2016 at 14:14, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 13:49, Ard Biesheuvel wrote: >> Commit 03b6bed17ea6 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB >> memory node retrieval in C") introduced a FindMemNode () C function >> that take

Re: [edk2] [PATCH v3 9/9] ArmVirtPkg/VirtFdtDxe: remove Xenio handling and rename to VirtioFdtDxe

On 13 April 2016 at 16:18, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> Now that we have moved the handling of the xen,xen DT node to XenioFdtDxe, >> remove its handling from VirtFdtDxe. Since the only functionality that >> rem

[edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

this conversion cannot affect any other users and is thus safe. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/ArmVirtQemu.dsc | 5 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +-- 2 files changed, 9 inse

[edk2] [PATCH v4 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/ArmVirtQemu.fdf | 4 ArmVirtPkg/ArmVirtQemuKernel.fdf | 4 ArmVirtPkg/ArmVirtXen.fdf| 4 -

[edk2] [PATCH v4 3/9] ArmVirtPkg/VirtFdtDxe: drop RTC handling

The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base address in a dynamic PCD, so drop the handling altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@r

[edk2] [PATCH v4 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf | 47 +++ ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c | 82 2 files changed, 129 insertions(+) diff

[edk2] [PATCH v4 6/9] ArmVirtPkg/VirtFdtDxe: move FDT config table installation to FdtClientDxe

Now that FdtClientDxe is the core driver that takes ownership of the host supplied FDT, it makes sense to put it in charge of installing the FDT configuration table as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Re

[edk2] [PATCH v4 8/9] ArmVirtPkg/ArmVirtXen: move from VirtFdtDxe to new XenioFdtDxe driver

-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.inf | 44 + ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.c | 68

[edk2] [PATCH v4 5/9] ArmVirtPkg/VirtFdtDxe: remove unused PL011 DT node type

This type is not used in the code, so drop the definitions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 2 -- 1 file changed,

[edk2] [PATCH v4 0/9] VirtFdtDxe refactoring and removal

. This is somewhat rough around the edges, but is mostly intended to elicit discussion, and I fully expect these changes to make it into the tree looking a lot different from this v1. Ard Biesheuvel (9): ArmVirtPkg: implement ArmVirtPL031FdtClientLib ArmVirtPkg: move QEMU based platforms

Re: [edk2] [PATCH v3 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

On 13 April 2016 at 14:34, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> We no longer care when VirtFdtDxe executes, since the dependencies are now >> all resolved via protocols. So drop the A PRIORI declaration. >> >

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 17:07, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only drive

[edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

this conversion cannot affect any other users and is thus safe. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- Laszlo, I did 'fix' it in v4, but poorly ... You may have noticed that I am getting a bit impatient. However,

Re: [edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 16:53, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 16:32, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >&g

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 17:20, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 17:13, Ard Biesheuvel wrote: >> On 13 April 2016 at 17:07, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 17:40, Laszlo Ersek <ler...@redhat.com> wrote: > On 04/13/16 17:34, Ard Biesheuvel wrote: >> On 13 April 2016 at 17:29, Laszlo Ersek <ler...@redhat.com> wrote: >>> On 04/13/16 17:17, Laszlo Ersek wrote: >>>> On 04/13/16 17:07, Ard Bie

Re: [edk2] [PATCH v3] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

On 14 April 2016 at 13:17, Mark Rutland <mark.rutl...@arm.com> wrote: > On Tue, Apr 12, 2016 at 08:57:46AM +0200, Ard Biesheuvel wrote: >> On ARM, manipulating live page tables is cumbersome since the architecture >> mandates the use of break-before-make, i.e., re

Re: [edk2] [PATCH] EmbeddedPkg: Add GICD table init macro for ACPI 6.0

On 11 April 2016 at 18:53, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 11 April 2016 at 14:31, Heyi Guo <heyi@linaro.org> wrote: >> Hello, >> >> Any comments on this patch? >> > > I think it looks

Re: [edk2] [PATCH] ArmPlatformPkg/DS-5: fix 64-bit PE/COFF header parsing bug

Pretty ping? On 8 April 2016 at 13:26, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Ping? > > On 31 March 2016 at 09:36, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> The 64-bit version of the DS-5 debug script that retrieves the debug file >> path

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

On 22 April 2016 at 09:37, Wu, Jiaxin wrote: > Reviewed-by: Jiaxin Wu > > >> -Original Message- >> From: Zhang, Lubo >> Sent: Tuesday, April 19, 2016 5:05 PM >> To: Ye, Ting ; edk2-devel@lists.01.org >> Cc: Fu, Siyuan

Re: [edk2] facing memory allocation failure on QEMU

On 22 April 2016 at 08:49, Meenakshi Aggarwal wrote: > Hi Ard, > > > I cloned tag "llct-20160105.0" from > git://git.linaro.org/kernel/linux-linaro-tracking.git. > > commit 62862d5eec1567de047fe52551d6eb73683a4a9f > Merge: 564a141 e117bc4 > Author: Andrey Konovalov

Re: [edk2] facing memory allocation failure on QEMU

On 22 April 2016 at 10:18, Meenakshi Aggarwal wrote: > Hi Ard, > > > I tried your image, its verification succeeded, > then I tried my kernel Image, verification succeeded for that as well. > > > The only difference is... previously I was signing the image in /mnt >

Re: [edk2] facing memory allocation failure on QEMU

On 22 April 2016 at 09:43, Meenakshi Aggarwal wrote: > Hi Ard, > > > I tried signing my kernel image with KEK rather than DB (that’s what I think > you want me to do, hope I understood you correctly), > But this too didn't work for me. > > > $ sudo

Re: [edk2] facing memory allocation failure on QEMU

On 22 April 2016 at 11:25, Meenakshi Aggarwal wrote: > Hi Ard, > > > > I try after enrolling KEK.der into DB and kernel booted up successfully. > Thanks for your constant support. > > > I have one question... I have enrolled DB.der into DB previously, when I try > to

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

On 29 April 2016 at 09:19, Ni, Ruiyu wrote: > Ard, > At first glance of this patch, I immediately checked the PI spec > SubResources() description, > it says when a root bridge doesn't require any resource, "a zero-length > resource request > must explicitly be submitted." >

[edk2] [PATCH] MdeModulePkg/DxeCore: set ImageContext Handle and ImageRead() fields

() implementation that applies boot time strict mapping permissions to PE/COFF modules. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeMod

Re: [edk2] [PATCH] ArmPlatformPkg/PrePi: allow unicore version to be used on MP hardware

On 19 April 2016 at 09:26, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > When combining UEFI firmware built from Tianocore with ARM Trusted > Firmware running in EL3, it is the responsibility of ATF that only > a single core enters the UEFI firmware in EL2, and the

Re: [edk2] [PATCH] ArmPlatformPkg/PrePi: allow unicore version to be used on MP hardware

On 28 April 2016 at 17:29, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Apr 28, 2016 at 05:02:19PM +0200, Ard Biesheuvel wrote: >> On 19 April 2016 at 09:26, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> > When combining UEFI firmware built f

<    5   6   7   8   9   10   11   12   13   14   >