Re: [edk2] [Patch 1/2] UefiCpuPkg/CpuCommonFeaturesLib: Remove redundant definition.

: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, August 24, 2017 7:03 AM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: Re:

Re: [edk2] [Patch] UefiCpuPkg/MpLib: fix potential overflow issue.

Mike, Thanks for the comments, I updated the patch, please help to review the new patch. Thanks, Eric -Original Message- From: Kinney, Michael D Sent: Thursday, August 24, 2017 5:51 AM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <mich

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

-Original Message- From: Kinney, Michael D Sent: Friday, August 18, 2017 1:39 AM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming@intel.com> Subjec

Re: [edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Use MSR data structure when change MSR value.

Hi Mike, I have updated the patch to follow your suggest. Please help to review the new patches. BTW, why we can't use UINT64 bit fields? Does it have potential issue in 32 bits system? Thanks, Eric From: Kinney, Michael D Sent: Friday, August 18, 2017 1:33 AM To: Dong, Eric <eri

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

o you think is suitable for memory size and output scheme. Thanks, Eric -Original Message- From: Kinney, Michael D Sent: Thursday, August 17, 2017 3:55 PM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Ni, Ruiyu &

Re: [edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Use MSR data structure when change MSR value.

lMsr.h too. Mike > -Original Message- > From: Dong, Eric > Sent: Wednesday, August 16, 2017 11:36 PM > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Cc: Kinney, Michael D > <michael.d.kin...@intel.com<mailto:michael.d.kin...@int

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

can enhance OutputSchemeInvalid to OutputSchemeDisable for consistent with EnumProcTraceMemDisable. For the BITxx issue, I have submit a patch for it, please help to review it. Thanks, Eric -Original Message- From: Kinney, Michael D Sent: Wednesday, August 16, 2017 11:59 PM To: Dong

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add CPUID MCA support check

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Kinney, Michael D Sent: Thursday, August 17, 2017 10:36 AM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [Patch] UefiCpu

Re: [edk2] [Patch 0/2] Add comments for new Pcds

Laszlo, Thanks for your advice. I will pay more attention to the check in log later. Thanks, Eric -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 9, 2017 7:15 PM To: Dong, Eric <eric.d...@intel.com> Cc: edk2-devel@lists.01.org; Justen, Jo

Re: [edk2] Unable to locate EFI_HII_POPUP_PROTOCOL in latest edk2

Hi Amit, This protocol was added in 2.7 version. We are still updating code to implement it. When we ready, we will submit patch in this mail list for this protocol. You can check it later. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprecated macro.

Ray, I check the spec, found the Quark definition has some small difference with normal MSR. So I prefer not do this change for Quark. Thanks, Eric -Original Message- From: Ni, Ruiyu Sent: Thursday, August 3, 2017 6:22 PM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.

Re: [edk2] [PATCH] UefiCpuPkg/Msr: Add a missing IvyBridge processor signature

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Wu, Hao A Sent: Wednesday, August 2, 2017 4:30 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Dong, Eric <eric.d...@intel.com>; Fan, Jeff <jeff@intel.com> Subject: [PA

Re: [edk2] [patch] BaseTools/VfrCompile: Remove the MAX_PATH limitation

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Tuesday, August 1, 2017 3:51 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Daniel D�az <daniel.d...@linaro.org> Su

Re: [edk2] [patch] BaseTools/VfrCompile: Fix segmentation fault issues

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, July 27, 2017 10:53 AM To: edk2-devel@lists.01.org Cc: Bo Chen ; Gao, Liming Subject:

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Fix incorrect variable name

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, June 12, 2017 9:49 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [patch] MdeModulePkg/BMMUiLib: Fix incorrect variable name REF: https://bugzilla.tianoco

Re: [edk2] [PATCH v3 0/3] Enable X2APIC after MP service is ready

Please remove the extra space in patch 1/3 when you check in. Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Friday, May 26, 2017 9:12 PM To: edk2-devel@lists.01.org Subject: [edk2]

Re: [edk2] [PATCH] UefiCpuPkg/DxeMpInitLib.inf: Add missing SynchronizationLib

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Fan, Jeff Sent: Monday, May 22, 2017 2:50 PM To: edk2-devel@lists.01.org Cc: Dong, Eric Subject: [PATCH] UefiCpuPkg/DxeMpInitLib.inf: Add missing SynchronizationLib Contributed-under: TianoCore Contribution Agr

Re: [edk2] [PATCH 0/2] Fix SmmCpuFeaturesLib issues

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, May 10, 2017 2:50 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Fix SmmCpuFeaturesLib issues Jeff Fan (2):

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Check ProcessorId == INVALID_APIC_ID

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Fan, Jeff Sent: Wednesday, May 10, 2017 4:34 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Dong, Eric Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Check ProcessorId == INVALID_APIC_ID If PcdCpuHotPlugSupport i

Re: [edk2] Convention for creating dynamic HII forms

Hi Dev, I add my comments below. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of dgur...@codeaurora.org Sent: Thursday, May 11, 2017 4:39 AM To: edk2-devel@lists.01.org Subject: [edk2] Convention for creating dynamic HII forms Hi,

Re: [edk2] [patch] MdeModulePkg/FormDisplay: Make the LineWidth of option consistent

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, May 10, 2017 2:21 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> Subject: [patch] MdeModulePkg/FormDisplay:

Re: [edk2] [PATCH v2] UefiCpuPkg: Update package version to 0.80

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Monday, May 8, 2017 11:43 AM To: edk2-devel@lists.01.org Cc: Tian, Feng; Dong, Eric Subject: [edk2] [PATCH v2] UefiCpuPkg: Update p

Re: [edk2] [PATCH] UefiCpuPkg: Update package version to 0.80

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Monday, May 8, 2017 11:33 AM To: edk2-devel@lists.01.org Cc: Tian, Feng; Dong, Eric Subject: [edk2] [PATCH] UefiCpuPkg: Update p

Re: [edk2] [PATCH v3] MdeModulePkg/DeviceManagerUiLib: Fix the network device MAC display issue

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Friday, April 21, 2017 11:01 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin; Dong, Eric Subject: [edk2] [PA

Re: [edk2] [Patch] MdeModulePkg/DeviceManagerUiLib: Fix the network device MAC display issue

Jiaxin, Thanks to help to fix this issue. We'd better define new STR_FORM_NETWORK_DEVICE_TITLE_HEAD for L" Network Device " instead of hard code in the code. Thanks, Eric -Original Message- From: Wu, Jiaxin Sent: Monday, April 17, 2017 4:08 PM To: edk2-devel@lists.01.or

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Update codes of initializing ConsoleXXXCheck array

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Tuesday, April 18, 2017 11:50 AM To: edk2-devel@lists.01.org Cc: Dong, Eric Subject: [patch] MdeModulePkg/BMMUiLib: Update codes of initializing ConsoleXXXCheck array When initia

Re: [edk2] [PATCH v2] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, April 5, 2017 11:11 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [PATCH v2] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression https://bugzilla.tianoco

Re: [edk2] [patch] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

It's better to add StringPtr != NULL check before use *StringPtr. -Original Message- From: Bi, Dandan Sent: Saturday, April 1, 2017 10:51 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [patch] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression Fix

Re: [edk2] Vfr compiler error

Hi Naveen, Current VfrCompiler not support get value from PCD. Do you use PCD function in the data structure? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent: Thursday, March 30, 2017 8:27 PM To:

Re: [edk2] [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Long, Qin Sent: Thursday, March 30, 2017 3:47 PM To: Ye, Ting; Dong, Eric; Wu, Hao A; edk2-devel@lists.01.org Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module The memory free ope

Re: [edk2] override hotkey esc in HII form

Hi Jannis, The ESC is a scan code predefined in the DisplayEngineDxe driver, display engine use these keys to make itself workable. Details about scan code see below: SCAN_CODE_TO_SCREEN_OPERATION gScanCodeToOperation[] = { { SCAN_UP, // arrow up operation UiUp, }, {

Re: [edk2] HII UEFI driver from Intel's lab training crashes

Hi Nikolay, This error raised because the input string for StrLen function is NULL. You can check your code to find where use the StrLen and maybe you can find the result. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Nikolay

Re: [edk2] [PATCH v3 09/12] SecurityPkg/Opal: Refine casting expression result to bigger size

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 1:13 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A; Dong, Eric; Tian, Feng; Zhang, Chao B Subject: [PATCH v3 09/12] SecurityPkg/Opal: Refine casting expression

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Replace same logic with API in UefiBootManagerLib

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, February 27, 2017 3:19 PM To: Bi, Dandan; edk2-devel@lists.01.org Cc: Dong, Eric; Zeng, Star Subject: RE: [patch] MdeModulePkg/BMMUiLib: Replace same logic with API in UefiBootMana

Re: [edk2] [PATCH v2] MdeModulePkg/HiiDatabase: clean the value before setting default string

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, February 21, 2017 10:26 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming > Subject: [PATCH v2] MdeModulePkg/HiiDatabase: clean the value before s

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Remove old useless data before new save action

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, February 20, 2017 1:06 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

Re: [edk2] [patch] MdeModulePkg/HiiDatabase: clean the value before setting default string

Dandan, You need to also add check to avoid string size exceed the width. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, February 20, 2017 1:06 PM > To: edk2-devel@lists.01.org > C

Re: [edk2] [patch] MdeMoudlePkg/DisplayEngine: Fix incorrect index used in array "InputText"

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Friday, February 10, 2017 10:26 AM > To: edk2-devel@lists.01.org > Cc: Wang Cloud; Dong, Eric; Gao,

Re: [edk2] SetUnicodeMem in DisplayEngineDxe seems unsafe

Xiaofeng, Thanks, we will follow up to fix it. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang > xiaofeng > Sent: Wednesday, January 25, 2017 10:49 AM > To: Dong, Eric > Cc: edk2-devel@lists.01.org; Gao, Liming &g

Re: [edk2] SetUnicodeMem in DisplayEngineDxe seems unsafe

t; >>-Original Message- > >>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >>wang xiaofeng > >>Sent: Tuesday, January 24, 2017 3:56 PM > >>To: edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com> >

Re: [edk2] [patch 3/3] MdeModulePkg/FileExplorer: Enable functionality of creating new file/folder

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com

Re: [edk2] [patch 1/3] MdeModulePkg/FileExplorer: Remove the codes of searching load file protocol

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com

Re: [edk2] [patch 2/3] MdeModulePkg/FileExplorer: Update QuesrionId when Updating FileExplore form

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com

Re: [edk2] [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function

4:40 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zhang, Chao B > Subject: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with > the function > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Chao Zhang <chao.b.zh...@intel.com> > Contrib

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Initialize gConnectConInEvent earlier

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Monday, December 05, 2016 9:57 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zhang, Chao B > Subject: [PATCH] MdeModulePkg/BdsDxe: Initialize gC

Re: [edk2] [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, December 05, 2016 7:41 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject:

Re: [edk2] [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED.

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 29, 2016 12:56 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED. > > Accor

Re: [edk2] [PATCH 0/3] Support TCG2 BlockSID related actions

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Thursday, November 24, 2016 5:14 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Yao, Jiewen; Zhang, Chao B; Dong, Eric > Subject: [PATCH 0/3] Support TCG2 BlockSID

Re: [edk2] [Patch 00/10] Enable BlockSid related PP actions.

Jiewen, We have new solution to fix this issue, so I will rollback this series now and check in the new solution later. Thanks, Eric > -Original Message- > From: Yao, Jiewen > Sent: Monday, November 21, 2016 11:32 AM > To: Dong, Eric; edk2-devel@lists.01.org > Subject: RE

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Return the selectable menu correctly

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, November 22, 2016 11:15 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/DisplayEngine: Return the selectable men

Re: [edk2] [patch] MdeModulePkg/BMMUI: add comments for function parameter

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, November 10, 2016 3:40 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] MdeModulePkg/BMMUI: add comments for function parameter &g

Re: [edk2] [PATCH v2 9/9] Nt32Pkg/PlatformBds: Dispatch deferred images after EndOfDxe

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 08, 2016 8:29 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH v2 9/9] Nt32Pkg/PlatformBds: Dispatch deferred images after > EndO

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

nt: Thursday, November 03, 2016 7:13 AM > To: Dong, Eric; edk2-devel@lists.01.org > Cc: Bi, Dandan; Gao, Liming > Subject: Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp > > Eric, > > See my comments below > > -----Original Message- > From: Dong, Eric [mailto:eric.d.

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

Felix, Add my comments below. -Original Message- From: Felix Poludov [mailto:fel...@ami.com] Sent: Tuesday, November 1, 2016 4:22 AM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org Cc: Bi, Dandan <dandan...@intel.com>; Gao, Liming <liming@intel.com>

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

Hi Felix, Add my comments below. > -Original Message- > From: Felix Poludov [mailto:fel...@ami.com] > Sent: Friday, October 28, 2016 9:52 PM > To: Dong, Eric; edk2-devel@lists.01.org > Cc: Gao, Liming; Bi, Dandan > Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp >

Re: [edk2] [patch] IntelFrameworkModulePkg/BootMaint: Show "Change Boot order" page correctly

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Friday, October 28, 2016 10:33 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] IntelFrameworkModulePkg/BootMaint: Show "Change Boot order"

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

Hi Felix, Do you want to provide a new solution for CreatePopup or just want to split CreatePopup from UefiLib? We already has a proposal to provide new API to replace CreatePopup. This new API will use modal form to paint the UI. Detail you can see the proposal in below link:

Re: [edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the codes logic

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Monday, October 17, 2016 5:08 PM > To: Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Dong, Eric; Gao, Liming > Subject: RE: [edk2] [PATCH v2] MdeModulePkg/BootMaintenance

Re: [edk2] [PATCH 52/52] BaseTools/VfrCompile/Pccts: Make assignment operator not returning void

g > Cc: Wu, Hao A; Gao, Liming; Zhu, Yonghong; Dong, Eric; Bi, Dandan > Subject: [PATCH 52/52] BaseTools/VfrCompile/Pccts: Make assignment operator > not returning void > > The assignment operators for class ANTLRTokenPtr return void in current > code. > > This com

Re: [edk2] [PATCH 2/4] MdeModulePkg/UiApp: Show test key warning info in FrontPage.

> + *BannerStr = HiiGetString(gFrontPagePrivate.HiiHandle, > STRING_TOKEN(STR_TEST_KEY_USED_FIRMWARE_UPDATE), NULL); > +} Thanks, Eric > -Original Message- > From: Yao, Jiewen > Sent: Sunday, October 09, 2016 7:59 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric

Re: [edk2] [Patch] MdeModulePkg FormBrowserEx: Change its structure name with EDKII_ prefix

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Thursday, September 22, 2016 10:05 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Tian, Feng > Subject: [Patch] MdeModulePkg FormBrowserEx: Change its structure na

Re: [edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Wednesday, September 21, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Bi, Dandan > Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new >

Re: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Wednesday, September 21, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan; Dong, Eric >

Re: [edk2] [patch] MdeModulePkg/UiApp: Fix incorrect question id

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 08, 2016 5:10 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix incorrect question id > >

Re: [edk2] [patch] MdeModulePkg/HiiDB: Handle the "" tag in correctly

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Thursday, September 08, 2016 5:10 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

Re: [edk2] [patch] Nt32Pkg: Fix VS2010/VS2012 build failure

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, September 06, 2016 1:30 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] Nt32Pkg: Fix VS2010/VS2012 build failure > > Initialize the va

Re: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Zhang, Lubo > Sent: Thursday, August 11, 2016 3:19 PM > To: Dong, Eric > Cc: Ye, Ting; Fu, Siyuan; edk2-devel@lists.01.org > Subject: RE: [edk2] [patch] MdeModulePkg: Refine codes of i

Re: [edk2] [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 10, 2016 4:54 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] BaseTool/VfrCompile: Remove reset button opcode i

Re: [edk2] [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, July 26, 2016 9:12 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue > > In 32b

Re: [edk2] [PATCH] MdeModulePkg/Bds: Do not boot to UI again when BootNext points to UI

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, June 22, 2016 3:26 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Chan, Amy > Subject: [PATCH] MdeModulePkg/Bds: Do not boot to UI again when BootNext >

Re: [edk2] [patch] MdeModulePkg/UiApp: Fix the incorrect use of the HiiHandle

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Monday, June 13, 2016 9:42 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix the incorrect use of the HiiHandle > > In cu

Re: [edk2] [PATCH 0/5] Get SIO data from SIO interface

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Sunday, June 12, 2016 5:24 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/5] Get SIO data from SIO interface > >

Re: [edk2] [patch] MdeModulePkg/Database: Fix incorrect calculation of baseline in FontPackage

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, June 08, 2016 3:39 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/Database: Fix incorrect calculation of ba

Re: [edk2] [Patch v2] UefiCpuPkg/MtrrLib: Fixed bug if length is less than Fixed-MTRR range

Reviewed_by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Monday, June 06, 2016 2:00 PM > To: edk2-de...@ml01.01.org > Cc: Dong, Eric; Tian, Feng; Kinney, Michael D > Subject: [Patch v2] UefiCpuPkg/MtrrLib: Fixed bug if length is

Re: [edk2] [PATCH v2] MdeModulePkg/DisplayEngine: Fix memory leak issues in DisplayEngine

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Friday, May 20, 2016 10:12 AM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng; Qiu, Shumin; Dong, Eric > Subject: [PATCH v2] MdeModulePkg/DisplayEngine: Fix memory leak is

Re: [edk2] [Patch 0/2] Save the Boot mode info for later use.

Please help to check in the code. > -Original Message- > From: Gao, Liming > Sent: Thursday, May 19, 2016 9:25 AM > To: Dong, Eric; edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch 0/2] Save the Boot mode info for later use. > > Reviewed-by: Liming Gao

Re: [edk2] [PATCH 0/2] Fix GCC build failures introduced with a85be3ae48a8

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 13, 2016 5:51 PM > To: edk2-devel-01 > Cc: Ard Biesheuvel; Dong, Eric; Gerd Hoffmann; Gao, Liming > Subject: [PATCH 0/2] Fix GCC b

Re: [edk2] [patch] MdeModulePkg/SetupBrowser: Should free ConfigResp when it no longer be used

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, May 11, 2016 3:17 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] MdeModulePkg/SetupBrowser: Should free ConfigResp when it no > long

Re: [edk2] [Patch 0/2] Change code for easy customization.

Extra Notes for this change: It will do some small changes for the current front page and BootMaintenanceManager(BMM) page menus. Detail see below pic. Left is the current UI and right is the new UI. [cid:image014.jpg@01D1AC5A.DA2643F0][cid:image016.jpg@01D1AC5A.DA2643F0]

Re: [edk2] [PATCH v2] Security/OpalPasswordDxe: Enhance the logic in RouteConfig/ExtractConfig

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, May 10, 2016 10:52 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject:

Re: [edk2] [Patch v2] SecurityPkg OpalPasswordDxe: Error handling enhance when input password.

Clarify V2 patch include below changes: "unkown" -> "unknown" "continue boot?." -> "continue boot?" "Press Esc" -> "Press ESC" L"Confirm: Not unlock device and continue boot?.", -> L"Confirm: keep lock status and continue boot?", Also refine the patch comments. Thanks, Eric >

Re: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build fail

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, April 21, 2016 10:07 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On 05/04/16 03:10, Dong, Eric wrote: > >> On a separate but related note: The ConfigHdr portion of Request and > >> Response seems to contain absolutely zero information by the time it > >> reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can te

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message.

Yes, I checked all files. > -Original Message- > From: Tian, Feng > Sent: Friday, April 08, 2016 10:15 AM > To: Dong, Eric; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: RE: [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message. > > Do you check a

Re: [edk2] HII incompatibility between edk2 and iPXE?

> -Original Message- > From: Michael Brown [mailto:mc...@ipxe.org] > Sent: Saturday, April 02, 2016 12:50 AM > To: Laszlo Ersek; Dong, Eric; Bi, Dandan > Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel > Subject: Re: [edk2] HII incompatibility between edk2 and iPXE? &

Re: [edk2] HII incompatibility between edk2 and iPXE?

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 31, 2016 6:14 PM > To: Michael Brown; Dong, Eric; Bi, Dandan > Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel > Subject: Re: HII incompatibility between edk2 and iPXE? >

Re: [edk2] HII incompatibility between edk2 and iPXE?

Yes, we can also enhance Hiidatabase to not assert. From: Ni, Ruiyu Sent: Thursday, March 31, 2016 8:57 AM To: Dong, Eric; Laszlo Ersek; Bi, Dandan; Michael Brown Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel Subject: RE: HII incompatibility between edk2 and iPXE? Eric, Shall we also fix

Re: [edk2] HII incompatibility between edk2 and iPXE?

30, 2016 11:42 PM > To: Dong, Eric; Laszlo Ersek; Bi, Dandan > Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel > Subject: Re: HII incompatibility between edk2 and iPXE? > > On 30/03/16 16:09, Dong, Eric wrote: > > This error is caused by iPXE driver

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On 29/03/16 16:20, Laszlo Ersek wrote: > > recent edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII > configuration settings available to OS runtime") seems to trigger an issue > between edk2 and iPXE. > > Thanks for debugging this! > > Is iPXE misbehaving here? At the time that I implemented

Re: [edk2] HII incompatibility between edk2 and iPXE?

the ASSERT raised. Detail can check UEFI spec 2.6 chapter 33.2.1.5 and 33.5. Thanks, Eric -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, March 29, 2016 11:21 PM To: Bi, Dandan; Dong, Eric; Michael Brown Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel

Re: [edk2] [PATCH] * MdePkg: Add UEFI2.6 HII Font protocol definitions.

Hi Cecil, Two comments for this patch: 1. The patch is out of date, I can't apply this patch with latest code base. Can you help to regenerate it base on latest code base? 2. Two much useless changes in UefiInternalFormRepresentation.h (just like below changes), please update the patch to

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

Got it, I will update the code before I check in the code. > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, March 29, 2016 9:52 AM > To: Tian, Feng; Dong, Eric; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: RE: [Patch 1/8] MdePkg: Add definition fo

Re: [edk2] [PATCH 15/35] MdeModulePkg: BootMaintenanceManagerUiLib: remove set but unused variables

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 15/35]

Re: [edk2] [PATCH 16/35] MdeModulePkg: DeviceManagerUiLib: remove set but unused variables

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 16/35]

Re: [edk2] [Patch] NetworkPkg: Fix HII related problem in HTTP boot driver.

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Wednesday, March 23, 2016 3:39 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin; Dong, Eric > Subject

Re: [edk2] [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI for ChooseFile handler

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 22, 2016 11:37 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI f

Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support

If the driver provides menus in setup, it only need to install the HII packages through HiiAddPackages and provide Config Access Protocol to let setup browser extract/route data from/to the driver. setup browser don't care any other information in the driver. RAM disk driver already provide

Re: [edk2] [MdeModulePkg] Do we support redefinition of typedefs?

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Wednesday, March 16, 2016 2:06 AM > To: edk2-devel > Subject: [edk2] [MdeModulePkg] Do we support redefinition of typedefs? >

Re: [edk2] [PATCH] MdeModulePkg: Fixed incorrect Regular expression protocol MatchString return value.

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sheng, > Cecil (HPS SW) > Sent: Tuesday, March 15, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Zeng, Star > Subject: Re: [edk2]

Re: [edk2] [patch] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Refine the code

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, March 14, 2016 3:24 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

<    1   2   3   4   >